From: Wilco Dijkstra <Wilco.Dijkstra@arm.com>
To: Szabolcs Nagy <Szabolcs.Nagy@arm.com>
Cc: Szabolcs Nagy via Libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH] AArch64: Add hp-timing.h
Date: Thu, 1 Jul 2021 15:33:15 +0000 [thread overview]
Message-ID: <VE1PR08MB55996C7DFF8028C1DFB775C983009@VE1PR08MB5599.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <20210701134810.GF14854@arm.com>
Hi Szabolcs,
> then just say the commit only affects the glibc benchmark code.
>
> i'm happy to accept the commit with that.
I've changed the log to:
Add hp-timing.h using the cntvct_el0 counter. Return timing in nanoseconds
so it is fully compatible with generic hp-timing. Don't set HP_TIMING_INLINE
in the dynamic linker since it adds unnecessary overheads and some ancient
kernels may not handle emulating cntcvt correctly. Currently cntvct_el0 is
only used for timing in the benchtests.
> if we want to use it in the dynamic linker then we should
> dig into the potential kernel issues (what versions are
> affected etc)
Agreed. Plus which machines might be affected - not all CPUs have
trouble incrementing!
Cheers,
Wilco
next prev parent reply other threads:[~2021-07-01 15:33 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-28 10:11 Wilco Dijkstra
2021-06-28 10:20 ` Florian Weimer
2021-06-28 10:53 ` Wilco Dijkstra
2021-06-28 11:06 ` Florian Weimer
2021-06-28 11:35 ` Wilco Dijkstra
2021-06-28 11:39 ` Florian Weimer
2021-06-28 11:49 ` Szabolcs Nagy
2021-06-28 11:55 ` Adhemerval Zanella
2021-06-28 12:10 ` Wilco Dijkstra
2021-06-28 13:15 ` Adhemerval Zanella
2021-06-28 14:24 ` Wilco Dijkstra
2021-06-28 14:46 ` Adhemerval Zanella
2021-06-28 19:16 ` Wilco Dijkstra
2021-06-30 8:46 ` Szabolcs Nagy
2021-06-30 8:55 ` Florian Weimer
2021-06-30 9:33 ` Siddhesh Poyarekar
2021-07-01 10:21 ` Wilco Dijkstra
2021-07-01 13:48 ` Szabolcs Nagy
2021-07-01 15:33 ` Wilco Dijkstra [this message]
2021-07-06 11:33 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VE1PR08MB55996C7DFF8028C1DFB775C983009@VE1PR08MB5599.eurprd08.prod.outlook.com \
--to=wilco.dijkstra@arm.com \
--cc=Szabolcs.Nagy@arm.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).