public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
* [PATCH 0/2] localedata: Add locale for syr_SY [BZ #27063]
@ 2022-01-25  1:33 Emil Soleyman-Zomalan
  2022-01-25  1:33 ` [PATCH 1/2] Add locale for syr_SY Emil Soleyman-Zomalan
                   ` (2 more replies)
  0 siblings, 3 replies; 13+ messages in thread
From: Emil Soleyman-Zomalan @ 2022-01-25  1:33 UTC (permalink / raw)
  To: libc-alpha; +Cc: Emil Soleyman-Zomalan

Please add the Syriac language locale in the country of Syria. This follows the data and patterns setup in CLDR but not yet published: https://st.unicode.org/cldr-apps/v#/syr_SY/

I am also a contributor to the Unicode CLDR for Syriac.

Author: Emil Soleyman-Zomalan <emil@soleyman.com>

--

Emil Soleyman-Zomalan (2):
  Add locale for syr_SY
  Add syr_SY to the localedata apparatus

 localedata/Makefile       |   1 +
 localedata/SUPPORTED      |   1 +
 localedata/locales/syr_SY | 197 ++++++++++++++++++++++++++++++++++++++
 3 files changed, 199 insertions(+)
 create mode 100644 localedata/locales/syr_SY

-- 
2.32.0


^ permalink raw reply	[flat|nested] 13+ messages in thread

* [PATCH 1/2] Add locale for syr_SY
  2022-01-25  1:33 [PATCH 0/2] localedata: Add locale for syr_SY [BZ #27063] Emil Soleyman-Zomalan
@ 2022-01-25  1:33 ` Emil Soleyman-Zomalan
  2022-01-25  1:33 ` [PATCH 2/2] Add syr_SY to the localedata apparatus Emil Soleyman-Zomalan
  2022-04-06 16:32 ` [PATCH 0/2] localedata: Add locale for syr_SY [BZ #27063] Mike FABIAN
  2 siblings, 0 replies; 13+ messages in thread
From: Emil Soleyman-Zomalan @ 2022-01-25  1:33 UTC (permalink / raw)
  To: libc-alpha; +Cc: Emil Soleyman-Zomalan

---
 localedata/locales/syr_SY | 197 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 197 insertions(+)
 create mode 100644 localedata/locales/syr_SY

diff --git a/localedata/locales/syr_SY b/localedata/locales/syr_SY
new file mode 100644
index 0000000000..80cfad7745
--- /dev/null
+++ b/localedata/locales/syr_SY
@@ -0,0 +1,197 @@
+comment_char %
+escape_char /
+
+% This file is part of the GNU C Library and contains locale data.
+% The Free Software Foundation does not claim any copyright interest
+% in the locale data contained in this file.  The foregoing does not
+% affect the license of the GNU C Library as a whole.  It does not
+% exempt you from the conditions of the license if your use would
+% otherwise be governed by that license.
+
+%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
+%
+% Syriac language locale 
+%
+% build with: localedef -f UTF-8 -i syr_SY syr_SY
+%
+%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
+
+% Syriac Language Locale
+% Source: Emil Soleyman-Zomalan
+% Address:
+% Contact: Emil Soleyman-Zomalan
+% Email: emil@soleyman.com
+% Tel:
+% Fax:
+% Language: syr
+% Territory:
+% Revision: 0.2
+% Date: 2021-01-15
+% Application: general
+% Users: general
+% License: Public Domain
+
+LC_IDENTIFICATION
+title      "Syriac language locale"
+source     "Emil Soleyman-Zomalan"
+address    ""
+contact    ""
+email      "emil@soleyman.com"
+tel        ""
+fax        ""
+language   "Syriac"
+territory  ""
+revision   "0.2"
+date       "2021-01-15"
+
+category "i18n:2012";LC_IDENTIFICATION
+category "i18n:2012";LC_CTYPE
+category "i18n:2012";LC_COLLATE
+category "i18n:2012";LC_MONETARY
+category "i18n:2012";LC_NUMERIC
+category "i18n:2012";LC_TIME
+category "i18n:2012";LC_MESSAGES
+category "i18n:2012";LC_PAPER
+category "i18n:2012";LC_MEASUREMENT
+category "i18n:2012";LC_NAME
+category "i18n:2012";LC_ADDRESS
+category "i18n:2012";LC_TELEPHONE
+END LC_IDENTIFICATION
+
+LC_CTYPE
+copy "i18n"
+
+translit_start
+include "translit_combining";""
+translit_end
+END LC_CTYPE
+
+LC_COLLATE
+copy "iso14651_t1"
+END LC_COLLATE
+
+LC_MONETARY
+int_curr_symbol   "XDR "
+currency_symbol   "<U00A4>"
+mon_decimal_point "."
+mon_thousands_sep ","
+mon_grouping      3
+positive_sign     ""
+negative_sign     "-"
+int_frac_digits   2
+frac_digits       2
+p_cs_precedes     1
+p_sep_by_space    1
+n_cs_precedes     1
+n_sep_by_space    1
+p_sign_posn       1
+n_sign_posn       1
+END LC_MONETARY
+
+LC_NUMERIC
+decimal_point     "."
+thousands_sep     ","
+grouping          3
+END LC_NUMERIC
+
+LC_TIME
+% Syriac does not have abbreviations for month names. As a result,
+% "abmon" is similar to "mon"
+
+%
+% Abbreviated weekday names (%a)
+%
+abday    "<U0710>";/
+         "<U0712>";/
+         "<U0713>";/
+         "<U0715>";/
+         "<U0717>";/
+         "<U0725>";/
+         "<U072B>"
+%
+% Full weekday names (%A)
+%
+day      "<U071A><U0715> <U0712><U072B><U0712><U0710>";/
+         "<U072C><U072A><U071D><U0722> <U0712><U072B><U0712><U0710>";/
+         "<U072C><U0720><U072C> <U0712><U072B><U0712><U0710>";/
+         "<U0710><U072A><U0712><U0725> <U0712><U072B><U0712><U0710>";/
+         "<U071A><U0721><U072B> <U0712><U072B><U0712><U0710>";/
+         "<U0725><U072A><U0718><U0712><U072C><U0710>";/
+         "<U072B><U0712><U072C><U0710>"
+%
+% Abbreviated month names (%b)
+%
+abmon    "<U070F><U071F><U0722> <U070F><U0712>";/
+         "<U072B><U0712><U071B>";/
+         "<U0710><U0715><U072A>";/
+         "<U0722><U071D><U0723><U0722>";/
+         "<U0710><U071D><U072A>";/
+         "<U071A><U0719><U071D><U072A><U0722>";/
+         "<U072C><U0721><U0718><U0719>";/
+         "<U0710><U0712>";/
+         "<U0710><U071D><U0720><U0718><U0720>";/
+         "<U070F><U072C><U072B> <U070F><U0710>";/
+         "<U070F><U072C><U072B> <U070F><U0712>";/
+         "<U070F><U071F><U0722> <U070F><U0710>"
+%
+% Full month names (%B)
+%
+mon      "<U071F><U0722><U0718><U0722> <U0710><U071A><U072A><U071D><U0710>";/
+         "<U072B><U0712><U071B>";/
+         "<U0710><U0715><U072A>";/
+         "<U0722><U071D><U0723><U0722>";/
+         "<U0710><U071D><U072A>";/
+         "<U071A><U0719><U071D><U072A><U0722>";/
+         "<U072C><U0721><U0718><U0719>";/
+         "<U0710><U0712>";/
+         "<U0710><U071D><U0720><U0718><U0720>";/
+         "<U072C><U072B><U072A><U071D><U0722> <U0729><U0715><U0721><U071D><U0710>";/
+         "<U072C><U072B><U072A><U071D><U0722> <U0710><U071A><U072A><U071D><U0710>";/
+         "<U071F><U0722><U0718><U0722> <U0729><U0715><U0721><U071D><U0710>"
+
+
+d_t_fmt  "%H:%M:%S %Y %b %d %a"
+date_fmt "%Z %H:%M:%S %Y %b %d %a"
+d_fmt   "%d//%m//%Y"
+t_fmt   "%H:%M:%S"
+am_pm   "<U0729>.<U071B>";"<U0712>.<U071B>"
+t_fmt_ampm  "%I:%M:%S %P"
+week 7;19971130;1
+first_workday 1
+END LC_TIME
+
+LC_MESSAGES
+yesexpr "^[+1yY<U0717>]"
+noexpr  "^[-0nN<U0720>]"
+yesstr  "<U0717><U0710>"
+nostr   "<U0720><U0710>"
+END LC_MESSAGES
+
+LC_PAPER
+copy "i18n"
+END LC_PAPER
+
+LC_MEASUREMENT
+copy "i18n"
+END LC_MEASUREMENT
+
+LC_NAME
+name_fmt    "%d%t%s%t%g%t%m%t%f" 
+name_gen    ""
+name_miss   "<U0721><U071D><U0729><U072A><U072C><U0710>"
+name_ms     "<U0721><U071D><U0729><U072A><U072C><U0710>"
+name_mrs    "<U0721><U071D><U0729><U072A><U072C><U0710>"
+name_mr     "<U0721><U071D><U0729><U072A><U0710>"
+END LC_NAME
+
+LC_ADDRESS
+postal_fmt   "%f%N%a%N%d%N%b%N%s %h %e %r%N%%z %T%N%c%N"
+lang_name   "<U0723><U0718><U072A><U071D><U071D><U0710>"
+lang_term   "syr"
+lang_lib    "syr"
+END LC_ADDRESS
+
+LC_TELEPHONE
+tel_int_fmt "+%c %a%t%l"
+int_select  "00"
+END LC_TELEPHONE
-- 
2.32.0


^ permalink raw reply	[flat|nested] 13+ messages in thread

* [PATCH 2/2] Add syr_SY to the localedata apparatus
  2022-01-25  1:33 [PATCH 0/2] localedata: Add locale for syr_SY [BZ #27063] Emil Soleyman-Zomalan
  2022-01-25  1:33 ` [PATCH 1/2] Add locale for syr_SY Emil Soleyman-Zomalan
@ 2022-01-25  1:33 ` Emil Soleyman-Zomalan
  2022-04-06 16:32 ` [PATCH 0/2] localedata: Add locale for syr_SY [BZ #27063] Mike FABIAN
  2 siblings, 0 replies; 13+ messages in thread
From: Emil Soleyman-Zomalan @ 2022-01-25  1:33 UTC (permalink / raw)
  To: libc-alpha; +Cc: Emil Soleyman-Zomalan

---
 localedata/Makefile  | 1 +
 localedata/SUPPORTED | 1 +
 2 files changed, 2 insertions(+)

diff --git a/localedata/Makefile b/localedata/Makefile
index 79db713925..a84467caae 100644
--- a/localedata/Makefile
+++ b/localedata/Makefile
@@ -277,6 +277,7 @@ LOCALES := \
 	sr_RS.UTF-8 \
 	sv_SE.ISO-8859-1 \
 	sv_SE.UTF-8 \
+	syr_SY.UTF-8 \
 	szl_PL.UTF-8 \
 	tg_TJ.UTF-8 \
 	tk_TM.UTF-8 \
diff --git a/localedata/SUPPORTED b/localedata/SUPPORTED
index d768aa4795..12ec938848 100644
--- a/localedata/SUPPORTED
+++ b/localedata/SUPPORTED
@@ -426,6 +426,7 @@ sv_SE.UTF-8/UTF-8 \
 sv_SE/ISO-8859-1 \
 sw_KE/UTF-8 \
 sw_TZ/UTF-8 \
+syr_SY/UTF-8 \
 szl_PL/UTF-8 \
 ta_IN/UTF-8 \
 ta_LK/UTF-8 \
-- 
2.32.0


^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH 0/2] localedata: Add locale for syr_SY [BZ #27063]
  2022-01-25  1:33 [PATCH 0/2] localedata: Add locale for syr_SY [BZ #27063] Emil Soleyman-Zomalan
  2022-01-25  1:33 ` [PATCH 1/2] Add locale for syr_SY Emil Soleyman-Zomalan
  2022-01-25  1:33 ` [PATCH 2/2] Add syr_SY to the localedata apparatus Emil Soleyman-Zomalan
@ 2022-04-06 16:32 ` Mike FABIAN
  2022-04-06 16:39   ` Mike FABIAN
  2022-04-06 18:12   ` Emil Soleyman-Zomalan
  2 siblings, 2 replies; 13+ messages in thread
From: Mike FABIAN @ 2022-04-06 16:32 UTC (permalink / raw)
  To: Emil Soleyman-Zomalan; +Cc: libc-alpha

Emil Soleyman-Zomalan <emil@soleyman.com> さんはかきました:

> Please add the Syriac language locale in the country of Syria. This follows the data and patterns setup in CLDR but not yet published: https://st.unicode.org/cldr-apps/v#/syr_SY/
>
> I am also a contributor to the Unicode CLDR for Syriac.
>
> Author: Emil Soleyman-Zomalan <emil@soleyman.com>

Is this about classical Syriac (iso 639-3 code syc) or is this about
modern Syriac:

https://en.wikipedia.org/wiki/ISO_639_macrolanguage#syr

Wikipedia> syr is the ISO 639-3 language code for Syriac.
Wikipedia> There are two individual language codes assigned:
Wikipedia> 
Wikipedia>     aii – Assyrian Neo-Aramaic
Wikipedia>     cld – Chaldean Neo-Aramaic

> LC_MONETARY
> int_curr_symbol   "XDR "
> currency_symbol   "¤"

XDR is a quite weird currency code:

https://en.wikipedia.org/wiki/Special_drawing_rights

¤ is the generic currency sign.

If this is about the modern living language and if the country is SY,
shouldn‘t the currency be Syrian pound?:

https://en.wikipedia.org/wiki/Syrian_pound

i.e.

int_curr_symbol   "SYP "
currency_symbol   "£S"

https://github.com/unicode-org/cldr/blob/main/seed/main/syr.xml#L1086

has

		<currencies>
			<currency type="SYP">
				<symbol draft="unconfirmed">ل.س.‏</symbol>
			</currency>
		</currencies>

If the country is the modern Syria, then maybe add

int_prefix     "963"

to LC_TELEPHONE

?

-- 
Mike FABIAN <mfabian@redhat.com>
睡眠不足はいい仕事の敵だ。


^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH 0/2] localedata: Add locale for syr_SY [BZ #27063]
  2022-04-06 16:32 ` [PATCH 0/2] localedata: Add locale for syr_SY [BZ #27063] Mike FABIAN
@ 2022-04-06 16:39   ` Mike FABIAN
  2022-04-06 18:12   ` Emil Soleyman-Zomalan
  1 sibling, 0 replies; 13+ messages in thread
From: Mike FABIAN @ 2022-04-06 16:39 UTC (permalink / raw)
  To: Emil Soleyman-Zomalan; +Cc: libc-alpha

Mike FABIAN <mfabian@redhat.com> さんはかきました:

> Emil Soleyman-Zomalan <emil@soleyman.com> さんはかきました:
>
>> Please add the Syriac language locale in the country of Syria. This
>> follows the data and patterns setup in CLDR but not yet published:
>> https://st.unicode.org/cldr-apps/v#/syr_SY/
>>
>> I am also a contributor to the Unicode CLDR for Syriac.
>>
>> Author: Emil Soleyman-Zomalan <emil@soleyman.com>
>
> Is this about classical Syriac (iso 639-3 code syc) or is this about
> modern Syriac:
>
> https://en.wikipedia.org/wiki/ISO_639_macrolanguage#syr
>
> Wikipedia> syr is the ISO 639-3 language code for Syriac.
> Wikipedia> There are two individual language codes assigned:
> Wikipedia> 
> Wikipedia>     aii – Assyrian Neo-Aramaic
> Wikipedia>     cld – Chaldean Neo-Aramaic
>
>> LC_MONETARY
>> int_curr_symbol   "XDR "
>> currency_symbol   "¤"
>
> XDR is a quite weird currency code:
>
> https://en.wikipedia.org/wiki/Special_drawing_rights
>
> ¤ is the generic currency sign.
>
> If this is about the modern living language and if the country is SY,
> shouldn‘t the currency be Syrian pound?:
>
> https://en.wikipedia.org/wiki/Syrian_pound
>
> i.e.
>
> int_curr_symbol   "SYP "
> currency_symbol   "£S"
>
> https://github.com/unicode-org/cldr/blob/main/seed/main/syr.xml#L1086
>
> has
>
> 		<currencies>
> 			<currency type="SYP">
> 				<symbol draft="unconfirmed">ل.س.‏</symbol>
> 			</currency>
> 		</currencies>
>
> If the country is the modern Syria, then maybe add
>
> int_prefix     "963"
>
> to LC_TELEPHONE
>
> ?

And could you please also add a file localedata/syr_SY.UTF-8.in
containing lines with characters and/or words in Syriac in the correct
sort order?

-- 
Mike FABIAN <mfabian@redhat.com>
睡眠不足はいい仕事の敵だ。


^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH 0/2] localedata: Add locale for syr_SY [BZ #27063]
  2022-04-06 16:32 ` [PATCH 0/2] localedata: Add locale for syr_SY [BZ #27063] Mike FABIAN
  2022-04-06 16:39   ` Mike FABIAN
@ 2022-04-06 18:12   ` Emil Soleyman-Zomalan
  2022-04-06 18:28     ` Florian Weimer
  1 sibling, 1 reply; 13+ messages in thread
From: Emil Soleyman-Zomalan @ 2022-04-06 18:12 UTC (permalink / raw)
  To: Mike FABIAN; +Cc: libc-alpha

On Wed, Apr 6, 2022, at 11:32, Mike FABIAN wrote:
>
> Is this about classical Syriac (iso 639-3 code syc) or is this about
> modern Syriac:
>
> https://en.wikipedia.org/wiki/ISO_639_macrolanguage#syr
>
> Wikipedia> syr is the ISO 639-3 language code for Syriac.
> Wikipedia> There are two individual language codes assigned:
> Wikipedia> 
> Wikipedia>     aii – Assyrian Neo-Aramaic
> Wikipedia>     cld – Chaldean Neo-Aramaic

Syr covers both modern and classical as it is default for all literary Syriac.

https://www.syriaca.org/documentation/isostandards.html

>> LC_MONETARY
>> int_curr_symbol   "XDR "
>> currency_symbol   "¤"
>
> XDR is a quite weird currency code:
>
> https://en.wikipedia.org/wiki/Special_drawing_rights
>
> ¤ is the generic currency sign.
>
> If this is about the modern living language and if the country is SY,
> shouldn‘t the currency be Syrian pound?:
>
> https://en.wikipedia.org/wiki/Syrian_pound
>
> i.e.
>
> int_curr_symbol   "SYP "
> currency_symbol   "£S"

> https://github.com/unicode-org/cldr/blob/main/seed/main/syr.xml#L1086
>
> has
>
> 		<currencies>
> 			<currency type="SYP">
> 				<symbol draft="unconfirmed">ل.س.‏</symbol>
> 			</currency>
> 		</currencies>
>
> If the country is the modern Syria, then maybe add
>
> int_prefix     "963"
>
> to LC_TELEPHONE
>
> ?

The only reason I have shied away from using the Syrian Pound and corresponding symbol as well as the telephone prefix as we have Syriac readers and writers throughout the Middle East including Iran, Iraq, Syria, Turkey and of course the diaspora.

These locale settings will apply to all of these readers irrespective of their location. I have attempted to make it generic in that regard.

I would appreciate any guidance though.
 
―
Emil Soleyman-Zomalan

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH 0/2] localedata: Add locale for syr_SY [BZ #27063]
  2022-04-06 18:12   ` Emil Soleyman-Zomalan
@ 2022-04-06 18:28     ` Florian Weimer
  2022-04-06 19:10       ` Emil Soleyman-Zomalan
  0 siblings, 1 reply; 13+ messages in thread
From: Florian Weimer @ 2022-04-06 18:28 UTC (permalink / raw)
  To: Emil Soleyman-Zomalan; +Cc: Mike FABIAN, libc-alpha

* Emil Soleyman-Zomalan:

> The only reason I have shied away from using the Syrian Pound and
> corresponding symbol as well as the telephone prefix as we have Syriac
> readers and writers throughout the Middle East including Iran, Iraq,
> Syria, Turkey and of course the diaspora.
>
> These locale settings will apply to all of these readers irrespective
> of their location. I have attempted to make it generic in that regard.

Should it be a country-less locale like eo?

Thanks,
Florian


^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH 0/2] localedata: Add locale for syr_SY [BZ #27063]
  2022-04-06 18:28     ` Florian Weimer
@ 2022-04-06 19:10       ` Emil Soleyman-Zomalan
  2022-04-09 17:39         ` Emil Soleyman-Zomalan
  0 siblings, 1 reply; 13+ messages in thread
From: Emil Soleyman-Zomalan @ 2022-04-06 19:10 UTC (permalink / raw)
  To: Florian Weimer; +Cc: Mike FABIAN, libc-alpha

On Wed, Apr 6, 2022, at 13:28, Florian Weimer wrote:
>
> Should it be a country-less locale like eo?

I can tell you that Microsoft Windows has had a Syriac locale since Windows 8 and uses the Syrian Pound as a currency but no telephone prefix.

Given that we are a country-less and region-less people, it might make sense to go with a country-less locale like eo. I know that there are pros and cons to this but nothing is coming to mind right now.

―
Emil Soleyman-Zomalan

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH 0/2] localedata: Add locale for syr_SY [BZ #27063]
  2022-04-06 19:10       ` Emil Soleyman-Zomalan
@ 2022-04-09 17:39         ` Emil Soleyman-Zomalan
  2022-04-19 13:43           ` Mike FABIAN
  0 siblings, 1 reply; 13+ messages in thread
From: Emil Soleyman-Zomalan @ 2022-04-09 17:39 UTC (permalink / raw)
  To: Florian Weimer; +Cc: Mike FABIAN, libc-alpha

On Wed, Apr 6, 2022, at 14:10, Emil Soleyman-Zomalan wrote:
>
> I can tell you that Microsoft Windows has had a Syriac locale since 
> Windows 8 and uses the Syrian Pound as a currency but no telephone 
> prefix.
>
> Given that we are a country-less and region-less people, it might make 
> sense to go with a country-less locale like eo. I know that there are 
> pros and cons to this but nothing is coming to mind right now.
>

I have added the syr_SY.UTF-8.in file to bugzilla#27063. I would like to say let's move forward with the country-less version of the Syriac locale.

―
Emil Soleyman-Zomalan, MD FAAEM

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH 0/2] localedata: Add locale for syr_SY [BZ #27063]
  2022-04-09 17:39         ` Emil Soleyman-Zomalan
@ 2022-04-19 13:43           ` Mike FABIAN
  2022-04-19 19:42             ` Emil Soleyman-Zomalan
  0 siblings, 1 reply; 13+ messages in thread
From: Mike FABIAN @ 2022-04-19 13:43 UTC (permalink / raw)
  To: Emil Soleyman-Zomalan; +Cc: Florian Weimer, libc-alpha

"Emil Soleyman-Zomalan" <emil@soleyman.com> さんはかきました:

> On Wed, Apr 6, 2022, at 14:10, Emil Soleyman-Zomalan wrote:
>>
>> I can tell you that Microsoft Windows has had a Syriac locale since 
>> Windows 8 and uses the Syrian Pound as a currency but no telephone 
>> prefix.
>>
>> Given that we are a country-less and region-less people, it might make 
>> sense to go with a country-less locale like eo. I know that there are 
>> pros and cons to this but nothing is coming to mind right now.
>>
>
> I have added the syr_SY.UTF-8.in file to bugzilla#27063. I would like
> to say let's move forward with the country-less version of the Syriac
> locale.

I am working on adding this to glibc now. I used the locale attached to
the bug and the syr_SY.UTF-8.in from the bug and renamed it to
syr.UTF-8.in

The sorting test case fails like this:

syr.UTF-8 collate-test FAIL
  --- syr.UTF-8.in      2022-04-19 13:07:31.675953523 +0200
  +++ /local/mfabian/src/glibc-build/localedata/syr.UTF-8.out   2022-04-19 14:42:15.977224807
 +0200
  @@ -1,14 +1,14 @@
   ; Symbol         Name                                                        Hex Code
   ; ------+------+---------------------------------------+--------+
  -ܐ        ;       Syriac Letter Alaph                             U+0710
   ܑ         ;       Syriac Letter Superscript Alaph                 U+0711
  +ܐ        ;       Syriac Letter Alaph                             U+0710
   ܒ        ;       Syriac Letter Beth                              U+0712
   ܭ        ;       Syriac Letter Persian Bheth                 U+072D
   ܓ        ;       Syriac Letter Gamal                             U+0713
   ܔ        ;       Syriac Letter Gamal Garshuni                    U+0714
   ܮ        ;       Syriac Letter Persian Ghamal                    U+072E
  -ܕ        ;       Syriac Letter Dalath                                U+0715
   ܖ        ;       Syriac Letter Dotless Dalath Rish       U+0716
  +ܕ        ;       Syriac Letter Dalath                                U+0715
   ܯ        ;       Syriac Letter Persian Dhalath                   U+072F
   ܗ        ;       Syriac Letter He                                U+0717
   ܘ        ;       Syriac Letter Waw                               U+0718

Your locale uses

LC_COLLATE
copy "iso14651_t1"
END LC_COLLATE

i.e. it includes the file with the default Unicode collation.

Your test file has two characters in a different order.

If the default Unicode collation order is OK for you, I would fix the
test file accordingly (My preferred solution, I would deviate from the
default only if necessary).

If these two characters  really should be ordered as in your test file,
I would add extra rules to the LC_COLLATE section to achieve that:

LC_COLLATE
copy "iso14651_t1"

... more rules here ...

END LC_COLLATE

But that is extra effort and I wonder whether this is needed.
There is no collation information in CLDR yet, no file

common/collation/syr.xml

exists currently in CLDR.

You said you are also the contributor to the Unicode CLDR for Syriac.
But you didn’t add a collation file there. If that means the default
order is OK, then just doing

LC_COLLATE
copy "iso14651_t1"
END LC_COLLATE

should be enough and I should fix the test file.

-- 
Mike FABIAN <mfabian@redhat.com>
睡眠不足はいい仕事の敵だ。


^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH 0/2] localedata: Add locale for syr_SY [BZ #27063]
  2022-04-19 13:43           ` Mike FABIAN
@ 2022-04-19 19:42             ` Emil Soleyman-Zomalan
  2022-04-20 15:59               ` Mike FABIAN
  0 siblings, 1 reply; 13+ messages in thread
From: Emil Soleyman-Zomalan @ 2022-04-19 19:42 UTC (permalink / raw)
  To: Mike FABIAN; +Cc: Florian Weimer, libc-alpha

On Tue, Apr 19, 2022, at 08:43, Mike FABIAN wrote:
>
> I am working on adding this to glibc now. I used the locale attached to
> the bug and the syr_SY.UTF-8.in from the bug and renamed it to
> syr.UTF-8.in

...

> But that is extra effort and I wonder whether this is needed.
> There is no collation information in CLDR yet, no file
>
> common/collation/syr.xml
>
> exists currently in CLDR.
>
> You said you are also the contributor to the Unicode CLDR for Syriac.
> But you didn’t add a collation file there. If that means the default
> order is OK, then just doing
>
> LC_COLLATE
> copy "iso14651_t1"
> END LC_COLLATE
>
> should be enough and I should fix the test file.

I have fixed the test file because the ordering won't make a difference in the end for those two letters and should not fail now (hopefully). I'm working on getting the collation setup with CLDR during their next submission cycle that starts on May 18.

I have updated bugzilla.

Thank you for your help!

―
Emil Soleyman-Zomalan

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH 0/2] localedata: Add locale for syr_SY [BZ #27063]
  2022-04-19 19:42             ` Emil Soleyman-Zomalan
@ 2022-04-20 15:59               ` Mike FABIAN
  2022-04-21 16:17                 ` Emil Soleyman-Zomalan
  0 siblings, 1 reply; 13+ messages in thread
From: Mike FABIAN @ 2022-04-20 15:59 UTC (permalink / raw)
  To: Emil Soleyman-Zomalan; +Cc: Florian Weimer, libc-alpha

"Emil Soleyman-Zomalan" <emil@soleyman.com> さんはかきました:

> I have updated bugzilla.

Thank you, looks good to me, except the second line in the test file:

; Symbol	    Name					                Hex Code
; ------+------+---------------------------------------+--------+
ܑ	    ;	    Syriac Letter Superscript Alaph		    U+0711

still makes the test fail because "; S" sorts after "; -".

I removed that line and attached an updated patch to

https://sourceware.org/bugzilla/show_bug.cgi?id=27063
https://sourceware.org/bugzilla/attachment.cgi?id=14074

I think this looks good and I can commit it.

-- 
Mike FABIAN <mfabian@redhat.com>
睡眠不足はいい仕事の敵だ。


^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH 0/2] localedata: Add locale for syr_SY [BZ #27063]
  2022-04-20 15:59               ` Mike FABIAN
@ 2022-04-21 16:17                 ` Emil Soleyman-Zomalan
  0 siblings, 0 replies; 13+ messages in thread
From: Emil Soleyman-Zomalan @ 2022-04-21 16:17 UTC (permalink / raw)
  To: Mike FABIAN; +Cc: Florian Weimer, libc-alpha

On Wed, Apr 20, 2022, at 10:59, Mike FABIAN wrote:
> I removed that line and attached an updated patch to
>
> https://sourceware.org/bugzilla/show_bug.cgi?id=27063
> https://sourceware.org/bugzilla/attachment.cgi?id=14074
>
> I think this looks good and I can commit it.

Thank you for all of your help. I appreciate it greatly.

―
Emil Soleyman-Zomalan

^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2022-04-21 16:17 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-25  1:33 [PATCH 0/2] localedata: Add locale for syr_SY [BZ #27063] Emil Soleyman-Zomalan
2022-01-25  1:33 ` [PATCH 1/2] Add locale for syr_SY Emil Soleyman-Zomalan
2022-01-25  1:33 ` [PATCH 2/2] Add syr_SY to the localedata apparatus Emil Soleyman-Zomalan
2022-04-06 16:32 ` [PATCH 0/2] localedata: Add locale for syr_SY [BZ #27063] Mike FABIAN
2022-04-06 16:39   ` Mike FABIAN
2022-04-06 18:12   ` Emil Soleyman-Zomalan
2022-04-06 18:28     ` Florian Weimer
2022-04-06 19:10       ` Emil Soleyman-Zomalan
2022-04-09 17:39         ` Emil Soleyman-Zomalan
2022-04-19 13:43           ` Mike FABIAN
2022-04-19 19:42             ` Emil Soleyman-Zomalan
2022-04-20 15:59               ` Mike FABIAN
2022-04-21 16:17                 ` Emil Soleyman-Zomalan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).