From: Fangrui Song <maskray@google.com>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH v2 4/4] Apply asm redirection in gmp.h before first use
Date: Sun, 6 Nov 2022 15:33:28 -0800 [thread overview]
Message-ID: <20221106233328.kf2uoibbe24omokm@google.com> (raw)
In-Reply-To: <20221102145559.1962008-5-adhemerval.zanella@linaro.org>
On 2022-11-02, Adhemerval Zanella wrote:
>For clang the redeclaration after the first use, the visibility attribute
>is silently ignored (symbol is STV_DEFAULT) while the asm label attribute
>causes an error.
>---
> include/gmp.h | 12 ---------
> stdlib/gmp.h | 72 ++++++++++++++++++++++++++++-----------------------
> 2 files changed, 39 insertions(+), 45 deletions(-)
>
>[...]
Looks good from v1.
Reviewed-by: Fangrui Song <maskray@google.com>
prev parent reply other threads:[~2022-11-06 23:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-02 14:55 [PATCH v2 0/4] Initial fixes for clang build support Adhemerval Zanella
2022-11-02 14:55 ` [PATCH v2 1/4] Disable __USE_EXTERN_INLINES for clang Adhemerval Zanella
2022-11-02 14:55 ` [PATCH v2 2/4] Rewrite find_cxx_header config configure.ac Adhemerval Zanella
2022-11-06 23:31 ` Fangrui Song
2022-11-07 13:22 ` Florian Weimer
2022-11-07 13:36 ` Adhemerval Zanella Netto
2022-11-02 14:55 ` [PATCH v2 3/4] stdlib: Remove if inline asm context casts if compiler does not support it Adhemerval Zanella
2022-11-02 14:55 ` [PATCH v2 4/4] Apply asm redirection in gmp.h before first use Adhemerval Zanella
2022-11-06 23:33 ` Fangrui Song [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221106233328.kf2uoibbe24omokm@google.com \
--to=maskray@google.com \
--cc=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).