From: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>
To: Florian Weimer <fweimer@redhat.com>,
Adhemerval Zanella via Libc-alpha <libc-alpha@sourceware.org>
Cc: Fangrui Song <maskray@google.com>
Subject: Re: [PATCH v2 2/4] Rewrite find_cxx_header config configure.ac
Date: Mon, 7 Nov 2022 10:36:06 -0300 [thread overview]
Message-ID: <b115f4b4-38fd-7702-6a39-a410e162ae09@linaro.org> (raw)
In-Reply-To: <874jvakig9.fsf@oldenburg.str.redhat.com>
On 07/11/22 10:22, Florian Weimer wrote:
> * Adhemerval Zanella via Libc-alpha:
>
>> diff --git a/configure b/configure
>> index fc3d7842de..e23ea95a49 100755
>> --- a/configure
>> +++ b/configure
>> @@ -5669,8 +5669,8 @@ fi
>> # copy of those headers in Makerules.
>> if test -n "$CXX"; then
>> find_cxx_header () {
>> - echo "#include <$1>" | $CXX -M -MP -x c++ - 2>/dev/null \
>> - | sed -n "\,$1:,{s/:\$//;p}"
>> + echo "#include <$1>" | $CXX -H -fsyntax-only -x c++ - 2>&1 \
>> + | awk '$1 == "."{print $2}'
>> }
>> CXX_CSTDLIB_HEADER="$(find_cxx_header cstdlib)"
>> CXX_CMATH_HEADER="$(find_cxx_header cmath)"
>
> Shouldn't this use $ac_cv_prog_AWK?
It should be $AWK in fact, I will fix it before commit.
next prev parent reply other threads:[~2022-11-07 13:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-02 14:55 [PATCH v2 0/4] Initial fixes for clang build support Adhemerval Zanella
2022-11-02 14:55 ` [PATCH v2 1/4] Disable __USE_EXTERN_INLINES for clang Adhemerval Zanella
2022-11-02 14:55 ` [PATCH v2 2/4] Rewrite find_cxx_header config configure.ac Adhemerval Zanella
2022-11-06 23:31 ` Fangrui Song
2022-11-07 13:22 ` Florian Weimer
2022-11-07 13:36 ` Adhemerval Zanella Netto [this message]
2022-11-02 14:55 ` [PATCH v2 3/4] stdlib: Remove if inline asm context casts if compiler does not support it Adhemerval Zanella
2022-11-02 14:55 ` [PATCH v2 4/4] Apply asm redirection in gmp.h before first use Adhemerval Zanella
2022-11-06 23:33 ` Fangrui Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b115f4b4-38fd-7702-6a39-a410e162ae09@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=maskray@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).