* [PATCH] doc: correct _FORTIFY_SOURCE doc in features.h
@ 2023-01-31 13:25 fanquake
2023-01-31 14:20 ` Siddhesh Poyarekar
0 siblings, 1 reply; 4+ messages in thread
From: fanquake @ 2023-01-31 13:25 UTC (permalink / raw)
To: libc-alpha; +Cc: fanquake
---
include/features.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/features.h b/include/features.h
index 7d2c7a4f87..07c73b3e55 100644
--- a/include/features.h
+++ b/include/features.h
@@ -57,7 +57,8 @@
__STRICT_ANSI__).
_FORTIFY_SOURCE Add security hardening to many library functions.
- Set to 1 or 2; 2 performs stricter checks than 1.
+ Set to 1, 2 or 3; 3 performs stricter checks than 2, which
+ performs stricter checks than 1.
_REENTRANT, _THREAD_SAFE
Obsolete; equivalent to _POSIX_C_SOURCE=199506L.
--
2.39.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] doc: correct _FORTIFY_SOURCE doc in features.h
2023-01-31 13:25 [PATCH] doc: correct _FORTIFY_SOURCE doc in features.h fanquake
@ 2023-01-31 14:20 ` Siddhesh Poyarekar
2023-01-31 20:29 ` Carlos O'Donell
0 siblings, 1 reply; 4+ messages in thread
From: Siddhesh Poyarekar @ 2023-01-31 14:20 UTC (permalink / raw)
To: fanquake, libc-alpha, Carlos O'Donell
Thanks, that looks correct. Carlos, may I push this before you cut the
release?
Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org>
On 2023-01-31 08:25, fanquake via Libc-alpha wrote:
> ---
> include/features.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/include/features.h b/include/features.h
> index 7d2c7a4f87..07c73b3e55 100644
> --- a/include/features.h
> +++ b/include/features.h
> @@ -57,7 +57,8 @@
> __STRICT_ANSI__).
>
> _FORTIFY_SOURCE Add security hardening to many library functions.
> - Set to 1 or 2; 2 performs stricter checks than 1.
> + Set to 1, 2 or 3; 3 performs stricter checks than 2, which
> + performs stricter checks than 1.
>
> _REENTRANT, _THREAD_SAFE
> Obsolete; equivalent to _POSIX_C_SOURCE=199506L.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] doc: correct _FORTIFY_SOURCE doc in features.h
2023-01-31 14:20 ` Siddhesh Poyarekar
@ 2023-01-31 20:29 ` Carlos O'Donell
2023-01-31 22:34 ` Siddhesh Poyarekar
0 siblings, 1 reply; 4+ messages in thread
From: Carlos O'Donell @ 2023-01-31 20:29 UTC (permalink / raw)
To: Siddhesh Poyarekar, fanquake, libc-alpha
On 1/31/23 09:20, Siddhesh Poyarekar wrote:
> Thanks, that looks correct. Carlos, may I push this before you cut the release?
>
> Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org>
Yes, comment only fix in headers. OK for 2.37. Please push ASAP.
> On 2023-01-31 08:25, fanquake via Libc-alpha wrote:
>> ---
>> include/features.h | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/include/features.h b/include/features.h
>> index 7d2c7a4f87..07c73b3e55 100644
>> --- a/include/features.h
>> +++ b/include/features.h
>> @@ -57,7 +57,8 @@
>> __STRICT_ANSI__).
>> _FORTIFY_SOURCE Add security hardening to many library functions.
>> - Set to 1 or 2; 2 performs stricter checks than 1.
>> + Set to 1, 2 or 3; 3 performs stricter checks than 2, which
>> + performs stricter checks than 1.
>> _REENTRANT, _THREAD_SAFE
>> Obsolete; equivalent to _POSIX_C_SOURCE=199506L.
>
--
Cheers,
Carlos.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] doc: correct _FORTIFY_SOURCE doc in features.h
2023-01-31 20:29 ` Carlos O'Donell
@ 2023-01-31 22:34 ` Siddhesh Poyarekar
0 siblings, 0 replies; 4+ messages in thread
From: Siddhesh Poyarekar @ 2023-01-31 22:34 UTC (permalink / raw)
To: Carlos O'Donell, fanquake, libc-alpha
On 2023-01-31 15:29, Carlos O'Donell wrote:
> On 1/31/23 09:20, Siddhesh Poyarekar wrote:
>> Thanks, that looks correct. Carlos, may I push this before you cut the release?
>>
>> Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org>
>
> Yes, comment only fix in headers. OK for 2.37. Please push ASAP.
>
Pushed, thanks.
Sid
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-01-31 22:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-31 13:25 [PATCH] doc: correct _FORTIFY_SOURCE doc in features.h fanquake
2023-01-31 14:20 ` Siddhesh Poyarekar
2023-01-31 20:29 ` Carlos O'Donell
2023-01-31 22:34 ` Siddhesh Poyarekar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).