* [PATCH] Naming the parameter of dummy_sa_handler
@ 2023-02-13 15:07 MAHESH BODAPATI
2023-02-13 16:22 ` Adhemerval Zanella Netto
0 siblings, 1 reply; 2+ messages in thread
From: MAHESH BODAPATI @ 2023-02-13 15:07 UTC (permalink / raw)
To: libc-alpha; +Cc: Mahesh Bodapati
From: Mahesh Bodapati <mahesh.bodapati@ibm.com>
ISO C does not support omitting parameter names in function definitions
before C2X,the compiler is giving an error with older versions of gcc and
this commit will resolve the test failure "error: parameter name omitted"
---
posix/tst-spawn7.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/posix/tst-spawn7.c b/posix/tst-spawn7.c
index a1c0d9d942..fedb09fb94 100644
--- a/posix/tst-spawn7.c
+++ b/posix/tst-spawn7.c
@@ -92,7 +92,7 @@ spawn_signal_test (const char *type, const posix_spawnattr_t *attr)
}
static void
-dummy_sa_handler (int)
+dummy_sa_handler (int signal)
{
}
--
2.31.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] Naming the parameter of dummy_sa_handler
2023-02-13 15:07 [PATCH] Naming the parameter of dummy_sa_handler MAHESH BODAPATI
@ 2023-02-13 16:22 ` Adhemerval Zanella Netto
0 siblings, 0 replies; 2+ messages in thread
From: Adhemerval Zanella Netto @ 2023-02-13 16:22 UTC (permalink / raw)
To: MAHESH BODAPATI, libc-alpha; +Cc: Mahesh Bodapati
On 13/02/23 12:07, MAHESH BODAPATI via Libc-alpha wrote:
> From: Mahesh Bodapati <mahesh.bodapati@ibm.com>
>
> ISO C does not support omitting parameter names in function definitions
> before C2X,the compiler is giving an error with older versions of gcc and
> this commit will resolve the test failure "error: parameter name omitted"
LGTM, thanks.
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
> ---
> posix/tst-spawn7.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/posix/tst-spawn7.c b/posix/tst-spawn7.c
> index a1c0d9d942..fedb09fb94 100644
> --- a/posix/tst-spawn7.c
> +++ b/posix/tst-spawn7.c
> @@ -92,7 +92,7 @@ spawn_signal_test (const char *type, const posix_spawnattr_t *attr)
> }
>
> static void
> -dummy_sa_handler (int)
> +dummy_sa_handler (int signal)
> {
> }
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-02-13 16:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-13 15:07 [PATCH] Naming the parameter of dummy_sa_handler MAHESH BODAPATI
2023-02-13 16:22 ` Adhemerval Zanella Netto
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).