From: Vincent Lefevre <vincent@vinc17.net>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: Simon Chopin <simon.chopin@canonical.com>, libc-alpha@sourceware.org
Subject: Re: UB status of snprintf on invalid ptr+size combination?
Date: Wed, 15 Mar 2023 13:39:49 +0100 [thread overview]
Message-ID: <20230315123949.GC73312@zira.vinc17.org> (raw)
In-Reply-To: <a5bda742-c534-f5a6-abba-39d29c26f01e@cs.ucla.edu>
About
snprintf(buf, INT_MAX, "%s", "Hello world");
On 2023-03-14 14:39:42 -0700, Paul Eggert wrote:
> On 3/14/23 12:47, Simon Chopin via Libc-alpha wrote:
> > When the issue was first discovered[1], I didn't raise the issue because I
> > dismissed it as UB, but it reappeared in an unrelated context, and
> > colleagues pointed out that the wording in the standard doesn't actually
> > say that the `n` argument is the size of the array.
>
> That sounds like a misreading of the C standard. Even though the standard
> often does not explicitly say that a size argument is the size of an array,
> it's obvious from context that this is intended. So Florian is correct here
> that the call with INT_MAX is not portable C code.
No, it is not obvious. If the C standard does not say that this is
the size of the array, then it does not have to be the size of the
array. The C standard just says:
Otherwise, output characters beyond the n-1st are discarded rather
than being written to the array, and a null character is written at
the end of the characters actually written into the array.
In practice, it is possible that the check of the buffer size has
already been done somewhere else, so that using a larger value for n
is fine.
--
Vincent Lefèvre <vincent@vinc17.net> - Web: <https://www.vinc17.net/>
100% accessible validated (X)HTML - Blog: <https://www.vinc17.net/blog/>
Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)
next prev parent reply other threads:[~2023-03-15 12:39 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-14 19:47 Simon Chopin
2023-03-14 21:39 ` Paul Eggert
2023-03-15 9:22 ` Andreas Schwab
2023-03-15 15:54 ` Siddhesh Poyarekar
2023-03-15 18:34 ` Michael Hudson-Doyle
2023-03-19 14:45 ` manfred
2023-03-19 23:07 ` Vincent Lefevre
2023-03-20 12:05 ` Siddhesh Poyarekar
2023-03-20 12:17 ` Alejandro Colomar
2023-03-20 12:29 ` Siddhesh Poyarekar
2023-03-20 13:36 ` Vincent Lefevre
2023-03-20 13:50 ` Vincent Lefevre
2023-03-20 16:56 ` Siddhesh Poyarekar
2023-03-20 17:36 ` Vincent Lefevre
2023-03-20 15:09 ` Vincent Lefevre
2023-03-20 16:15 ` Alejandro Colomar
2023-03-20 16:33 ` Vincent Lefevre
2023-03-20 17:00 ` Vincent Lefevre
2023-03-20 17:31 ` Siddhesh Poyarekar
2023-03-20 17:45 ` Vincent Lefevre
2023-03-15 12:39 ` Vincent Lefevre [this message]
2023-03-16 10:29 ` Stephan Bergmann
2023-03-18 2:07 ` Vincent Lefevre
2023-03-18 2:30 ` Alejandro Colomar
2023-03-18 10:58 ` Vincent Lefevre
2023-03-18 15:01 ` Andreas Schwab
2023-03-19 22:48 ` Vincent Lefevre
2023-03-19 23:24 ` Andreas Schwab
2023-03-20 4:10 ` Vincent Lefevre
2023-03-20 9:19 ` Andreas Schwab
2023-03-20 10:42 ` Vincent Lefevre
2023-03-20 10:44 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230315123949.GC73312@zira.vinc17.org \
--to=vincent@vinc17.net \
--cc=eggert@cs.ucla.edu \
--cc=libc-alpha@sourceware.org \
--cc=simon.chopin@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).