From: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>
To: Andreas Schwab <schwab@linux-m68k.org>, libc-alpha@sourceware.org
Subject: Re: [PATCH] Remove pthread-pi-defines.sym
Date: Fri, 3 Feb 2023 13:20:49 -0300 [thread overview]
Message-ID: <22e884be-a0ad-c201-c31f-92b3e1fa13e4@linaro.org> (raw)
In-Reply-To: <87r0v63h0x.fsf@igel.home>
On 03/02/23 12:28, Andreas Schwab wrote:
> It became unused with the removal of the assembler implementation of the
> pthread functions.
LGTM, thanks.
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
> ---
> nptl/Makefile | 3 +--
> nptl/pthread-pi-defines.sym | 9 ---------
> 2 files changed, 1 insertion(+), 11 deletions(-)
> delete mode 100644 nptl/pthread-pi-defines.sym
>
> diff --git a/nptl/Makefile b/nptl/Makefile
> index 6d1ae452c8..8cec6faee3 100644
> --- a/nptl/Makefile
> +++ b/nptl/Makefile
> @@ -339,8 +339,7 @@ xtests += tst-eintr1
>
> test-srcs = tst-oddstacklimit
>
> -gen-as-const-headers = unwindbuf.sym \
> - pthread-pi-defines.sym
> +gen-as-const-headers = unwindbuf.sym
>
> gen-py-const-headers := nptl_lock_constants.pysym
> pretty-printers := nptl-printers.py
> diff --git a/nptl/pthread-pi-defines.sym b/nptl/pthread-pi-defines.sym
> deleted file mode 100644
> index 0ac51dba98..0000000000
> --- a/nptl/pthread-pi-defines.sym
> +++ /dev/null
> @@ -1,9 +0,0 @@
> -#include <pthreadP.h>
> -
> --- These PI macros are used by assembly code.
> -
> -MUTEX_KIND offsetof (pthread_mutex_t, __data.__kind)
> -ROBUST_BIT PTHREAD_MUTEX_ROBUST_NORMAL_NP
> -PI_BIT PTHREAD_MUTEX_PRIO_INHERIT_NP
> -PS_BIT PTHREAD_MUTEX_PSHARED_BIT
> -TID_MASK FUTEX_TID_MASK
prev parent reply other threads:[~2023-02-03 16:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-03 15:28 Andreas Schwab
2023-02-03 16:20 ` Adhemerval Zanella Netto [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22e884be-a0ad-c201-c31f-92b3e1fa13e4@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).