public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] Remove pthread-pi-defines.sym
@ 2023-02-03 15:28 Andreas Schwab
  2023-02-03 16:20 ` Adhemerval Zanella Netto
  0 siblings, 1 reply; 2+ messages in thread
From: Andreas Schwab @ 2023-02-03 15:28 UTC (permalink / raw)
  To: libc-alpha

It became unused with the removal of the assembler implementation of the
pthread functions.
---
 nptl/Makefile               | 3 +--
 nptl/pthread-pi-defines.sym | 9 ---------
 2 files changed, 1 insertion(+), 11 deletions(-)
 delete mode 100644 nptl/pthread-pi-defines.sym

diff --git a/nptl/Makefile b/nptl/Makefile
index 6d1ae452c8..8cec6faee3 100644
--- a/nptl/Makefile
+++ b/nptl/Makefile
@@ -339,8 +339,7 @@ xtests += tst-eintr1
 
 test-srcs = tst-oddstacklimit
 
-gen-as-const-headers = unwindbuf.sym \
-		       pthread-pi-defines.sym
+gen-as-const-headers = unwindbuf.sym
 
 gen-py-const-headers := nptl_lock_constants.pysym
 pretty-printers := nptl-printers.py
diff --git a/nptl/pthread-pi-defines.sym b/nptl/pthread-pi-defines.sym
deleted file mode 100644
index 0ac51dba98..0000000000
--- a/nptl/pthread-pi-defines.sym
+++ /dev/null
@@ -1,9 +0,0 @@
-#include <pthreadP.h>
-
--- These PI macros are used by assembly code.
-
-MUTEX_KIND	offsetof (pthread_mutex_t, __data.__kind)
-ROBUST_BIT	PTHREAD_MUTEX_ROBUST_NORMAL_NP
-PI_BIT		PTHREAD_MUTEX_PRIO_INHERIT_NP
-PS_BIT		PTHREAD_MUTEX_PSHARED_BIT
-TID_MASK	FUTEX_TID_MASK
-- 
2.39.1


-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Remove pthread-pi-defines.sym
  2023-02-03 15:28 [PATCH] Remove pthread-pi-defines.sym Andreas Schwab
@ 2023-02-03 16:20 ` Adhemerval Zanella Netto
  0 siblings, 0 replies; 2+ messages in thread
From: Adhemerval Zanella Netto @ 2023-02-03 16:20 UTC (permalink / raw)
  To: Andreas Schwab, libc-alpha



On 03/02/23 12:28, Andreas Schwab wrote:
> It became unused with the removal of the assembler implementation of the
> pthread functions.

LGTM, thanks.

Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>

> ---
>  nptl/Makefile               | 3 +--
>  nptl/pthread-pi-defines.sym | 9 ---------
>  2 files changed, 1 insertion(+), 11 deletions(-)
>  delete mode 100644 nptl/pthread-pi-defines.sym
> 
> diff --git a/nptl/Makefile b/nptl/Makefile
> index 6d1ae452c8..8cec6faee3 100644
> --- a/nptl/Makefile
> +++ b/nptl/Makefile
> @@ -339,8 +339,7 @@ xtests += tst-eintr1
>  
>  test-srcs = tst-oddstacklimit
>  
> -gen-as-const-headers = unwindbuf.sym \
> -		       pthread-pi-defines.sym
> +gen-as-const-headers = unwindbuf.sym
>  
>  gen-py-const-headers := nptl_lock_constants.pysym
>  pretty-printers := nptl-printers.py
> diff --git a/nptl/pthread-pi-defines.sym b/nptl/pthread-pi-defines.sym
> deleted file mode 100644
> index 0ac51dba98..0000000000
> --- a/nptl/pthread-pi-defines.sym
> +++ /dev/null
> @@ -1,9 +0,0 @@
> -#include <pthreadP.h>
> -
> --- These PI macros are used by assembly code.
> -
> -MUTEX_KIND	offsetof (pthread_mutex_t, __data.__kind)
> -ROBUST_BIT	PTHREAD_MUTEX_ROBUST_NORMAL_NP
> -PI_BIT		PTHREAD_MUTEX_PRIO_INHERIT_NP
> -PS_BIT		PTHREAD_MUTEX_PSHARED_BIT
> -TID_MASK	FUTEX_TID_MASK

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-02-03 16:20 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-03 15:28 [PATCH] Remove pthread-pi-defines.sym Andreas Schwab
2023-02-03 16:20 ` Adhemerval Zanella Netto

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).