From: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>
To: Xi Ruoyao <xry111@xry111.site>, libc-alpha@sourceware.org
Cc: caiyinyu <caiyinyu@loongson.cn>, Wang Xuerui <i@xen0n.name>
Subject: Re: [PATCH] LoongArch: Add math-barriers.h
Date: Wed, 15 Feb 2023 11:25:34 -0300 [thread overview]
Message-ID: <2bd6fce7-d77c-e034-934f-31f85afb9549@linaro.org> (raw)
In-Reply-To: <a75c8cc124e637bbc527e43abb9d964f22942814.camel@xry111.site>
On 15/02/23 11:22, Xi Ruoyao wrote:
> On Wed, 2023-02-15 at 10:47 -0300, Adhemerval Zanella Netto wrote:
>> On 14/02/23 05:57, Xi Ruoyao via Libc-alpha wrote:
>>> This patch implements the LoongArch specific math barriers in order to omit
>>> the store and load from stack if possible.
>>
>> LGTM, I have not see any regression with qemu. As a side note, math/test-fenv
>> shows a failure so you might take a look, you might need to update ULPs as well.
>
> Hmm, on a real hardware I saw no failures even with GCC 13 trunk (some
> aggressive FVRP optimization has been added into GCC 13). But maybe
> things have been changed since my last test. I'll test again.
I meant that I saw math/test-fenv failures with and without the patch
and I the master qemu (f670b3eec7f5d1ed8c4573ef244e7b8c6b32001b).
>
>> Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
>
next prev parent reply other threads:[~2023-02-15 14:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-14 8:57 Xi Ruoyao
2023-02-15 13:47 ` Adhemerval Zanella Netto
2023-02-15 14:22 ` Xi Ruoyao
2023-02-15 14:25 ` Adhemerval Zanella Netto [this message]
2023-02-16 13:02 ` Xi Ruoyao
2023-02-16 13:43 ` Adhemerval Zanella Netto
2023-02-27 10:45 ` Xi Ruoyao
2023-02-27 11:23 ` Adhemerval Zanella Netto
2023-02-27 11:25 ` WANG Xuerui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2bd6fce7-d77c-e034-934f-31f85afb9549@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=caiyinyu@loongson.cn \
--cc=i@xen0n.name \
--cc=libc-alpha@sourceware.org \
--cc=xry111@xry111.site \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).