public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Xi Ruoyao <xry111@xry111.site>
To: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>,
	 libc-alpha@sourceware.org
Cc: caiyinyu <caiyinyu@loongson.cn>, Wang Xuerui <i@xen0n.name>
Subject: Re: [PATCH] LoongArch: Add math-barriers.h
Date: Wed, 15 Feb 2023 22:22:27 +0800	[thread overview]
Message-ID: <a75c8cc124e637bbc527e43abb9d964f22942814.camel@xry111.site> (raw)
In-Reply-To: <617e860d-9bf3-ddc0-8791-655e611ad7ac@linaro.org>

On Wed, 2023-02-15 at 10:47 -0300, Adhemerval Zanella Netto wrote:
> On 14/02/23 05:57, Xi Ruoyao via Libc-alpha wrote:
> > This patch implements the LoongArch specific math barriers in order to omit
> > the store and load from stack if possible.
> 
> LGTM, I have not see any regression with qemu.  As a side note, math/test-fenv
> shows a failure so you might take a look, you might need to update ULPs as well.

Hmm, on a real hardware I saw no failures even with GCC 13 trunk (some
aggressive FVRP optimization has been added into GCC 13). But maybe
things have been changed since my last test.  I'll test again.

> Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>

-- 
Xi Ruoyao <xry111@xry111.site>
School of Aerospace Science and Technology, Xidian University

  reply	other threads:[~2023-02-15 14:22 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-14  8:57 Xi Ruoyao
2023-02-15 13:47 ` Adhemerval Zanella Netto
2023-02-15 14:22   ` Xi Ruoyao [this message]
2023-02-15 14:25     ` Adhemerval Zanella Netto
2023-02-16 13:02       ` Xi Ruoyao
2023-02-16 13:43         ` Adhemerval Zanella Netto
2023-02-27 10:45           ` Xi Ruoyao
2023-02-27 11:23             ` Adhemerval Zanella Netto
2023-02-27 11:25               ` WANG Xuerui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a75c8cc124e637bbc527e43abb9d964f22942814.camel@xry111.site \
    --to=xry111@xry111.site \
    --cc=adhemerval.zanella@linaro.org \
    --cc=caiyinyu@loongson.cn \
    --cc=i@xen0n.name \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).