From: Alejandro Colomar <alx.manpages@gmail.com>
To: Joseph Myers <joseph@codesourcery.com>
Cc: libc-alpha@sourceware.org, "Alejandro Colomar" <alx@kernel.org>,
linux-man@vger.kernel.org, "Bastien Roucariès" <rouca@debian.org>,
"Eric Blake" <eblake@redhat.com>,
"Zack Weinberg" <zack@owlfolio.org>,
"Stefan Puiu" <stefan.puiu@gmail.com>,
"Igor Sysoev" <igor@sysoev.ru>
Subject: Re: [PATCH v2] socket: Implement sockaddr_storage with an anonymous union
Date: Fri, 20 Jan 2023 20:26:18 +0100 [thread overview]
Message-ID: <304d8644-d007-e3cd-c1ed-d24b6aa2a88c@gmail.com> (raw)
In-Reply-To: <aa5ff22-b919-ce0-f16-f9857bbe1f7d@codesourcery.com>
[-- Attachment #1.1: Type: text/plain, Size: 975 bytes --]
Hi Joseph,
On 1/20/23 18:49, Joseph Myers wrote:
> On Fri, 20 Jan 2023, Alejandro Colomar via Libc-alpha wrote:
>
>> This patch fixes sockaddr_storage to remove UB on its uses and make it
>> that structure that everybody should be using. It also allows removing
>> many casts in code that needs to pass a sockaddr as a side effect.
>
> This patch only changes the fallback version of bits/socket.h that would
> be used by a new OS port that doesn't have its own, not either of the
> versions that any current glibc port actually uses
> (sysdeps/unix/sysv/linux/bits/socket.h and
> sysdeps/mach/hurd/bits/socket.h).
Hi Joseph!
Thanks; I didn't notice about those. It seems that patching those is not so
trivial, since bits/socket.h is included by the headers that provide the
specialized sockaddr_* types. I guess we need to move sockaddr_{in,in6,un} to
bits/ headers, right?
Cheers,
Alex
>
--
<http://www.alejandro-colomar.es/>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-01-20 19:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-20 13:40 Alejandro Colomar
2023-01-20 17:49 ` Joseph Myers
2023-01-20 19:26 ` Alejandro Colomar [this message]
2023-01-20 18:04 ` Zack Weinberg
2023-01-20 19:25 ` Alejandro Colomar
2023-01-21 2:38 ` Alejandro Colomar
2023-01-21 3:17 ` Alejandro Colomar
2023-01-21 13:30 ` Bastien Roucariès
2023-01-21 14:30 ` Alejandro Colomar
2023-01-22 14:12 ` Bastien Roucariès
2023-01-20 20:32 ` Bastien Roucariès
2023-01-20 20:38 ` Alejandro Colomar
2023-01-20 20:46 ` Bastien Roucariès
2023-01-20 20:51 ` Alejandro Colomar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=304d8644-d007-e3cd-c1ed-d24b6aa2a88c@gmail.com \
--to=alx.manpages@gmail.com \
--cc=alx@kernel.org \
--cc=eblake@redhat.com \
--cc=igor@sysoev.ru \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=linux-man@vger.kernel.org \
--cc=rouca@debian.org \
--cc=stefan.puiu@gmail.com \
--cc=zack@owlfolio.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).