Re: [PATCH] posix: Replace posix_spawnattr_tc{get,set}pgrp_np with posix_spawn_file_actions_addtcsetpgrp_np

[Adhemerval Zanella <adhemerval.zanella@linaro.org>]

On 29/01/2022 01:55, H.J. Lu wrote:
> On Thu, Jan 27, 2022 at 9:05 AM Adhemerval Zanella via Libc-alpha
> <libc-alpha@sourceware.org> wrote:
>>
>>
>>
>> On 27/01/2022 13:11, Florian Weimer wrote:
>>> * Adhemerval Zanella:
>>>
>>>> The posix_spawnattr_tcsetpgrp_np works on a file descriptor (the
>>>> controlling terminal), so it would make more sense to actually fit
>>>> it on the file actions API.
>>>>
>>>> Also, POSIX_SPAWN_TCSETPGROUP is not really required since it is
>>>> implicit by the presence of tcsetpgrp file action.
>>>>
>>>> The posix/tst-spawn6.c is also fixed when TTY can is not present.
> 
> I still got
> 
> [hjl@gnu-tgl-2 build-x86_64-linux]$ cat posix/tst-spawn6.out
> error: xopen.c:28: open64 ("/dev/tty", 0x0, 0600): No such device or address
> error: 1 test failures
> [hjl@gnu-tgl-2 build-x86_64-linux]$
> 
> It happened when I did
> 
> $ nohup make check&
> $ logout

That's because I am using the wrong errno value to check if the tty is
present (ENOENT).  I have changed to ENXIO.

> 
>>>> Checked on x86_64-linux-gnu and i686-linux-gnu.
>>>
>>> This has an ABI check failure on Hurd:
>>>
>>> --- ../sysdeps/mach/hurd/i386/libc.abilist      2022-01-27 10:04:20.120812828 -0500
>>> +++ /home/bmg/build/glibcs/i686-gnu/glibc/libc.symlist  2022-01-27 10:43:39.646804376 -0500
>>> @@ -2292,2 +2291,0 @@ GLIBC_2.35 posix_spawn_file_actions_addt
>>> -GLIBC_2.35 posix_spawnattr_tcgetpgrp_np F
>>> -GLIBC_2.35 posix_spawnattr_tcsetpgrp_np F
>>>
>>> The changes look okay to me.  A second review is probably warranted at
>>> this stage.
>>
>> Thanks.  It is really annoying that hurd make update-abi adds a bunch of files
>> and requires manual edit to get it right.
> 
> 
>