From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: Florian Weimer <fweimer@redhat.com>
Cc: libc-alpha@sourceware.org, Carlos O'Donell <carlos@redhat.com>
Subject: Re: [PATCH] posix: Replace posix_spawnattr_tc{get,set}pgrp_np with posix_spawn_file_actions_addtcsetpgrp_np
Date: Thu, 27 Jan 2022 14:04:28 -0300 [thread overview]
Message-ID: <6fc49d07-940d-a356-aebd-5b0de8c681f0@linaro.org> (raw)
In-Reply-To: <87h79pma45.fsf@oldenburg.str.redhat.com>
On 27/01/2022 13:11, Florian Weimer wrote:
> * Adhemerval Zanella:
>
>> The posix_spawnattr_tcsetpgrp_np works on a file descriptor (the
>> controlling terminal), so it would make more sense to actually fit
>> it on the file actions API.
>>
>> Also, POSIX_SPAWN_TCSETPGROUP is not really required since it is
>> implicit by the presence of tcsetpgrp file action.
>>
>> The posix/tst-spawn6.c is also fixed when TTY can is not present.
>>
>> Checked on x86_64-linux-gnu and i686-linux-gnu.
>
> This has an ABI check failure on Hurd:
>
> --- ../sysdeps/mach/hurd/i386/libc.abilist 2022-01-27 10:04:20.120812828 -0500
> +++ /home/bmg/build/glibcs/i686-gnu/glibc/libc.symlist 2022-01-27 10:43:39.646804376 -0500
> @@ -2292,2 +2291,0 @@ GLIBC_2.35 posix_spawn_file_actions_addt
> -GLIBC_2.35 posix_spawnattr_tcgetpgrp_np F
> -GLIBC_2.35 posix_spawnattr_tcsetpgrp_np F
>
> The changes look okay to me. A second review is probably warranted at
> this stage.
Thanks. It is really annoying that hurd make update-abi adds a bunch of files
and requires manual edit to get it right.
next prev parent reply other threads:[~2022-01-27 17:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-27 14:14 [PATCH] posix: Replace posix_spawnattr_tc{get, set}pgrp_np " Adhemerval Zanella
2022-01-27 16:11 ` [PATCH] posix: Replace posix_spawnattr_tc{get,set}pgrp_np " Florian Weimer
2022-01-27 17:04 ` Adhemerval Zanella [this message]
2022-01-27 17:15 ` Samuel Thibault
2022-01-27 18:09 ` Adhemerval Zanella
2022-01-27 18:10 ` Samuel Thibault
2022-01-27 18:12 ` Florian Weimer
2022-01-28 0:07 ` [hurd] update-abi (was: posix: Replace posix_spawnattr_tc{get,set}pgrp_np with posix_spawn_file_actions_addtcsetpgrp_np) Samuel Thibault
2022-03-01 12:42 ` [hurd] update-abi Florian Weimer
2022-03-06 19:28 ` Samuel Thibault
2022-01-29 4:55 ` [PATCH] posix: Replace posix_spawnattr_tc{get, set}pgrp_np with posix_spawn_file_actions_addtcsetpgrp_np H.J. Lu
2022-01-29 19:59 ` [PATCH] posix: Replace posix_spawnattr_tc{get,set}pgrp_np " Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6fc49d07-940d-a356-aebd-5b0de8c681f0@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=carlos@redhat.com \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).