From: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>
To: Xi Ruoyao <xry111@xry111.site>, libc-alpha@sourceware.org
Cc: caiyinyu <caiyinyu@loongson.cn>,
Joseph Myers <joseph@codesourcery.com>,
Wang Xuerui <i.swmail@xen0n.name>
Subject: Re: [PATCH] LoongArch: Use __builtin_{fmax,fmaxf,fmin,fminf} with GCC >= 13
Date: Mon, 29 Aug 2022 09:44:08 -0300 [thread overview]
Message-ID: <532ed62c-8510-c351-9cf2-342771a09a94@linaro.org> (raw)
In-Reply-To: <9146983bcb2dc77fea7ab361f96005b1ce6dc698.camel@xry111.site>
On 20/08/22 05:43, Xi Ruoyao wrote:
> GCC 13 compiles these built-ins to {fmax,fmin}.{s/d} instruction, use
> them instead of the generic implementation.
>
> Link: https://gcc.gnu.org/r13-2085
> Signed-off-by: Xi Ruoyao <xry111@xry111.site>
LGTM, thanks.
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
> ---
> sysdeps/loongarch/fpu/math-use-builtins-fmax.h | 10 ++++++++++
> sysdeps/loongarch/fpu/math-use-builtins-fmin.h | 10 ++++++++++
> 2 files changed, 20 insertions(+)
> create mode 100644 sysdeps/loongarch/fpu/math-use-builtins-fmax.h
> create mode 100644 sysdeps/loongarch/fpu/math-use-builtins-fmin.h
>
> diff --git a/sysdeps/loongarch/fpu/math-use-builtins-fmax.h b/sysdeps/loongarch/fpu/math-use-builtins-fmax.h
> new file mode 100644
> index 0000000000..5d22567bd3
> --- /dev/null
> +++ b/sysdeps/loongarch/fpu/math-use-builtins-fmax.h
> @@ -0,0 +1,10 @@
> +#if __GNUC_PREREQ (13, 0)
> +# define USE_FMAX_BUILTIN 1
> +# define USE_FMAXF_BUILTIN 1
> +#else
> +# define USE_FMAX_BUILTIN 0
> +# define USE_FMAXF_BUILTIN 0
> +#endif
> +
> +#define USE_FMAXL_BUILTIN 0
> +#define USE_FMAXF128_BUILTIN 0
> diff --git a/sysdeps/loongarch/fpu/math-use-builtins-fmin.h b/sysdeps/loongarch/fpu/math-use-builtins-fmin.h
> new file mode 100644
> index 0000000000..4d28b41c0d
> --- /dev/null
> +++ b/sysdeps/loongarch/fpu/math-use-builtins-fmin.h
> @@ -0,0 +1,10 @@
> +#if __GNUC_PREREQ (13, 0)
> +# define USE_FMIN_BUILTIN 1
> +# define USE_FMINF_BUILTIN 1
> +#else
> +# define USE_FMIN_BUILTIN 0
> +# define USE_FMINF_BUILTIN 0
> +#endif
> +
> +#define USE_FMINL_BUILTIN 0
> +#define USE_FMINF128_BUILTIN 0
WARNING: multiple messages have this Message-ID
From: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>
To: Xi Ruoyao <xry111@xry111.site>, libc-alpha@sourceware.org
Cc: caiyinyu <caiyinyu@loongson.cn>,
Joseph Myers <joseph@codesourcery.com>,
Wang Xuerui <i.swmail@xen0n.name>
Subject: Re: [PATCH] LoongArch: Use __builtin_{fmax, fmaxf, fmin, fminf} with GCC >= 13
Date: Mon, 29 Aug 2022 09:44:08 -0300 [thread overview]
Message-ID: <532ed62c-8510-c351-9cf2-342771a09a94@linaro.org> (raw)
Message-ID: <20220829124408.BihWS4pFsLWGvH7AAeBwCJcsfgp7eYkjYoLoSyZwTRs@z> (raw)
In-Reply-To: <9146983bcb2dc77fea7ab361f96005b1ce6dc698.camel@xry111.site>
On 20/08/22 05:43, Xi Ruoyao wrote:
> GCC 13 compiles these built-ins to {fmax,fmin}.{s/d} instruction, use
> them instead of the generic implementation.
>
> Link: https://gcc.gnu.org/r13-2085
> Signed-off-by: Xi Ruoyao <xry111@xry111.site>
LGTM, thanks.
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
> ---
> sysdeps/loongarch/fpu/math-use-builtins-fmax.h | 10 ++++++++++
> sysdeps/loongarch/fpu/math-use-builtins-fmin.h | 10 ++++++++++
> 2 files changed, 20 insertions(+)
> create mode 100644 sysdeps/loongarch/fpu/math-use-builtins-fmax.h
> create mode 100644 sysdeps/loongarch/fpu/math-use-builtins-fmin.h
>
> diff --git a/sysdeps/loongarch/fpu/math-use-builtins-fmax.h b/sysdeps/loongarch/fpu/math-use-builtins-fmax.h
> new file mode 100644
> index 0000000000..5d22567bd3
> --- /dev/null
> +++ b/sysdeps/loongarch/fpu/math-use-builtins-fmax.h
> @@ -0,0 +1,10 @@
> +#if __GNUC_PREREQ (13, 0)
> +# define USE_FMAX_BUILTIN 1
> +# define USE_FMAXF_BUILTIN 1
> +#else
> +# define USE_FMAX_BUILTIN 0
> +# define USE_FMAXF_BUILTIN 0
> +#endif
> +
> +#define USE_FMAXL_BUILTIN 0
> +#define USE_FMAXF128_BUILTIN 0
> diff --git a/sysdeps/loongarch/fpu/math-use-builtins-fmin.h b/sysdeps/loongarch/fpu/math-use-builtins-fmin.h
> new file mode 100644
> index 0000000000..4d28b41c0d
> --- /dev/null
> +++ b/sysdeps/loongarch/fpu/math-use-builtins-fmin.h
> @@ -0,0 +1,10 @@
> +#if __GNUC_PREREQ (13, 0)
> +# define USE_FMIN_BUILTIN 1
> +# define USE_FMINF_BUILTIN 1
> +#else
> +# define USE_FMIN_BUILTIN 0
> +# define USE_FMINF_BUILTIN 0
> +#endif
> +
> +#define USE_FMINL_BUILTIN 0
> +#define USE_FMINF128_BUILTIN 0
next prev parent reply other threads:[~2022-08-29 12:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-20 8:43 Xi Ruoyao
2022-08-29 7:11 ` Ping: " Xi Ruoyao
2022-08-29 12:44 ` Adhemerval Zanella Netto [this message]
2022-08-29 12:44 ` [PATCH] LoongArch: Use __builtin_{fmax, fmaxf, fmin, fminf} " Adhemerval Zanella Netto
2022-08-30 5:31 ` [PATCH] LoongArch: Use __builtin_{fmax,fmaxf,fmin,fminf} " Xi Ruoyao
2022-08-30 6:23 ` caiyinyu
2022-08-30 6:23 ` [PATCH] LoongArch: Use __builtin_{fmax, fmaxf, fmin, fminf} " caiyinyu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=532ed62c-8510-c351-9cf2-342771a09a94@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=caiyinyu@loongson.cn \
--cc=i.swmail@xen0n.name \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=xry111@xry111.site \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).