* [PATCH] LoongArch: Use __builtin_{fmax,fmaxf,fmin,fminf} with GCC >= 13
@ 2022-08-20 8:43 Xi Ruoyao
2022-08-29 7:11 ` Ping: " Xi Ruoyao
2022-08-29 12:44 ` Adhemerval Zanella Netto
0 siblings, 2 replies; 7+ messages in thread
From: Xi Ruoyao @ 2022-08-20 8:43 UTC (permalink / raw)
To: libc-alpha; +Cc: caiyinyu, Adhemerval Zanella Netto, Joseph Myers, Wang Xuerui
GCC 13 compiles these built-ins to {fmax,fmin}.{s/d} instruction, use
them instead of the generic implementation.
Link: https://gcc.gnu.org/r13-2085
Signed-off-by: Xi Ruoyao <xry111@xry111.site>
---
sysdeps/loongarch/fpu/math-use-builtins-fmax.h | 10 ++++++++++
sysdeps/loongarch/fpu/math-use-builtins-fmin.h | 10 ++++++++++
2 files changed, 20 insertions(+)
create mode 100644 sysdeps/loongarch/fpu/math-use-builtins-fmax.h
create mode 100644 sysdeps/loongarch/fpu/math-use-builtins-fmin.h
diff --git a/sysdeps/loongarch/fpu/math-use-builtins-fmax.h b/sysdeps/loongarch/fpu/math-use-builtins-fmax.h
new file mode 100644
index 0000000000..5d22567bd3
--- /dev/null
+++ b/sysdeps/loongarch/fpu/math-use-builtins-fmax.h
@@ -0,0 +1,10 @@
+#if __GNUC_PREREQ (13, 0)
+# define USE_FMAX_BUILTIN 1
+# define USE_FMAXF_BUILTIN 1
+#else
+# define USE_FMAX_BUILTIN 0
+# define USE_FMAXF_BUILTIN 0
+#endif
+
+#define USE_FMAXL_BUILTIN 0
+#define USE_FMAXF128_BUILTIN 0
diff --git a/sysdeps/loongarch/fpu/math-use-builtins-fmin.h b/sysdeps/loongarch/fpu/math-use-builtins-fmin.h
new file mode 100644
index 0000000000..4d28b41c0d
--- /dev/null
+++ b/sysdeps/loongarch/fpu/math-use-builtins-fmin.h
@@ -0,0 +1,10 @@
+#if __GNUC_PREREQ (13, 0)
+# define USE_FMIN_BUILTIN 1
+# define USE_FMINF_BUILTIN 1
+#else
+# define USE_FMIN_BUILTIN 0
+# define USE_FMINF_BUILTIN 0
+#endif
+
+#define USE_FMINL_BUILTIN 0
+#define USE_FMINF128_BUILTIN 0
--
2.37.0
^ permalink raw reply [flat|nested] 7+ messages in thread* Ping: [PATCH] LoongArch: Use __builtin_{fmax,fmaxf,fmin,fminf} with GCC >= 13
2022-08-20 8:43 [PATCH] LoongArch: Use __builtin_{fmax,fmaxf,fmin,fminf} with GCC >= 13 Xi Ruoyao
@ 2022-08-29 7:11 ` Xi Ruoyao
2022-08-29 12:44 ` Adhemerval Zanella Netto
1 sibling, 0 replies; 7+ messages in thread
From: Xi Ruoyao @ 2022-08-29 7:11 UTC (permalink / raw)
To: libc-alpha; +Cc: caiyinyu, Adhemerval Zanella Netto, Joseph Myers, Wang Xuerui
Gentle ping :)
On Sat, 2022-08-20 at 16:43 +0800, Xi Ruoyao wrote:
> GCC 13 compiles these built-ins to {fmax,fmin}.{s/d} instruction, use
> them instead of the generic implementation.
>
> Link: https://gcc.gnu.org/r13-2085
> Signed-off-by: Xi Ruoyao <xry111@xry111.site>
> ---
> sysdeps/loongarch/fpu/math-use-builtins-fmax.h | 10 ++++++++++
> sysdeps/loongarch/fpu/math-use-builtins-fmin.h | 10 ++++++++++
> 2 files changed, 20 insertions(+)
> create mode 100644 sysdeps/loongarch/fpu/math-use-builtins-fmax.h
> create mode 100644 sysdeps/loongarch/fpu/math-use-builtins-fmin.h
>
> diff --git a/sysdeps/loongarch/fpu/math-use-builtins-fmax.h
> b/sysdeps/loongarch/fpu/math-use-builtins-fmax.h
> new file mode 100644
> index 0000000000..5d22567bd3
> --- /dev/null
> +++ b/sysdeps/loongarch/fpu/math-use-builtins-fmax.h
> @@ -0,0 +1,10 @@
> +#if __GNUC_PREREQ (13, 0)
> +# define USE_FMAX_BUILTIN 1
> +# define USE_FMAXF_BUILTIN 1
> +#else
> +# define USE_FMAX_BUILTIN 0
> +# define USE_FMAXF_BUILTIN 0
> +#endif
> +
> +#define USE_FMAXL_BUILTIN 0
> +#define USE_FMAXF128_BUILTIN 0
> diff --git a/sysdeps/loongarch/fpu/math-use-builtins-fmin.h
> b/sysdeps/loongarch/fpu/math-use-builtins-fmin.h
> new file mode 100644
> index 0000000000..4d28b41c0d
> --- /dev/null
> +++ b/sysdeps/loongarch/fpu/math-use-builtins-fmin.h
> @@ -0,0 +1,10 @@
> +#if __GNUC_PREREQ (13, 0)
> +# define USE_FMIN_BUILTIN 1
> +# define USE_FMINF_BUILTIN 1
> +#else
> +# define USE_FMIN_BUILTIN 0
> +# define USE_FMINF_BUILTIN 0
> +#endif
> +
> +#define USE_FMINL_BUILTIN 0
> +#define USE_FMINF128_BUILTIN 0
--
Xi Ruoyao <xry111@xry111.site>
School of Aerospace Science and Technology, Xidian University
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] LoongArch: Use __builtin_{fmax,fmaxf,fmin,fminf} with GCC >= 13
2022-08-20 8:43 [PATCH] LoongArch: Use __builtin_{fmax,fmaxf,fmin,fminf} with GCC >= 13 Xi Ruoyao
2022-08-29 7:11 ` Ping: " Xi Ruoyao
@ 2022-08-29 12:44 ` Adhemerval Zanella Netto
2022-08-29 12:44 ` [PATCH] LoongArch: Use __builtin_{fmax, fmaxf, fmin, fminf} " Adhemerval Zanella Netto
2022-08-30 5:31 ` [PATCH] LoongArch: Use __builtin_{fmax,fmaxf,fmin,fminf} " Xi Ruoyao
1 sibling, 2 replies; 7+ messages in thread
From: Adhemerval Zanella Netto @ 2022-08-29 12:44 UTC (permalink / raw)
To: Xi Ruoyao, libc-alpha; +Cc: caiyinyu, Joseph Myers, Wang Xuerui
On 20/08/22 05:43, Xi Ruoyao wrote:
> GCC 13 compiles these built-ins to {fmax,fmin}.{s/d} instruction, use
> them instead of the generic implementation.
>
> Link: https://gcc.gnu.org/r13-2085
> Signed-off-by: Xi Ruoyao <xry111@xry111.site>
LGTM, thanks.
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
> ---
> sysdeps/loongarch/fpu/math-use-builtins-fmax.h | 10 ++++++++++
> sysdeps/loongarch/fpu/math-use-builtins-fmin.h | 10 ++++++++++
> 2 files changed, 20 insertions(+)
> create mode 100644 sysdeps/loongarch/fpu/math-use-builtins-fmax.h
> create mode 100644 sysdeps/loongarch/fpu/math-use-builtins-fmin.h
>
> diff --git a/sysdeps/loongarch/fpu/math-use-builtins-fmax.h b/sysdeps/loongarch/fpu/math-use-builtins-fmax.h
> new file mode 100644
> index 0000000000..5d22567bd3
> --- /dev/null
> +++ b/sysdeps/loongarch/fpu/math-use-builtins-fmax.h
> @@ -0,0 +1,10 @@
> +#if __GNUC_PREREQ (13, 0)
> +# define USE_FMAX_BUILTIN 1
> +# define USE_FMAXF_BUILTIN 1
> +#else
> +# define USE_FMAX_BUILTIN 0
> +# define USE_FMAXF_BUILTIN 0
> +#endif
> +
> +#define USE_FMAXL_BUILTIN 0
> +#define USE_FMAXF128_BUILTIN 0
> diff --git a/sysdeps/loongarch/fpu/math-use-builtins-fmin.h b/sysdeps/loongarch/fpu/math-use-builtins-fmin.h
> new file mode 100644
> index 0000000000..4d28b41c0d
> --- /dev/null
> +++ b/sysdeps/loongarch/fpu/math-use-builtins-fmin.h
> @@ -0,0 +1,10 @@
> +#if __GNUC_PREREQ (13, 0)
> +# define USE_FMIN_BUILTIN 1
> +# define USE_FMINF_BUILTIN 1
> +#else
> +# define USE_FMIN_BUILTIN 0
> +# define USE_FMINF_BUILTIN 0
> +#endif
> +
> +#define USE_FMINL_BUILTIN 0
> +#define USE_FMINF128_BUILTIN 0
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] LoongArch: Use __builtin_{fmax, fmaxf, fmin, fminf} with GCC >= 13
2022-08-29 12:44 ` Adhemerval Zanella Netto
@ 2022-08-29 12:44 ` Adhemerval Zanella Netto
2022-08-30 5:31 ` [PATCH] LoongArch: Use __builtin_{fmax,fmaxf,fmin,fminf} " Xi Ruoyao
1 sibling, 0 replies; 7+ messages in thread
From: Adhemerval Zanella Netto @ 2022-08-29 12:44 UTC (permalink / raw)
To: Xi Ruoyao, libc-alpha; +Cc: caiyinyu, Joseph Myers, Wang Xuerui
On 20/08/22 05:43, Xi Ruoyao wrote:
> GCC 13 compiles these built-ins to {fmax,fmin}.{s/d} instruction, use
> them instead of the generic implementation.
>
> Link: https://gcc.gnu.org/r13-2085
> Signed-off-by: Xi Ruoyao <xry111@xry111.site>
LGTM, thanks.
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
> ---
> sysdeps/loongarch/fpu/math-use-builtins-fmax.h | 10 ++++++++++
> sysdeps/loongarch/fpu/math-use-builtins-fmin.h | 10 ++++++++++
> 2 files changed, 20 insertions(+)
> create mode 100644 sysdeps/loongarch/fpu/math-use-builtins-fmax.h
> create mode 100644 sysdeps/loongarch/fpu/math-use-builtins-fmin.h
>
> diff --git a/sysdeps/loongarch/fpu/math-use-builtins-fmax.h b/sysdeps/loongarch/fpu/math-use-builtins-fmax.h
> new file mode 100644
> index 0000000000..5d22567bd3
> --- /dev/null
> +++ b/sysdeps/loongarch/fpu/math-use-builtins-fmax.h
> @@ -0,0 +1,10 @@
> +#if __GNUC_PREREQ (13, 0)
> +# define USE_FMAX_BUILTIN 1
> +# define USE_FMAXF_BUILTIN 1
> +#else
> +# define USE_FMAX_BUILTIN 0
> +# define USE_FMAXF_BUILTIN 0
> +#endif
> +
> +#define USE_FMAXL_BUILTIN 0
> +#define USE_FMAXF128_BUILTIN 0
> diff --git a/sysdeps/loongarch/fpu/math-use-builtins-fmin.h b/sysdeps/loongarch/fpu/math-use-builtins-fmin.h
> new file mode 100644
> index 0000000000..4d28b41c0d
> --- /dev/null
> +++ b/sysdeps/loongarch/fpu/math-use-builtins-fmin.h
> @@ -0,0 +1,10 @@
> +#if __GNUC_PREREQ (13, 0)
> +# define USE_FMIN_BUILTIN 1
> +# define USE_FMINF_BUILTIN 1
> +#else
> +# define USE_FMIN_BUILTIN 0
> +# define USE_FMINF_BUILTIN 0
> +#endif
> +
> +#define USE_FMINL_BUILTIN 0
> +#define USE_FMINF128_BUILTIN 0
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] LoongArch: Use __builtin_{fmax,fmaxf,fmin,fminf} with GCC >= 13
2022-08-29 12:44 ` Adhemerval Zanella Netto
2022-08-29 12:44 ` [PATCH] LoongArch: Use __builtin_{fmax, fmaxf, fmin, fminf} " Adhemerval Zanella Netto
@ 2022-08-30 5:31 ` Xi Ruoyao
2022-08-30 6:23 ` caiyinyu
1 sibling, 1 reply; 7+ messages in thread
From: Xi Ruoyao @ 2022-08-30 5:31 UTC (permalink / raw)
To: Adhemerval Zanella Netto, libc-alpha; +Cc: caiyinyu, Joseph Myers, Wang Xuerui
On Mon, 2022-08-29 at 09:44 -0300, Adhemerval Zanella Netto wrote:
>
>
> On 20/08/22 05:43, Xi Ruoyao wrote:
> > GCC 13 compiles these built-ins to {fmax,fmin}.{s/d} instruction, use
> > them instead of the generic implementation.
> >
> > Link: https://gcc.gnu.org/r13-2085
> > Signed-off-by: Xi Ruoyao <xry111@xry111.site>
>
> LGTM, thanks.
>
> Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Thanks, I don't have a write access to glibc.git and need others' help
to push the patch :).
--
Xi Ruoyao <xry111@xry111.site>
School of Aerospace Science and Technology, Xidian University
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] LoongArch: Use __builtin_{fmax,fmaxf,fmin,fminf} with GCC >= 13
2022-08-30 5:31 ` [PATCH] LoongArch: Use __builtin_{fmax,fmaxf,fmin,fminf} " Xi Ruoyao
@ 2022-08-30 6:23 ` caiyinyu
2022-08-30 6:23 ` [PATCH] LoongArch: Use __builtin_{fmax, fmaxf, fmin, fminf} " caiyinyu
0 siblings, 1 reply; 7+ messages in thread
From: caiyinyu @ 2022-08-30 6:23 UTC (permalink / raw)
To: Xi Ruoyao, Adhemerval Zanella Netto, libc-alpha; +Cc: Joseph Myers, Wang Xuerui
I have tested it and pushed.
在 2022/8/30 下午1:31, Xi Ruoyao 写道:
> On Mon, 2022-08-29 at 09:44 -0300, Adhemerval Zanella Netto wrote:
>>
>> On 20/08/22 05:43, Xi Ruoyao wrote:
>>> GCC 13 compiles these built-ins to {fmax,fmin}.{s/d} instruction, use
>>> them instead of the generic implementation.
>>>
>>> Link: https://gcc.gnu.org/r13-2085
>>> Signed-off-by: Xi Ruoyao <xry111@xry111.site>
>> LGTM, thanks.
>>
>> Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
> Thanks, I don't have a write access to glibc.git and need others' help
> to push the patch :).
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] LoongArch: Use __builtin_{fmax, fmaxf, fmin, fminf} with GCC >= 13
2022-08-30 6:23 ` caiyinyu
@ 2022-08-30 6:23 ` caiyinyu
0 siblings, 0 replies; 7+ messages in thread
From: caiyinyu @ 2022-08-30 6:23 UTC (permalink / raw)
To: Xi Ruoyao, Adhemerval Zanella Netto, libc-alpha; +Cc: Joseph Myers, Wang Xuerui
I have tested it and pushed.
在 2022/8/30 下午1:31, Xi Ruoyao 写道:
> On Mon, 2022-08-29 at 09:44 -0300, Adhemerval Zanella Netto wrote:
>>
>> On 20/08/22 05:43, Xi Ruoyao wrote:
>>> GCC 13 compiles these built-ins to {fmax,fmin}.{s/d} instruction, use
>>> them instead of the generic implementation.
>>>
>>> Link: https://gcc.gnu.org/r13-2085
>>> Signed-off-by: Xi Ruoyao <xry111@xry111.site>
>> LGTM, thanks.
>>
>> Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
> Thanks, I don't have a write access to glibc.git and need others' help
> to push the patch :).
>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-08-30 6:23 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-20 8:43 [PATCH] LoongArch: Use __builtin_{fmax,fmaxf,fmin,fminf} with GCC >= 13 Xi Ruoyao
2022-08-29 7:11 ` Ping: " Xi Ruoyao
2022-08-29 12:44 ` Adhemerval Zanella Netto
2022-08-29 12:44 ` [PATCH] LoongArch: Use __builtin_{fmax, fmaxf, fmin, fminf} " Adhemerval Zanella Netto
2022-08-30 5:31 ` [PATCH] LoongArch: Use __builtin_{fmax,fmaxf,fmin,fminf} " Xi Ruoyao
2022-08-30 6:23 ` caiyinyu
2022-08-30 6:23 ` [PATCH] LoongArch: Use __builtin_{fmax, fmaxf, fmin, fminf} " caiyinyu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).