From: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>
To: Andreas Schwab <schwab@suse.de>, libc-alpha@sourceware.org
Subject: Re: [PATCH] Remove last remnants of have-protected
Date: Thu, 18 May 2023 09:37:26 -0300 [thread overview]
Message-ID: <5697b425-a56e-9e12-08fd-ad48ded9c0f1@linaro.org> (raw)
In-Reply-To: <mvmwn1izzsp.fsf@suse.de>
LGTM, thanks.
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
On 08/05/23 11:02, Andreas Schwab via Libc-alpha wrote:
> ---
> sysdeps/hppa/Makefile | 3 ---
> sysdeps/powerpc/powerpc32/Makefile | 3 ---
> sysdeps/powerpc/powerpc32/libgcc-compat.S | 4 +---
> 3 files changed, 1 insertion(+), 9 deletions(-)
>
> diff --git a/sysdeps/hppa/Makefile b/sysdeps/hppa/Makefile
> index 9531504c4b..b7765c31ec 100644
> --- a/sysdeps/hppa/Makefile
> +++ b/sysdeps/hppa/Makefile
> @@ -30,9 +30,6 @@ endif
> ifeq ($(subdir),csu)
> ifeq (yes,$(build-shared))
> # Compatibility
> -ifeq (yes,$(have-protected))
> -CPPFLAGS-libgcc-compat.c = -DHAVE_DOT_HIDDEN
> -endif
> sysdep_routines += libgcc-compat
> shared-only-routines += libgcc-compat
> endif
> diff --git a/sysdeps/powerpc/powerpc32/Makefile b/sysdeps/powerpc/powerpc32/Makefile
> index cf620c8269..1fff5b83bf 100644
> --- a/sysdeps/powerpc/powerpc32/Makefile
> +++ b/sysdeps/powerpc/powerpc32/Makefile
> @@ -35,9 +35,6 @@ CFLAGS-gmon-start.o = -G0
>
> ifeq (yes,$(build-shared))
> # Compatibility
> -ifeq (yes,$(have-protected))
> -CPPFLAGS-libgcc-compat.S = -DHAVE_DOT_HIDDEN
> -endif
> sysdep_routines += libgcc-compat
> shared-only-routines += libgcc-compat
> endif
> diff --git a/sysdeps/powerpc/powerpc32/libgcc-compat.S b/sysdeps/powerpc/powerpc32/libgcc-compat.S
> index ffa8f0a44a..6beac24039 100644
> --- a/sysdeps/powerpc/powerpc32/libgcc-compat.S
> +++ b/sysdeps/powerpc/powerpc32/libgcc-compat.S
> @@ -36,20 +36,18 @@
> .symver __floatdisf_v_glibc20,__floatdisf@GLIBC_2.0
> #endif
>
> -#ifdef HAVE_DOT_HIDDEN
> .hidden __ashldi3
> .hidden __ashrdi3
> .hidden __lshrdi3
> .hidden __cmpdi2
> .hidden __ucmpdi2
> -# if !defined _SOFT_FLOAT && !defined __NO_FPRS__
> +#if !defined _SOFT_FLOAT && !defined __NO_FPRS__
> .hidden __fixdfdi
> .hidden __fixsfdi
> .hidden __fixunsdfdi
> .hidden __fixunssfdi
> .hidden __floatdidf
> .hidden __floatdisf
> -# endif
> #endif
>
> .section ".text"
prev parent reply other threads:[~2023-05-18 12:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-08 14:02 Andreas Schwab
2023-05-18 12:37 ` Adhemerval Zanella Netto [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5697b425-a56e-9e12-08fd-ad48ded9c0f1@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).