public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] Remove last remnants of have-protected
@ 2023-05-08 14:02 Andreas Schwab
  2023-05-18 12:37 ` Adhemerval Zanella Netto
  0 siblings, 1 reply; 2+ messages in thread
From: Andreas Schwab @ 2023-05-08 14:02 UTC (permalink / raw)
  To: libc-alpha

---
 sysdeps/hppa/Makefile                     | 3 ---
 sysdeps/powerpc/powerpc32/Makefile        | 3 ---
 sysdeps/powerpc/powerpc32/libgcc-compat.S | 4 +---
 3 files changed, 1 insertion(+), 9 deletions(-)

diff --git a/sysdeps/hppa/Makefile b/sysdeps/hppa/Makefile
index 9531504c4b..b7765c31ec 100644
--- a/sysdeps/hppa/Makefile
+++ b/sysdeps/hppa/Makefile
@@ -30,9 +30,6 @@ endif
 ifeq ($(subdir),csu)
 ifeq (yes,$(build-shared))
 # Compatibility
-ifeq (yes,$(have-protected))
-CPPFLAGS-libgcc-compat.c = -DHAVE_DOT_HIDDEN
-endif
 sysdep_routines += libgcc-compat
 shared-only-routines += libgcc-compat
 endif
diff --git a/sysdeps/powerpc/powerpc32/Makefile b/sysdeps/powerpc/powerpc32/Makefile
index cf620c8269..1fff5b83bf 100644
--- a/sysdeps/powerpc/powerpc32/Makefile
+++ b/sysdeps/powerpc/powerpc32/Makefile
@@ -35,9 +35,6 @@ CFLAGS-gmon-start.o = -G0
 
 ifeq (yes,$(build-shared))
 # Compatibility
-ifeq (yes,$(have-protected))
-CPPFLAGS-libgcc-compat.S = -DHAVE_DOT_HIDDEN
-endif
 sysdep_routines += libgcc-compat
 shared-only-routines += libgcc-compat
 endif
diff --git a/sysdeps/powerpc/powerpc32/libgcc-compat.S b/sysdeps/powerpc/powerpc32/libgcc-compat.S
index ffa8f0a44a..6beac24039 100644
--- a/sysdeps/powerpc/powerpc32/libgcc-compat.S
+++ b/sysdeps/powerpc/powerpc32/libgcc-compat.S
@@ -36,20 +36,18 @@
 	.symver __floatdisf_v_glibc20,__floatdisf@GLIBC_2.0
 #endif
 
-#ifdef HAVE_DOT_HIDDEN
 	.hidden __ashldi3
 	.hidden __ashrdi3
 	.hidden __lshrdi3
 	.hidden __cmpdi2
 	.hidden __ucmpdi2
-# if !defined _SOFT_FLOAT && !defined __NO_FPRS__
+#if !defined _SOFT_FLOAT && !defined __NO_FPRS__
 	.hidden __fixdfdi
 	.hidden __fixsfdi
 	.hidden __fixunsdfdi
 	.hidden __fixunssfdi
 	.hidden __floatdidf
 	.hidden __floatdisf
-# endif
 #endif
 
 	.section	".text"
-- 
2.40.1


-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Remove last remnants of have-protected
  2023-05-08 14:02 [PATCH] Remove last remnants of have-protected Andreas Schwab
@ 2023-05-18 12:37 ` Adhemerval Zanella Netto
  0 siblings, 0 replies; 2+ messages in thread
From: Adhemerval Zanella Netto @ 2023-05-18 12:37 UTC (permalink / raw)
  To: Andreas Schwab, libc-alpha

LGTM, thanks.

Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>

On 08/05/23 11:02, Andreas Schwab via Libc-alpha wrote:
> ---
>  sysdeps/hppa/Makefile                     | 3 ---
>  sysdeps/powerpc/powerpc32/Makefile        | 3 ---
>  sysdeps/powerpc/powerpc32/libgcc-compat.S | 4 +---
>  3 files changed, 1 insertion(+), 9 deletions(-)
> 
> diff --git a/sysdeps/hppa/Makefile b/sysdeps/hppa/Makefile
> index 9531504c4b..b7765c31ec 100644
> --- a/sysdeps/hppa/Makefile
> +++ b/sysdeps/hppa/Makefile
> @@ -30,9 +30,6 @@ endif
>  ifeq ($(subdir),csu)
>  ifeq (yes,$(build-shared))
>  # Compatibility
> -ifeq (yes,$(have-protected))
> -CPPFLAGS-libgcc-compat.c = -DHAVE_DOT_HIDDEN
> -endif
>  sysdep_routines += libgcc-compat
>  shared-only-routines += libgcc-compat
>  endif
> diff --git a/sysdeps/powerpc/powerpc32/Makefile b/sysdeps/powerpc/powerpc32/Makefile
> index cf620c8269..1fff5b83bf 100644
> --- a/sysdeps/powerpc/powerpc32/Makefile
> +++ b/sysdeps/powerpc/powerpc32/Makefile
> @@ -35,9 +35,6 @@ CFLAGS-gmon-start.o = -G0
>  
>  ifeq (yes,$(build-shared))
>  # Compatibility
> -ifeq (yes,$(have-protected))
> -CPPFLAGS-libgcc-compat.S = -DHAVE_DOT_HIDDEN
> -endif
>  sysdep_routines += libgcc-compat
>  shared-only-routines += libgcc-compat
>  endif
> diff --git a/sysdeps/powerpc/powerpc32/libgcc-compat.S b/sysdeps/powerpc/powerpc32/libgcc-compat.S
> index ffa8f0a44a..6beac24039 100644
> --- a/sysdeps/powerpc/powerpc32/libgcc-compat.S
> +++ b/sysdeps/powerpc/powerpc32/libgcc-compat.S
> @@ -36,20 +36,18 @@
>  	.symver __floatdisf_v_glibc20,__floatdisf@GLIBC_2.0
>  #endif
>  
> -#ifdef HAVE_DOT_HIDDEN
>  	.hidden __ashldi3
>  	.hidden __ashrdi3
>  	.hidden __lshrdi3
>  	.hidden __cmpdi2
>  	.hidden __ucmpdi2
> -# if !defined _SOFT_FLOAT && !defined __NO_FPRS__
> +#if !defined _SOFT_FLOAT && !defined __NO_FPRS__
>  	.hidden __fixdfdi
>  	.hidden __fixsfdi
>  	.hidden __fixunsdfdi
>  	.hidden __fixunssfdi
>  	.hidden __floatdidf
>  	.hidden __floatdisf
> -# endif
>  #endif
>  
>  	.section	".text"

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-05-18 12:37 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-08 14:02 [PATCH] Remove last remnants of have-protected Andreas Schwab
2023-05-18 12:37 ` Adhemerval Zanella Netto

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).