From: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>
To: libc-alpha@sourceware.org, Florian Weimer <fweimer@redhat.com>
Subject: Re: [PATCH] elf.h: Remove duplicate definition of VER_FLG_WEAK
Date: Thu, 1 Sep 2022 10:09:49 -0300 [thread overview]
Message-ID: <5ef03372-255e-9681-59ac-9019395b9bf6@linaro.org> (raw)
In-Reply-To: <87r10vr794.fsf@oldenburg.str.redhat.com>
On 01/09/22 02:30, Florian Weimer via Libc-alpha wrote:
> This did not cause a warning before because the token sequence for
> the two definitions was identical.
LGTM, thanks.
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
>
> ---
> elf/elf.h | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/elf/elf.h b/elf/elf.h
> index 065deca83c..273305a7cd 100644
> --- a/elf/elf.h
> +++ b/elf/elf.h
> @@ -1064,7 +1064,8 @@ typedef struct
>
> /* Legal values for vd_flags (version information flags). */
> #define VER_FLG_BASE 0x1 /* Version definition of file itself */
> -#define VER_FLG_WEAK 0x2 /* Weak version identifier */
> +#define VER_FLG_WEAK 0x2 /* Weak version identifier. Also
> + used by vna_flags below. */
>
> /* Versym symbol index values. */
> #define VER_NDX_LOCAL 0 /* Symbol is local. */
> @@ -1142,10 +1143,6 @@ typedef struct
> } Elf64_Vernaux;
>
>
> -/* Legal values for vna_flags. */
> -#define VER_FLG_WEAK 0x2 /* Weak version identifier */
> -
> -
> /* Auxiliary vector. */
>
> /* This vector is normally only used by the program interpreter. The
>
> base-commit: 4d3b77f020c2accf72af7a54f207d225c61db9bf
>
prev parent reply other threads:[~2022-09-01 13:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-01 5:30 Florian Weimer
2022-09-01 13:09 ` Adhemerval Zanella Netto [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ef03372-255e-9681-59ac-9019395b9bf6@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).