* [PATCH] elf.h: Remove duplicate definition of VER_FLG_WEAK
@ 2022-09-01 5:30 Florian Weimer
2022-09-01 13:09 ` Adhemerval Zanella Netto
0 siblings, 1 reply; 2+ messages in thread
From: Florian Weimer @ 2022-09-01 5:30 UTC (permalink / raw)
To: libc-alpha
This did not cause a warning before because the token sequence for
the two definitions was identical.
---
elf/elf.h | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/elf/elf.h b/elf/elf.h
index 065deca83c..273305a7cd 100644
--- a/elf/elf.h
+++ b/elf/elf.h
@@ -1064,7 +1064,8 @@ typedef struct
/* Legal values for vd_flags (version information flags). */
#define VER_FLG_BASE 0x1 /* Version definition of file itself */
-#define VER_FLG_WEAK 0x2 /* Weak version identifier */
+#define VER_FLG_WEAK 0x2 /* Weak version identifier. Also
+ used by vna_flags below. */
/* Versym symbol index values. */
#define VER_NDX_LOCAL 0 /* Symbol is local. */
@@ -1142,10 +1143,6 @@ typedef struct
} Elf64_Vernaux;
-/* Legal values for vna_flags. */
-#define VER_FLG_WEAK 0x2 /* Weak version identifier */
-
-
/* Auxiliary vector. */
/* This vector is normally only used by the program interpreter. The
base-commit: 4d3b77f020c2accf72af7a54f207d225c61db9bf
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] elf.h: Remove duplicate definition of VER_FLG_WEAK
2022-09-01 5:30 [PATCH] elf.h: Remove duplicate definition of VER_FLG_WEAK Florian Weimer
@ 2022-09-01 13:09 ` Adhemerval Zanella Netto
0 siblings, 0 replies; 2+ messages in thread
From: Adhemerval Zanella Netto @ 2022-09-01 13:09 UTC (permalink / raw)
To: libc-alpha, Florian Weimer
On 01/09/22 02:30, Florian Weimer via Libc-alpha wrote:
> This did not cause a warning before because the token sequence for
> the two definitions was identical.
LGTM, thanks.
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
>
> ---
> elf/elf.h | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/elf/elf.h b/elf/elf.h
> index 065deca83c..273305a7cd 100644
> --- a/elf/elf.h
> +++ b/elf/elf.h
> @@ -1064,7 +1064,8 @@ typedef struct
>
> /* Legal values for vd_flags (version information flags). */
> #define VER_FLG_BASE 0x1 /* Version definition of file itself */
> -#define VER_FLG_WEAK 0x2 /* Weak version identifier */
> +#define VER_FLG_WEAK 0x2 /* Weak version identifier. Also
> + used by vna_flags below. */
>
> /* Versym symbol index values. */
> #define VER_NDX_LOCAL 0 /* Symbol is local. */
> @@ -1142,10 +1143,6 @@ typedef struct
> } Elf64_Vernaux;
>
>
> -/* Legal values for vna_flags. */
> -#define VER_FLG_WEAK 0x2 /* Weak version identifier */
> -
> -
> /* Auxiliary vector. */
>
> /* This vector is normally only used by the program interpreter. The
>
> base-commit: 4d3b77f020c2accf72af7a54f207d225c61db9bf
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-09-01 13:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-01 5:30 [PATCH] elf.h: Remove duplicate definition of VER_FLG_WEAK Florian Weimer
2022-09-01 13:09 ` Adhemerval Zanella Netto
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).