From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: libc-alpha@sourceware.org, Stefan Liebler <stli@linux.ibm.com>
Subject: Re: [PATCH 2/5] linux: Disable fstatat64 fallback if __ASSUME_STATX is defined
Date: Fri, 26 Mar 2021 16:38:55 -0300 [thread overview]
Message-ID: <5fee0d40-4bff-8aa1-3897-cf2e758cdf97@linaro.org> (raw)
In-Reply-To: <0b9ffaea-2daf-9dd3-f2fa-5909b45bf1a4@linux.ibm.com>
On 26/03/2021 06:24, Stefan Liebler via Libc-alpha wrote:
> On 19/03/2021 19:31, Adhemerval Zanella via Libc-alpha wrote:
>> If the minimum kernel supports statx there is no need to call the
>> fallback stat legacy syscalls.
>>
>> The statx is also called on compat xstat syscall, but different
>> than the fstatat it calls no fallback and it is assumed to be
>> always present.
>>
>> Checked on powerpc-linux-gnu (with and without --enable-kernel=4.11)
>> and on powerpc64-linux-gnu.
>> ---
>> sysdeps/unix/sysv/linux/fstatat64.c | 57 +++++++++++++++++++++--------
>> 1 file changed, 41 insertions(+), 16 deletions(-)
>>
>> diff --git a/sysdeps/unix/sysv/linux/fstatat64.c b/sysdeps/unix/sysv/linux/fstatat64.c
>> index 490226a8ec..c3a030af58 100644
>> --- a/sysdeps/unix/sysv/linux/fstatat64.c
>> +++ b/sysdeps/unix/sysv/linux/fstatat64.c
>> @@ -31,6 +31,7 @@
>> #if __TIMESIZE == 64 \
>> && (__WORDSIZE == 32 \
>> && (!defined __SYSCALL_WORDSIZE || __SYSCALL_WORDSIZE == 32))
>> +# define FSTATAT_USE_STATX 1
> This will lead to a redefinition later in the file.
This is incorrect and a left over from a rebase, I will remove it.
next prev parent reply other threads:[~2021-03-26 19:38 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-19 18:31 [PATCH 0/5] More stat fixes Adhemerval Zanella
2021-03-19 18:31 ` [PATCH 1/5] linux: Implement fstatat with __fstatat64_time64 Adhemerval Zanella
2021-03-23 16:13 ` Stefan Liebler
2021-03-26 9:24 ` Stefan Liebler
2021-03-26 19:32 ` Adhemerval Zanella
2021-03-19 18:31 ` [PATCH 2/5] linux: Disable fstatat64 fallback if __ASSUME_STATX is defined Adhemerval Zanella
2021-03-26 9:24 ` Stefan Liebler
2021-03-26 19:38 ` Adhemerval Zanella [this message]
2021-03-19 18:31 ` [PATCH 3/5] linux: Use statx for MIPSn64 Adhemerval Zanella
2021-03-29 12:48 ` Adhemerval Zanella
2021-04-01 0:07 ` Maciej W. Rozycki
2021-04-01 12:45 ` Adhemerval Zanella
2021-04-01 18:00 ` Maciej W. Rozycki
2021-03-19 18:31 ` [PATCH 4/5] support: Add support_path_support_time64_value Adhemerval Zanella
2021-03-26 9:24 ` Stefan Liebler
2021-03-19 18:31 ` [PATCH 5/5] linux: Add y2106 support on utimensat tests Adhemerval Zanella
2021-03-26 9:24 ` Stefan Liebler
2021-03-26 19:40 ` Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5fee0d40-4bff-8aa1-3897-cf2e758cdf97@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
--cc=stli@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).