From: "Maciej W. Rozycki" <macro@orcam.me.uk>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH 3/5] linux: Use statx for MIPSn64
Date: Thu, 1 Apr 2021 20:00:48 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.21.2104011914340.18977@angie.orcam.me.uk> (raw)
In-Reply-To: <b6880447-9c45-dd47-a73a-7e88bbbdee78@linaro.org>
On Thu, 1 Apr 2021, Adhemerval Zanella via Libc-alpha wrote:
> > Weird indentation here (which made me wonder how the ordering between &&
> > and || has been resolved so that GCC does not complain before I realised
> > it's simply misindented parenthesisation). Only caught as I saw the GIT
> > commit message though.
>
> The preprocessor indentation is confusing sometimes, but I think it should
> adjusted only slight to follow other usages:
>
> diff --git a/sysdeps/unix/sysv/linux/fstatat64.c b/sysdeps/unix/sysv/linux/fstatat64.c
> index f968e4ef05..ab25f64187 100644
> --- a/sysdeps/unix/sysv/linux/fstatat64.c
> +++ b/sysdeps/unix/sysv/linux/fstatat64.c
> @@ -137,7 +137,7 @@ fstatat64_time64_stat (int fd, const char *file, struct __stat64_t64 *buf,
>
> #if (__WORDSIZE == 32 \
> && (!defined __SYSCALL_WORDSIZE || __SYSCALL_WORDSIZE == 32)) \
> - || defined STAT_HAS_TIME32
> + || defined STAT_HAS_TIME32
> # define FSTATAT_USE_STATX 1
> #else
>
> Am I missing something here?
No, that's what I meant.
While using outer parentheses seems to be what the GNU Coding Standards
suggest for Emacs to indent properly, but I'm no Emacs user and we have
cases with preprocessor statements missing those, and otherwise there is
no indentation ambiguity here, so I guess this will be OK with your
amendment above.
Maciej
next prev parent reply other threads:[~2021-04-01 18:00 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-19 18:31 [PATCH 0/5] More stat fixes Adhemerval Zanella
2021-03-19 18:31 ` [PATCH 1/5] linux: Implement fstatat with __fstatat64_time64 Adhemerval Zanella
2021-03-23 16:13 ` Stefan Liebler
2021-03-26 9:24 ` Stefan Liebler
2021-03-26 19:32 ` Adhemerval Zanella
2021-03-19 18:31 ` [PATCH 2/5] linux: Disable fstatat64 fallback if __ASSUME_STATX is defined Adhemerval Zanella
2021-03-26 9:24 ` Stefan Liebler
2021-03-26 19:38 ` Adhemerval Zanella
2021-03-19 18:31 ` [PATCH 3/5] linux: Use statx for MIPSn64 Adhemerval Zanella
2021-03-29 12:48 ` Adhemerval Zanella
2021-04-01 0:07 ` Maciej W. Rozycki
2021-04-01 12:45 ` Adhemerval Zanella
2021-04-01 18:00 ` Maciej W. Rozycki [this message]
2021-03-19 18:31 ` [PATCH 4/5] support: Add support_path_support_time64_value Adhemerval Zanella
2021-03-26 9:24 ` Stefan Liebler
2021-03-19 18:31 ` [PATCH 5/5] linux: Add y2106 support on utimensat tests Adhemerval Zanella
2021-03-26 9:24 ` Stefan Liebler
2021-03-26 19:40 ` Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2104011914340.18977@angie.orcam.me.uk \
--to=macro@orcam.me.uk \
--cc=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).