Re: [PATCH v7 5/5] linux: Add mount_setattr

[Adhemerval Zanella <adhemerval.zanella@linaro.org>]

> On 6 Jul 2022, at 06:25, Andreas Schwab <schwab@suse.de> wrote:
> 
> This is causing a conflict with <linux/mount.h>, breaking the build of
> gcc.
> 
> In file included from /usr/include/linux/fs.h:19,
>                 from ../../../../libsanitizer/sanitizer_common/sanitizer_platform_limits_posix.cpp:76:
> /usr/include/linux/mount.h:95:6: error: multiple definition of 'enum fsconfig_command'
>   95 | enum fsconfig_command {
>      |      ^~~~~~~~~~~~~~~~
> In file included from ../../../../libsanitizer/sanitizer_common/sanitizer_platform_limits_posix.cpp:63:
> /usr/include/sys/mount.h:189:6: note: previous definition here
>  189 | enum fsconfig_command
>      |      ^~~~~~~~~~~~~~~~
> /usr/include/linux/mount.h:129:8: error: redefinition of 'struct mount_attr'
>  129 | struct mount_attr {
>      |        ^~~~~~~~~~
> /usr/include/sys/mount.h:161:8: note: previous definition of 'struct mount_attr'
>  161 | struct mount_attr
>      |        ^~~~~~~~~~
> make[4]: *** [Makefile:617: sanitizer_platform_limits_posix.lo] Error 1

I am not sure how to handle it, glibc sys/mount.h should be a standalone
header.  Maybe check if _UAPI_LINUX_MOUNT_H is defined so to use the
kernel definition? Or check the kernel version and __has_include and use
kernel version instead?

> 
> -- 
> Andreas Schwab, SUSE Labs, schwab@suse.de
> GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
> "And now for something completely different."