Re: [PATCH v7 1/5] linux: Add fsconfig

[Carlos O'Donell <carlos@redhat.com>]

On 7/11/22 04:16, Fangrui Song wrote:
> On 2022-07-04, Carlos O'Donell via Libc-alpha wrote:
>> On 6/24/22 15:59, Adhemerval Zanella wrote:
>>> It was added on Linux 5.2 (ecdab150fddb42fe6a739335257949220033b782)
>>> as a way to a configure filesystem creation context and trigger
>>> actions upon it, to be used in conjunction with fsopen, fspick and
>>> fsmount.
>>>
>>> The fsconfig_command commands are currently only defined as an enum,
>>> so they can't be checked on tst-mount-consts.py with current test
>>> support.
>>
>> LGTM. API uses const void * correctly and syscall wrapper signature matches.
>>
>> Reviewed-by: Carlos O'Donell <carlos@redhat.com>
> 
> https://sourceware.org/glibc/wiki/Synchronizing_Headers can be updated that
> 
>     #include <sys/mount.h>
>     #include <linux/mount.h>
> 
> no longer works. This led to a compiler-rt build failure which I am
> going to fix in https://reviews.llvm.org/D129471 (llvm-project 15.0 will be branched soon
> https://discourse.llvm.org/t/llvm-15-0-0-release-schedule/63495)
> 
> Note:
> 
>     #include <linux/mount.h>
>     #include <sys/mount.h>
> 
> doesn't work for a long time
> 
>     /usr/include/x86_64-linux-gnu/sys/mount.h:35:3: error: expected identifier before numeric constant
>        35 |   MS_RDONLY = 1,                /* Mount read-only.  */
>           |   ^~~~~~~~~
> 

I added the known conflict to the wiki. Thanks.

-- 
Cheers,
Carlos.