From: Xi Ruoyao <xry111@xry111.site>
To: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>,
caiyinyu <caiyinyu@loongson.cn>,
libc-alpha@sourceware.org, joseph_myers@mentor.com,
carlos@redhat.com, i.swmail@xen0n.name
Cc: xuchenghua@loongson.cn
Subject: Re: [PATCH 1/2] LoongArch: Fix ptr mangling/demangling features.
Date: Thu, 25 Aug 2022 23:27:55 +0800 [thread overview]
Message-ID: <627c332247e2a3ce48658e2d531f6d7a7df19312.camel@xry111.site> (raw)
In-Reply-To: <8562da19-d9d3-a4f3-2aae-2a4489af6806@linaro.org>
On Thu, 2022-08-25 at 12:08 -0300, Adhemerval Zanella Netto wrote:
> Does is really pay off the complexity to use HAVE_LOONGARCH_EXPLICIT_RELOCS? The
> PTR_MANGLE is used some specific cases and hardly a hotstop.
LDST_PCREL added as a macro in sysdep.h, so further assembly
implementations might reuse it then it may appear in some hot spot.
If we quote "optimization too early is the ultimate evil", we can drop
it for now and review once we use LDST_PCREL somewhere else. But to me
this is rather a simple autoconf check and I can't figure out a
situation where it's evil...
--
Xi Ruoyao <xry111@xry111.site>
School of Aerospace Science and Technology, Xidian University
next prev parent reply other threads:[~2022-08-25 15:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-23 12:28 [PATCH 0/2] " caiyinyu
2022-08-23 12:28 ` [PATCH 1/2] " caiyinyu
2022-08-25 15:08 ` Adhemerval Zanella Netto
2022-08-25 15:27 ` Xi Ruoyao [this message]
2022-08-25 17:01 ` Adhemerval Zanella Netto
2022-08-26 2:44 ` caiyinyu
2022-08-26 8:11 ` caiyinyu
2022-08-23 12:28 ` [PATCH 2/2] LoongArch: Add HAVE_LOONGARCH_EXPLICIT_RELOCS in config.h.in caiyinyu
2022-08-25 15:06 ` Adhemerval Zanella Netto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=627c332247e2a3ce48658e2d531f6d7a7df19312.camel@xry111.site \
--to=xry111@xry111.site \
--cc=adhemerval.zanella@linaro.org \
--cc=caiyinyu@loongson.cn \
--cc=carlos@redhat.com \
--cc=i.swmail@xen0n.name \
--cc=joseph_myers@mentor.com \
--cc=libc-alpha@sourceware.org \
--cc=xuchenghua@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).