public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: caiyinyu <caiyinyu@loongson.cn>, libc-alpha@sourceware.org
Cc: xuchenghua@loongson.cn, joseph_myers@mentor.com
Subject: Re: [PATCH v2 00/14] GLIBC LoongArch PATCHES
Date: Tue, 4 Jan 2022 10:27:32 -0300	[thread overview]
Message-ID: <65f49596-18eb-ef04-a89b-2f384f23e7d9@linaro.org> (raw)
In-Reply-To: <20211231064455.1030051-1-caiyinyu@loongson.cn>



On 31/12/2021 03:44, caiyinyu wrote:
> FAIL: elf/ifuncmain1
> FAIL: elf/ifuncmain1pic
> FAIL: elf/ifuncmain1pie
> FAIL: elf/ifuncmain1staticpic
> FAIL: elf/ifuncmain1staticpie
> FAIL: elf/ifuncmain1vis
> FAIL: elf/ifuncmain1vispic
> FAIL: elf/ifuncmain1vispie
> FAIL: elf/ifuncmain3
> FAIL: elf/ifuncmain4
> FAIL: elf/ifuncmain6pie
> FAIL: elf/ifuncmain7
> FAIL: elf/ifuncmain7pic
> FAIL: elf/ifuncmain7pie
> FAIL: elf/tst-ifunc-fault-bindnow
> FAIL: elf/tst-ifunc-fault-lazy
> 
> ifunc functions are not support yet

If the target does not support ifunc, why libc_cv_ld_gnu_indirect_function is being
set then? I think you will need to disable the usage of %gnu_indirect_function
on static linker.

> 
> c.
> FAIL: math/test-double-acos
> FAIL: math/test-double-asin
> FAIL: math/test-float32x-acos
> FAIL: math/test-float32x-asin
> FAIL: math/test-float64-acos
> FAIL: math/test-float64-asin
> 
> These fails are caused by gcc optimizations. if we use -O0 options, these fails
> will pass.
> 
> sysdeps/ieee754/dbl-64/e_asin.c: 343
> ===================================================================
> 337	  if (k>0x7ff00000 || (k == 0x7ff00000 && u.i[LOW_HALF] != 0)) return x + x;
>    0x00007ffff7f4daac <+1388>:	lu12i.w     	$t0, 524032(0x7ff00)
>    0x00007ffff7f4dab0 <+1392>:	blt         	$t0, $t2, 20(0x14)	# 0x7ffff7f4dac4 <__ieee754_acos+1412>
>    0x00007ffff7f4dab4 <+1396>:	bne         	$t2, $t0, 36(0x24)	# 0x7ffff7f4dad8 <__ieee754_acos+1432>
>    0x00007ffff7f4dab8 <+1400>:	ld.d        	$t0, $sp, 8(0x8)
>    0x00007ffff7f4dabc <+1404>:	slli.w      	$t0, $t0, 0x0
>    0x00007ffff7f4dac0 <+1408>:	beqz        	$t0, 24(0x18)	# 0x7ffff7f4dad8 <__ieee754_acos+1432>
>    0x00007ffff7f4dac4 <+1412>:	fld.d       	$fa0, $sp, 8(0x8)
>    0x00007ffff7f4dac8 <+1416>:	fadd.d      	$fa0, $fa0, $fa0
>    0x00007ffff7f4dacc <+1420>:	b           	-788(0xffffcec)	# 0x7ffff7f4d7b8 <__ieee754_acos+632>
> 
> 338	  else {
> 339	    u.i[HIGH_HALF]=0x7ff00000;
> 340	    v.i[HIGH_HALF]=0x7ff00000;
> 341	    u.i[LOW_HALF]=0;
> 342	    v.i[LOW_HALF]=0;
> 343	    return u.x/v.x;			/////////  optimized out
> 
>    0x00007ffff7f4dad8 <+1432>:	pcaddu12i   	$t0, 63(0x3f)
>    0x00007ffff7f4dadc <+1436>:	addi.d      	$t0, $t0, -1248(0xb20)
>    0x00007ffff7f4dae0 <+1440>:	fld.d       	$fa0, $t0, 0
>    0x00007ffff7f4dae4 <+1444>:	b           	-812(0xffffcd4)	# 0x7ffff7f4d7b8 <__ieee754_acos+632>
> 
> 344	  }
> 345	}
>    0x00007ffff7f4d7b8 <+632>:	addi.d      	$sp, $sp, 16(0x10)
>    0x00007ffff7f4d7bc <+636>:	jirl        	$zero, $ra, 0
>    0x00007ffff7f4d7cc <+652>:	addi.d      	$sp, $sp, 16(0x10)
>    0x00007ffff7f4d7d0 <+656>:	jirl        	$zero, $ra, 0
>    0x00007ffff7f4d8bc <+892>:	addi.d      	$sp, $sp, 16(0x10)
>    0x00007ffff7f4d8c0 <+896>:	jirl        	$zero, $ra, 0
> ===================================================================

Is this being tracked by a GCC bug report? We need to understand if we 
require to use math_force_eval to avoid such issue on other ports as
well.

  parent reply	other threads:[~2022-01-04 13:27 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-31  6:44 caiyinyu
2021-12-31  6:44 ` [PATCH v2 01/14] LoongArch: Update NEWS and README for the LoongArch port caiyinyu
2022-01-04 13:30   ` Adhemerval Zanella
2022-04-15  1:28     ` caiyinyu
2021-12-31  6:44 ` [PATCH v2 02/14] LoongArch: Add LoongArch entries to config.h.in caiyinyu
2021-12-31  6:44 ` [PATCH v2 03/14] LoongArch: Add relocations and ELF flags to elf.h caiyinyu
2021-12-31  6:44 ` [PATCH v2 04/14] LoongArch: ABI Implementation caiyinyu
2022-01-04 13:46   ` Adhemerval Zanella
2022-04-15  1:28     ` caiyinyu
2021-12-31  6:44 ` [PATCH v2 05/14] LoongArch: Thread-Local Storage Support caiyinyu
2022-01-04 14:01   ` Adhemerval Zanella
2022-04-15  1:28     ` caiyinyu
2021-12-31  6:44 ` [PATCH v2 06/14] LoongArch: Generic <math.h> and soft-fp Routines caiyinyu
2022-01-04 14:05   ` Adhemerval Zanella
2022-01-04 20:31     ` Joseph Myers
2021-12-31  6:44 ` [PATCH v2 07/14] LoongArch: Atomic and Locking Routines caiyinyu
2022-01-04 14:09   ` Adhemerval Zanella
2022-04-15  1:28     ` caiyinyu
2021-12-31  6:44 ` [PATCH v2 08/14] LoongArch: Linux Syscall Interface caiyinyu
2022-01-04 14:20   ` Adhemerval Zanella
2022-04-15  1:28     ` caiyinyu
2021-12-31  6:44 ` [PATCH v2 09/14] LoongArch: Linux ABI caiyinyu
2021-12-31 17:37   ` Joseph Myers
2022-04-15  1:27     ` caiyinyu
2022-01-04 14:24   ` Adhemerval Zanella
2022-04-15  1:28     ` caiyinyu
2021-12-31  6:44 ` [PATCH v2 10/14] LoongArch: Linux Startup and Dynamic Loading Code caiyinyu
2022-01-04 14:27   ` Adhemerval Zanella
2022-04-15  1:28     ` caiyinyu
2021-12-31  6:44 ` [PATCH v2 11/14] LoongArch: Add ABI Lists caiyinyu
2021-12-31 17:43   ` Joseph Myers
2022-04-15  1:27     ` caiyinyu
2021-12-31  6:44 ` [PATCH v2 12/14] LoongArch: Build Infastructure caiyinyu
2022-01-04 14:33   ` Adhemerval Zanella
2021-12-31  6:44 ` [PATCH v2 13/14] LoongArch: Hard Float Support caiyinyu
2021-12-31 17:47   ` Joseph Myers
2022-04-15  1:27     ` caiyinyu
2021-12-31  6:44 ` [PATCH v2 14/14] LoongArch: Update build-many-glibcs.py for the LoongArch Port caiyinyu
2021-12-31 17:34 ` [PATCH v2 00/14] GLIBC LoongArch PATCHES Joseph Myers
2022-04-15  1:27   ` caiyinyu
2022-01-04 13:27 ` Adhemerval Zanella [this message]
2022-04-15  1:28   ` caiyinyu
     [not found] <65f49596-18eb-ef04-a89b-2f384f23e7d9 () linaro ! org>
2022-01-30  0:43 ` Xi Ruoyao
2022-02-02  3:51   ` Xi Ruoyao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=65f49596-18eb-ef04-a89b-2f384f23e7d9@linaro.org \
    --to=adhemerval.zanella@linaro.org \
    --cc=caiyinyu@loongson.cn \
    --cc=joseph_myers@mentor.com \
    --cc=libc-alpha@sourceware.org \
    --cc=xuchenghua@loongson.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).