From: Joseph Myers <joseph@codesourcery.com>
To: caiyinyu <caiyinyu@loongson.cn>
Cc: <libc-alpha@sourceware.org>, <xuchenghua@loongson.cn>
Subject: Re: [PATCH v2 00/14] GLIBC LoongArch PATCHES
Date: Fri, 31 Dec 2021 17:34:29 +0000 [thread overview]
Message-ID: <alpine.DEB.2.22.394.2112311724150.2293191@digraph.polyomino.org.uk> (raw)
In-Reply-To: <20211231064455.1030051-1-caiyinyu@loongson.cn>
On Fri, 31 Dec 2021, caiyinyu wrote:
> b.
> FAIL: elf/ifuncmain1
> FAIL: elf/ifuncmain1pic
> FAIL: elf/ifuncmain1pie
> FAIL: elf/ifuncmain1staticpic
> FAIL: elf/ifuncmain1staticpie
> FAIL: elf/ifuncmain1vis
> FAIL: elf/ifuncmain1vispic
> FAIL: elf/ifuncmain1vispie
> FAIL: elf/ifuncmain3
> FAIL: elf/ifuncmain4
> FAIL: elf/ifuncmain6pie
> FAIL: elf/ifuncmain7
> FAIL: elf/ifuncmain7pic
> FAIL: elf/ifuncmain7pie
> FAIL: elf/tst-ifunc-fault-bindnow
> FAIL: elf/tst-ifunc-fault-lazy
>
> ifunc functions are not support yet
If IFUNC isn't supported, the configure test
(libc_cv_ld_gnu_indirect_function) should fail, have-ifunc should be no
and elf/Makefile should disable the tests.
Those failures suggest you have partial support in the toolchain - enough
binutils support for the tests to be enabled - but are either missing
glibc support, or some of the toolchain support is broken. In that case,
you should fix/add the broken/missing support so that the tests pass. (Or
if it's wrong that the libc_cv_ld_gnu_indirect_function test passes at
all, maybe that's a binutils bug and you need to fix the binutils port so
that that configure test fails.)
> c.
> FAIL: math/test-double-acos
> FAIL: math/test-double-asin
> FAIL: math/test-float32x-acos
> FAIL: math/test-float32x-asin
> FAIL: math/test-float64-acos
> FAIL: math/test-float64-asin
>
> These fails are caused by gcc optimizations. if we use -O0 options, these fails
> will pass.
So that issue needs fixing in GCC upstream.
> 10. Note the need for a manual/math.texi update in the list of
> configurations supporting _Float128.
>
> not support yet
It's supported by the port (with the same ABI as long double, via the
ieee754/ldbl-128 inclusion in sysdeps/loongarch/Implies) - the functions
are in the ABI test baselines. So you need to update math.texi to reflect
that.
> 13. arch_minimum_kernel should be set to 10.0.0 until the actual upstream
> kernel version that gets the port is known, and then to the actual
> upstream version (so 5.14.0 or later). Accordingly, kernel-features.h
> should not have any "before 4.20" conditionals in it (so you don't need an
> architecture-specific kernel-features.h at all).
>
> corrected
You have arch_minimum_kernel=5.15.0, but the support isn't in 5.15.0, and
indeed isn't in Linus's git tree for 5.16 either.
Once it's in Linus's git tree, you can set arch_minimum_kernel to the
actual version that will have the port. Until then, you should use 10.0.0
as a placeholder.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2021-12-31 17:34 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-31 6:44 caiyinyu
2021-12-31 6:44 ` [PATCH v2 01/14] LoongArch: Update NEWS and README for the LoongArch port caiyinyu
2022-01-04 13:30 ` Adhemerval Zanella
2022-04-15 1:28 ` caiyinyu
2021-12-31 6:44 ` [PATCH v2 02/14] LoongArch: Add LoongArch entries to config.h.in caiyinyu
2021-12-31 6:44 ` [PATCH v2 03/14] LoongArch: Add relocations and ELF flags to elf.h caiyinyu
2021-12-31 6:44 ` [PATCH v2 04/14] LoongArch: ABI Implementation caiyinyu
2022-01-04 13:46 ` Adhemerval Zanella
2022-04-15 1:28 ` caiyinyu
2021-12-31 6:44 ` [PATCH v2 05/14] LoongArch: Thread-Local Storage Support caiyinyu
2022-01-04 14:01 ` Adhemerval Zanella
2022-04-15 1:28 ` caiyinyu
2021-12-31 6:44 ` [PATCH v2 06/14] LoongArch: Generic <math.h> and soft-fp Routines caiyinyu
2022-01-04 14:05 ` Adhemerval Zanella
2022-01-04 20:31 ` Joseph Myers
2021-12-31 6:44 ` [PATCH v2 07/14] LoongArch: Atomic and Locking Routines caiyinyu
2022-01-04 14:09 ` Adhemerval Zanella
2022-04-15 1:28 ` caiyinyu
2021-12-31 6:44 ` [PATCH v2 08/14] LoongArch: Linux Syscall Interface caiyinyu
2022-01-04 14:20 ` Adhemerval Zanella
2022-04-15 1:28 ` caiyinyu
2021-12-31 6:44 ` [PATCH v2 09/14] LoongArch: Linux ABI caiyinyu
2021-12-31 17:37 ` Joseph Myers
2022-04-15 1:27 ` caiyinyu
2022-01-04 14:24 ` Adhemerval Zanella
2022-04-15 1:28 ` caiyinyu
2021-12-31 6:44 ` [PATCH v2 10/14] LoongArch: Linux Startup and Dynamic Loading Code caiyinyu
2022-01-04 14:27 ` Adhemerval Zanella
2022-04-15 1:28 ` caiyinyu
2021-12-31 6:44 ` [PATCH v2 11/14] LoongArch: Add ABI Lists caiyinyu
2021-12-31 17:43 ` Joseph Myers
2022-04-15 1:27 ` caiyinyu
2021-12-31 6:44 ` [PATCH v2 12/14] LoongArch: Build Infastructure caiyinyu
2022-01-04 14:33 ` Adhemerval Zanella
2021-12-31 6:44 ` [PATCH v2 13/14] LoongArch: Hard Float Support caiyinyu
2021-12-31 17:47 ` Joseph Myers
2022-04-15 1:27 ` caiyinyu
2021-12-31 6:44 ` [PATCH v2 14/14] LoongArch: Update build-many-glibcs.py for the LoongArch Port caiyinyu
2021-12-31 17:34 ` Joseph Myers [this message]
2022-04-15 1:27 ` [PATCH v2 00/14] GLIBC LoongArch PATCHES caiyinyu
2022-01-04 13:27 ` Adhemerval Zanella
2022-04-15 1:28 ` caiyinyu
[not found] <65f49596-18eb-ef04-a89b-2f384f23e7d9 () linaro ! org>
2022-01-30 0:43 ` Xi Ruoyao
2022-02-02 3:51 ` Xi Ruoyao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.22.394.2112311724150.2293191@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=caiyinyu@loongson.cn \
--cc=libc-alpha@sourceware.org \
--cc=xuchenghua@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).