From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: caiyinyu <caiyinyu@loongson.cn>, libc-alpha@sourceware.org
Cc: xuchenghua@loongson.cn, joseph_myers@mentor.com
Subject: Re: [PATCH v2 10/14] LoongArch: Linux Startup and Dynamic Loading Code
Date: Tue, 4 Jan 2022 11:27:52 -0300 [thread overview]
Message-ID: <3b630aac-4a2a-76a4-483f-3bbcef8297cf@linaro.org> (raw)
In-Reply-To: <20211231064455.1030051-11-caiyinyu@loongson.cn>
On 31/12/2021 03:44, caiyinyu wrote:
> This contains the Linux-specific code for loading programs on LoongArch.
> ---
> sysdeps/unix/sysv/linux/loongarch/dl-static.c | 80 +++++++++++++++++++
> sysdeps/unix/sysv/linux/loongarch/ldsodefs.h | 33 ++++++++
> 2 files changed, 113 insertions(+)
> create mode 100644 sysdeps/unix/sysv/linux/loongarch/dl-static.c
> create mode 100644 sysdeps/unix/sysv/linux/loongarch/ldsodefs.h
>
> diff --git a/sysdeps/unix/sysv/linux/loongarch/dl-static.c b/sysdeps/unix/sysv/linux/loongarch/dl-static.c
> new file mode 100644
> index 0000000000..b9a7b2a61f
> --- /dev/null
> +++ b/sysdeps/unix/sysv/linux/loongarch/dl-static.c
> @@ -0,0 +1,80 @@
> +/* dl_static_init for loongarch.
> + Copyright (C) 2021 Free Software Foundation, Inc.
> +
> + This file is part of the GNU C Library.
> +
> + The GNU C Library is free software; you can redistribute it and/or
> + modify it under the terms of the GNU Lesser General Public
> + License as published by the Free Software Foundation; either
> + version 2.1 of the License, or (at your option) any later version.
> +
> + The GNU C Library is distributed in the hope that it will be useful,
> + but WITHOUT ANY WARRANTY; without even the implied warranty of
> + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
> + Lesser General Public License for more details.
> +
> + You should have received a copy of the GNU Lesser General Public
> + License along with the GNU C Library. If not, see
> + <https://www.gnu.org/licenses/>. */
> +
> +#include <ldsodefs.h>
> +
> +#ifdef SHARED
> +
> +void
> +_dl_var_init (void *array[])
> +{
> + /* It has to match "variables" below. */
> + enum
> + {
> + DL_PAGESIZE = 0
> + };
> +
> + GLRO (dl_pagesize) = *((size_t *) array[DL_PAGESIZE]);
> +}
> +
> +#else
> +
> +static void *variables[] = {&GLRO (dl_pagesize)};
> +
> +static void _dl_unprotect_relro (struct link_map *l)
> +{
> + ElfW (Addr) start = ((l->l_addr + l->l_relro_addr)
> + & ~(GLRO (dl_pagesize) - 1));
> + ElfW (Addr) end = ((l->l_addr + l->l_relro_addr + l->l_relro_size)
> + & ~(GLRO (dl_pagesize) - 1));
> +
> + if (start != end)
> + __mprotect ((void *) start, end - start, PROT_READ | PROT_WRITE);
> +}
> +
> +void dl_static_init (struct link_map *l)
> +{
> + struct link_map *rtld_map = l;
> + struct r_scope_elem **scope;
> + const ElfW (Sym) *ref = NULL;
> + lookup_t loadbase;
> + void (*f) (void *[]);
> + size_t i;
> +
> + loadbase = _dl_lookup_symbol_x ("_dl_var_init", l, &ref, l->l_local_scope,
> + NULL, 0, 1, NULL);
> +
> + for (scope = l->l_local_scope; *scope != NULL; scope++)
> + for (i = 0; i < (*scope)->r_nlist; i++)
> + if ((*scope)->r_list[i] == loadbase)
> + {
> + rtld_map = (*scope)->r_list[i];
> + break;
> + }
> +
> + if (ref != NULL)
> + {
> + f = (void (*) (void *[])) DL_SYMBOL_ADDRESS (loadbase, ref);
> + _dl_unprotect_relro (rtld_map);
> + f (variables);
> + _dl_protect_relro (rtld_map);
> + }
> +}
> +
> +#endif
This file should not be required, Florian has refactored it to avoid this
boilerplate code (check bdc90abc48f0528588600df37eebdc04ce01b2f0 and
related commits).
> diff --git a/sysdeps/unix/sysv/linux/loongarch/ldsodefs.h b/sysdeps/unix/sysv/linux/loongarch/ldsodefs.h
> new file mode 100644
> index 0000000000..680baf2edc
> --- /dev/null
> +++ b/sysdeps/unix/sysv/linux/loongarch/ldsodefs.h
> @@ -0,0 +1,33 @@
> +/* Run-time dynamic linker data structures for loaded ELF shared objects.
> + Copyright (C) 2021 Free Software Foundation, Inc.
> +
> + This file is part of the GNU C Library.
> +
> + The GNU C Library is free software; you can redistribute it and/or
> + modify it under the terms of the GNU Lesser General Public
> + License as published by the Free Software Foundation; either
> + version 2.1 of the License, or (at your option) any later version.
> +
> + The GNU C Library is distributed in the hope that it will be useful,
> + but WITHOUT ANY WARRANTY; without even the implied warranty of
> + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
> + Lesser General Public License for more details.
> +
> + You should have received a copy of the GNU Lesser General Public
> + License along with the GNU C Library. If not, see
> + <https://www.gnu.org/licenses/>. */
> +
> +#ifndef _LDSODEFS_H
> +
> +/* Get the real definitions. */
> +#include_next <ldsodefs.h>
> +
> +/* Now define our stuff. */
> +
> +/* We need special support to initialize DSO loaded for statically linked
> + binaries. */
> +extern void _dl_static_init (struct link_map *map);
> +#undef DL_STATIC_INIT
> +#define DL_STATIC_INIT(map) _dl_static_init (map)
> +
> +#endif /* ldsodefs.h */
Same as before.
next prev parent reply other threads:[~2022-01-04 14:27 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-31 6:44 [PATCH v2 00/14] GLIBC LoongArch PATCHES caiyinyu
2021-12-31 6:44 ` [PATCH v2 01/14] LoongArch: Update NEWS and README for the LoongArch port caiyinyu
2022-01-04 13:30 ` Adhemerval Zanella
2022-04-15 1:28 ` caiyinyu
2021-12-31 6:44 ` [PATCH v2 02/14] LoongArch: Add LoongArch entries to config.h.in caiyinyu
2021-12-31 6:44 ` [PATCH v2 03/14] LoongArch: Add relocations and ELF flags to elf.h caiyinyu
2021-12-31 6:44 ` [PATCH v2 04/14] LoongArch: ABI Implementation caiyinyu
2022-01-04 13:46 ` Adhemerval Zanella
2022-04-15 1:28 ` caiyinyu
2021-12-31 6:44 ` [PATCH v2 05/14] LoongArch: Thread-Local Storage Support caiyinyu
2022-01-04 14:01 ` Adhemerval Zanella
2022-04-15 1:28 ` caiyinyu
2021-12-31 6:44 ` [PATCH v2 06/14] LoongArch: Generic <math.h> and soft-fp Routines caiyinyu
2022-01-04 14:05 ` Adhemerval Zanella
2022-01-04 20:31 ` Joseph Myers
2021-12-31 6:44 ` [PATCH v2 07/14] LoongArch: Atomic and Locking Routines caiyinyu
2022-01-04 14:09 ` Adhemerval Zanella
2022-04-15 1:28 ` caiyinyu
2021-12-31 6:44 ` [PATCH v2 08/14] LoongArch: Linux Syscall Interface caiyinyu
2022-01-04 14:20 ` Adhemerval Zanella
2022-04-15 1:28 ` caiyinyu
2021-12-31 6:44 ` [PATCH v2 09/14] LoongArch: Linux ABI caiyinyu
2021-12-31 17:37 ` Joseph Myers
2022-04-15 1:27 ` caiyinyu
2022-01-04 14:24 ` Adhemerval Zanella
2022-04-15 1:28 ` caiyinyu
2021-12-31 6:44 ` [PATCH v2 10/14] LoongArch: Linux Startup and Dynamic Loading Code caiyinyu
2022-01-04 14:27 ` Adhemerval Zanella [this message]
2022-04-15 1:28 ` caiyinyu
2021-12-31 6:44 ` [PATCH v2 11/14] LoongArch: Add ABI Lists caiyinyu
2021-12-31 17:43 ` Joseph Myers
2022-04-15 1:27 ` caiyinyu
2021-12-31 6:44 ` [PATCH v2 12/14] LoongArch: Build Infastructure caiyinyu
2022-01-04 14:33 ` Adhemerval Zanella
2021-12-31 6:44 ` [PATCH v2 13/14] LoongArch: Hard Float Support caiyinyu
2021-12-31 17:47 ` Joseph Myers
2022-04-15 1:27 ` caiyinyu
2021-12-31 6:44 ` [PATCH v2 14/14] LoongArch: Update build-many-glibcs.py for the LoongArch Port caiyinyu
2021-12-31 17:34 ` [PATCH v2 00/14] GLIBC LoongArch PATCHES Joseph Myers
2022-04-15 1:27 ` caiyinyu
2022-01-04 13:27 ` Adhemerval Zanella
2022-04-15 1:28 ` caiyinyu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b630aac-4a2a-76a4-483f-3bbcef8297cf@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=caiyinyu@loongson.cn \
--cc=joseph_myers@mentor.com \
--cc=libc-alpha@sourceware.org \
--cc=xuchenghua@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).