From: Carlos O'Donell <carlos@redhat.com>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>,
libc-alpha@sourceware.org
Subject: Re: [PATCH v2 06/25] linux: Add fallback for 64-bit time_t SO_TIMESTAMP{NS}
Date: Fri, 4 Jun 2021 15:30:46 -0400 [thread overview]
Message-ID: <710517d3-821f-49a3-3fd9-cbf1cb20ce84@redhat.com> (raw)
In-Reply-To: <20210518205613.1487824-7-adhemerval.zanella@linaro.org>
On 5/18/21 4:55 PM, Adhemerval Zanella wrote:
> The recvmsg handling is more complicated because it requires check the
> returned kernel control message and make some convertions. For
> !__ASSUME_TIME64_SYSCALLS it converts the first 32-bit time SO_TIMESTAMP
> or SO_TIMESTAMPNS and appends it to the control buffer if has extra
> space or returns MSG_CTRUNC otherwise. The 32-bit time field is kept
> as-is.
>
> Calls with __TIMESIZE=32 will see the converted 64-bit time control
> messages as spurious control message of unknown type. Calls with
> __TIMESIZE=64 running on pre-time64 kernels will see the original
> message as a spurious control ones of unknown typ while running on
> kernel with native 64-bit time support will only see the time64 version
> of the control message.
>
> Checked on x86_64-linux-gnu and i686-linux-gnu (on 5.4 and on 4.15
> kernel).
LGTM.
No regressions on x86_64, i686, ppc64le, aarch64, s390x.
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
Tested-by: Carlos O'Donell <carlos@redhat.com>
> ---
> include/sys/socket.h | 5 +
> sysdeps/unix/sysv/linux/Makefile | 2 +-
> sysdeps/unix/sysv/linux/Versions | 1 +
> .../unix/sysv/linux/convert_scm_timestamps.c | 96 +++++++++++++++++++
> sysdeps/unix/sysv/linux/getsockopt.c | 12 +++
> .../sysv/linux/hppa/socket-constants-time64.h | 5 +
> .../sysv/linux/mips/socket-constants-time64.h | 5 +
> .../linux/powerpc/socket-constants-time64.h | 5 +
> sysdeps/unix/sysv/linux/recvmsg.c | 23 +++--
> sysdeps/unix/sysv/linux/setsockopt.c | 12 +++
> .../unix/sysv/linux/socket-constants-time64.h | 5 +
> .../linux/sparc/socket-constants-time64.h | 5 +
> 12 files changed, 169 insertions(+), 7 deletions(-)
> create mode 100644 sysdeps/unix/sysv/linux/convert_scm_timestamps.c
>
> diff --git a/include/sys/socket.h b/include/sys/socket.h
> index 0e39dd2a3a..15d4a62b26 100644
> --- a/include/sys/socket.h
> +++ b/include/sys/socket.h
> @@ -164,5 +164,10 @@ libc_hidden_proto (__libc_sa_len)
>
> libc_hidden_proto (__cmsg_nxthdr)
>
> +#ifndef __ASSUME_TIME64_SYSCALLS
> +extern void __convert_scm_timestamps (struct msghdr *msg, socklen_t msgsize) ;
> +libc_hidden_proto (__convert_scm_timestamps)
> +#endif
> +
> #endif
> #endif
> diff --git a/sysdeps/unix/sysv/linux/Makefile b/sysdeps/unix/sysv/linux/Makefile
> index fb155cf856..e28f6470e3 100644
> --- a/sysdeps/unix/sysv/linux/Makefile
> +++ b/sysdeps/unix/sysv/linux/Makefile
> @@ -64,7 +64,7 @@ sysdep_routines += adjtimex clone umount umount2 readahead sysctl \
> time64-support pselect32 \
> xstat fxstat lxstat xstat64 fxstat64 lxstat64 \
> fxstatat fxstatat64 \
> - xmknod xmknodat
> + xmknod xmknodat convert_scm_timestamps
>
> CFLAGS-gethostid.c = -fexceptions
> CFLAGS-tee.c = -fexceptions -fasynchronous-unwind-tables
> diff --git a/sysdeps/unix/sysv/linux/Versions b/sysdeps/unix/sysv/linux/Versions
> index 220bb2dffe..148f04c50a 100644
> --- a/sysdeps/unix/sysv/linux/Versions
> +++ b/sysdeps/unix/sysv/linux/Versions
> @@ -177,6 +177,7 @@ libc {
> __pread64_nocancel;
> __close_nocancel;
> __sigtimedwait;
> + __convert_scm_timestamps;
> # functions used by nscd
> __netlink_assert_response;
> }
> diff --git a/sysdeps/unix/sysv/linux/convert_scm_timestamps.c b/sysdeps/unix/sysv/linux/convert_scm_timestamps.c
> new file mode 100644
> index 0000000000..3c123c28ce
> --- /dev/null
> +++ b/sysdeps/unix/sysv/linux/convert_scm_timestamps.c
> @@ -0,0 +1,96 @@
> +/* Socket timestamp conversion routines.
> + Copyright (C) 2021 Free Software Foundation, Inc.
> + This file is part of the GNU C Library.
> +
> + The GNU C Library is free software; you can redistribute it and/or
> + modify it under the terms of the GNU Lesser General Public
> + License as published by the Free Software Foundation; either
> + version 2.1 of the License, or (at your option) any later version.
> +
> + The GNU C Library is distributed in the hope that it will be useful,
> + but WITHOUT ANY WARRANTY; without even the implied warranty of
> + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
> + Lesser General Public License for more details.
> +
> + You should have received a copy of the GNU Lesser General Public
> + License along with the GNU C Library; if not, see
> + <https://www.gnu.org/licenses/>. */
> +
> +#include <kernel-features.h>
> +
> +#ifndef __ASSUME_TIME64_SYSCALLS
> +# include <stdint.h>
> +# include <string.h>
> +# include <sys/socket.h>
> +# include <socket-constants-time64.h>
> +
> +/* It converts the first SO_TIMESTAMP or SO_TIMESTAMPNS with 32-bit time and
> + appends it to the control buffer. The 32-bit time field is kept as-is.
> +
> + Calls with __TIMESIZE=32 will see the converted 64-bit time control
> + messages as spurious control message of unknown type.
> +
> + Calls with __TIMESIZE=64 running on pre-time64 kernels will see the
> + original message as a spurious control ones of unknown typ while running
> + on kernel with native 64-bit time support will only see the time64 version
> + of the control message. */
> +void
> +__convert_scm_timestamps (struct msghdr *msg, socklen_t msgsize)
> +{
> + if (msg->msg_control == NULL || msg->msg_controllen == 0)
> + return;
> +
> + /* The returned control message format for SO_TIMESTAMP_NEW is a
> + 'struct __kernel_sock_timeval' while for SO_TIMESTAMPNS_NEW is a
> + 'struct __kernel_timespec'. In either case it is two uint64_t
> + members. */
> + uint64_t tvts[2];
> +
> + struct cmsghdr *cmsg, *last = NULL;
> + int type = 0;
> +
> + for (cmsg = CMSG_FIRSTHDR (msg);
> + cmsg != NULL;
> + cmsg = CMSG_NXTHDR (msg, cmsg))
> + {
> + if (cmsg->cmsg_level != SOL_SOCKET)
> + continue;
> +
> + switch (cmsg->cmsg_type)
> + {
> + case COMPAT_SO_TIMESTAMP_OLD:
> + if (type != 0)
> + break;
> + type = COMPAT_SO_TIMESTAMP_NEW;
> + goto common;
> +
> + case COMPAT_SO_TIMESTAMPNS_OLD:
> + type = COMPAT_SO_TIMESTAMPNS_NEW;
> +
> + /* fallthrough */
> + common:
> + memcpy (tvts, CMSG_DATA (cmsg), sizeof (tvts));
> + break;
> + }
> +
> + last = cmsg;
> + }
> +
> + if (last == NULL || type == 0)
> + return;
> +
> + if (CMSG_SPACE (sizeof tvts) > msgsize - msg->msg_controllen)
> + {
> + msg->msg_flags |= MSG_CTRUNC;
> + return;
> + }
> +
> + msg->msg_controllen += CMSG_SPACE (sizeof tvts);
> + cmsg = CMSG_NXTHDR(msg, last);
> + cmsg->cmsg_level = SOL_SOCKET;
> + cmsg->cmsg_type = type;
> + cmsg->cmsg_len = CMSG_LEN (sizeof tvts);
> + memcpy (CMSG_DATA (cmsg), tvts, sizeof tvts);
> +}
> +libc_hidden_def (__convert_scm_timestamps)
> +#endif
> diff --git a/sysdeps/unix/sysv/linux/getsockopt.c b/sysdeps/unix/sysv/linux/getsockopt.c
> index c8e502d976..14b782d0da 100644
> --- a/sysdeps/unix/sysv/linux/getsockopt.c
> +++ b/sysdeps/unix/sysv/linux/getsockopt.c
> @@ -67,6 +67,18 @@ getsockopt32 (int fd, int level, int optname, void *optval,
> *tv64 = valid_timeval32_to_timeval64 (tv32);
> *len = sizeof (*tv64);
> }
> + break;
> +
> + case COMPAT_SO_TIMESTAMP_NEW:
> + case COMPAT_SO_TIMESTAMPNS_NEW:
> + {
> + if (optname == COMPAT_SO_TIMESTAMP_NEW)
> + optname = COMPAT_SO_TIMESTAMP_OLD;
> + if (optname == COMPAT_SO_TIMESTAMPNS_NEW)
> + optname = COMPAT_SO_TIMESTAMPNS_OLD;
> + r = getsockopt_syscall (fd, level, optname, optval, len);
> + }
> + break;
> }
>
> return r;
> diff --git a/sysdeps/unix/sysv/linux/hppa/socket-constants-time64.h b/sysdeps/unix/sysv/linux/hppa/socket-constants-time64.h
> index ea721e0fc2..f3b98012d5 100644
> --- a/sysdeps/unix/sysv/linux/hppa/socket-constants-time64.h
> +++ b/sysdeps/unix/sysv/linux/hppa/socket-constants-time64.h
> @@ -27,4 +27,9 @@
> #define COMPAT_SO_RCVTIMEO_NEW 16448
> #define COMPAT_SO_SNDTIMEO_NEW 16449
>
> +#define COMPAT_SO_TIMESTAMP_OLD 0x4012
> +#define COMPAT_SO_TIMESTAMPNS_OLD 0x4013
> +#define COMPAT_SO_TIMESTAMP_NEW 0x4038
> +#define COMPAT_SO_TIMESTAMPNS_NEW 0x4039
> +
> #endif
> diff --git a/sysdeps/unix/sysv/linux/mips/socket-constants-time64.h b/sysdeps/unix/sysv/linux/mips/socket-constants-time64.h
> index ab8bd62853..31fa69fa9f 100644
> --- a/sysdeps/unix/sysv/linux/mips/socket-constants-time64.h
> +++ b/sysdeps/unix/sysv/linux/mips/socket-constants-time64.h
> @@ -27,4 +27,9 @@
> #define COMPAT_SO_RCVTIMEO_NEW 66
> #define COMPAT_SO_SNDTIMEO_NEW 67
>
> +#define COMPAT_SO_TIMESTAMP_OLD 29
> +#define COMPAT_SO_TIMESTAMPNS_OLD 35
> +#define COMPAT_SO_TIMESTAMP_NEW 63
> +#define COMPAT_SO_TIMESTAMPNS_NEW 64
> +
> #endif
> diff --git a/sysdeps/unix/sysv/linux/powerpc/socket-constants-time64.h b/sysdeps/unix/sysv/linux/powerpc/socket-constants-time64.h
> index 1e48dcca8d..889251895b 100644
> --- a/sysdeps/unix/sysv/linux/powerpc/socket-constants-time64.h
> +++ b/sysdeps/unix/sysv/linux/powerpc/socket-constants-time64.h
> @@ -27,4 +27,9 @@
> #define COMPAT_SO_RCVTIMEO_NEW 66
> #define COMPAT_SO_SNDTIMEO_NEW 67
>
> +#define COMPAT_SO_TIMESTAMP_OLD 29
> +#define COMPAT_SO_TIMESTAMPNS_OLD 35
> +#define COMPAT_SO_TIMESTAMP_NEW 63
> +#define COMPAT_SO_TIMESTAMPNS_NEW 64
> +
> #endif
> diff --git a/sysdeps/unix/sysv/linux/recvmsg.c b/sysdeps/unix/sysv/linux/recvmsg.c
> index b209b4ad99..a2a600228b 100644
> --- a/sysdeps/unix/sysv/linux/recvmsg.c
> +++ b/sysdeps/unix/sysv/linux/recvmsg.c
> @@ -19,16 +19,27 @@
> #include <sys/socket.h>
> #include <sysdep-cancel.h>
> #include <socketcall.h>
> -#include <shlib-compat.h>
>
> ssize_t
> __libc_recvmsg (int fd, struct msghdr *msg, int flags)
> {
> -# ifdef __ASSUME_RECVMSG_SYSCALL
> - return SYSCALL_CANCEL (recvmsg, fd, msg, flags);
> -# else
> - return SOCKETCALL_CANCEL (recvmsg, fd, msg, flags);
> -# endif
> + ssize_t r;
> +#ifndef __ASSUME_TIME64_SYSCALLS
> + socklen_t orig_controllen = msg->msg_controllen;
> +#endif
> +
> +#ifdef __ASSUME_RECVMSG_SYSCALL
> + r = SYSCALL_CANCEL (recvmsg, fd, msg, flags);
> +#else
> + r = SOCKETCALL_CANCEL (recvmsg, fd, msg, flags);
> +#endif
> +
> +#ifndef __ASSUME_TIME64_SYSCALLS
> + if (r >= 0)
> + __convert_scm_timestamps (msg, orig_controllen);
> +#endif
> +
> + return r;
> }
> weak_alias (__libc_recvmsg, recvmsg)
> weak_alias (__libc_recvmsg, __recvmsg)
> diff --git a/sysdeps/unix/sysv/linux/setsockopt.c b/sysdeps/unix/sysv/linux/setsockopt.c
> index 6505202265..a4780a9d33 100644
> --- a/sysdeps/unix/sysv/linux/setsockopt.c
> +++ b/sysdeps/unix/sysv/linux/setsockopt.c
> @@ -69,6 +69,18 @@ setsockopt32 (int fd, int level, int optname, const void *optval,
>
> r = setsockopt_syscall (fd, level, optname, &tv32, sizeof (tv32));
> }
> + break;
> +
> + case COMPAT_SO_TIMESTAMP_NEW:
> + case COMPAT_SO_TIMESTAMPNS_NEW:
> + {
> + if (optname == COMPAT_SO_TIMESTAMP_NEW)
> + optname = COMPAT_SO_TIMESTAMP_OLD;
> + if (optname == COMPAT_SO_TIMESTAMPNS_NEW)
> + optname = COMPAT_SO_TIMESTAMPNS_OLD;
> + r = setsockopt_syscall (fd, level, optname, NULL, 0);
> + }
> + break;
> }
>
> return r;
> diff --git a/sysdeps/unix/sysv/linux/socket-constants-time64.h b/sysdeps/unix/sysv/linux/socket-constants-time64.h
> index e5a3777f28..7f7ca05504 100644
> --- a/sysdeps/unix/sysv/linux/socket-constants-time64.h
> +++ b/sysdeps/unix/sysv/linux/socket-constants-time64.h
> @@ -27,4 +27,9 @@
> #define COMPAT_SO_RCVTIMEO_NEW 66
> #define COMPAT_SO_SNDTIMEO_NEW 67
>
> +#define COMPAT_SO_TIMESTAMP_OLD 29
> +#define COMPAT_SO_TIMESTAMPNS_OLD 35
> +#define COMPAT_SO_TIMESTAMP_NEW 63
> +#define COMPAT_SO_TIMESTAMPNS_NEW 64
> +
> #endif
> diff --git a/sysdeps/unix/sysv/linux/sparc/socket-constants-time64.h b/sysdeps/unix/sysv/linux/sparc/socket-constants-time64.h
> index b137abdeea..56358923e1 100644
> --- a/sysdeps/unix/sysv/linux/sparc/socket-constants-time64.h
> +++ b/sysdeps/unix/sysv/linux/sparc/socket-constants-time64.h
> @@ -27,4 +27,9 @@
> #define COMPAT_SO_RCVTIMEO_NEW 68
> #define COMPAT_SO_SNDTIMEO_NEW 69
>
> +#define COMPAT_SO_TIMESTAMP_OLD 0x001d
> +#define COMPAT_SO_TIMESTAMPNS_OLD 0x0021
> +#define COMPAT_SO_TIMESTAMP_NEW 0x0046
> +#define COMPAT_SO_TIMESTAMPNS_NEW 0x0042
> +
> #endif
>
--
Cheers,
Carlos.
next prev parent reply other threads:[~2021-06-04 19:30 UTC|newest]
Thread overview: 92+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-18 20:55 [PATCH v2 00/25] Add 64 bit time support on legacy ABIs Adhemerval Zanella
2021-05-18 20:55 ` [PATCH v2 01/25] linux: mips: Split libpthread.abilist in n32 and n64 Adhemerval Zanella
2021-05-19 8:24 ` Lukasz Majewski
2021-05-20 6:38 ` Florian Weimer
2021-05-20 10:43 ` Adhemerval Zanella
2021-06-04 19:29 ` Carlos O'Donell
2021-05-18 20:55 ` [PATCH v2 02/25] linux: mips: Split librt.abilist " Adhemerval Zanella
2021-05-19 8:25 ` Lukasz Majewski
2021-06-04 19:29 ` Carlos O'Donell
2021-05-18 20:55 ` [PATCH v2 03/25] linux: mips: Split libanl.abilist " Adhemerval Zanella
2021-05-19 8:25 ` Lukasz Majewski
2021-06-04 19:30 ` Carlos O'Donell
2021-05-18 20:55 ` [PATCH v2 04/25] linux: s390: Add libanl.abilist in s390 and s390x Adhemerval Zanella
2021-05-19 8:26 ` Lukasz Majewski
2021-06-04 19:30 ` Carlos O'Donell
2021-05-18 20:55 ` [PATCH v2 05/25] linux: Add fallback for 64-bit time_t SO_{RCV, SND}TIMEO Adhemerval Zanella
2021-05-19 8:36 ` [PATCH v2 05/25] linux: Add fallback for 64-bit time_t SO_{RCV,SND}TIMEO Lukasz Majewski
2021-05-20 6:44 ` [PATCH v2 05/25] linux: Add fallback for 64-bit time_t SO_{RCV, SND}TIMEO Florian Weimer
2021-05-20 18:01 ` Adhemerval Zanella
2021-05-21 18:37 ` Florian Weimer
2021-05-21 19:17 ` Adhemerval Zanella
2021-06-04 19:30 ` [PATCH v2 05/25] linux: Add fallback for 64-bit time_t SO_{RCV,SND}TIMEO Carlos O'Donell
2021-06-07 17:52 ` Adhemerval Zanella
2021-05-18 20:55 ` [PATCH v2 06/25] linux: Add fallback for 64-bit time_t SO_TIMESTAMP{NS} Adhemerval Zanella
2021-05-19 8:50 ` Lukasz Majewski
2021-05-20 6:50 ` Florian Weimer
2021-05-20 18:46 ` Adhemerval Zanella
2021-05-21 18:38 ` Florian Weimer
2021-05-21 19:02 ` Adhemerval Zanella
2021-06-04 19:30 ` Carlos O'Donell [this message]
2021-05-18 20:55 ` [PATCH v2 07/25] linux: Add recvvmsg " Adhemerval Zanella
2021-05-19 9:02 ` Lukasz Majewski
2021-06-04 19:30 ` Carlos O'Donell
2021-05-18 20:55 ` [PATCH v2 08/25] y2038: Add __USE_TIME_BITS64 support for time_t Adhemerval Zanella
2021-05-19 9:02 ` Lukasz Majewski
2021-06-04 19:30 ` Carlos O'Donell
2021-05-18 20:55 ` [PATCH v2 09/25] y2038: Add __USE_TIME_BITS64 support for struct timeval Adhemerval Zanella
2021-05-19 9:03 ` Lukasz Majewski
2021-06-04 19:31 ` Carlos O'Donell
2021-05-18 20:55 ` [PATCH v2 10/25] y2038: Add __USE_TIME_BITS64 support for struct timespec Adhemerval Zanella
2021-05-19 9:03 ` Lukasz Majewski
2021-06-04 19:31 ` Carlos O'Donell
2021-05-18 20:55 ` [PATCH v2 11/25] y2038: Add __USE_TIME_BITS64 support for struct utimbuf Adhemerval Zanella
2021-05-19 9:04 ` Lukasz Majewski
2021-06-04 19:31 ` Carlos O'Donell
2021-05-18 20:56 ` [PATCH v2 12/25] y2038: linux: Add __USE_TIME_BITS64 support for struct timex Adhemerval Zanella
2021-05-19 9:04 ` Lukasz Majewski
2021-06-04 19:31 ` Carlos O'Donell
2021-05-18 20:56 ` [PATCH v2 13/25] y2038: Use a common definition for stat Adhemerval Zanella
2021-06-04 19:37 ` Carlos O'Donell
2021-06-07 18:07 ` Adhemerval Zanella
2021-05-18 20:56 ` [PATCH v2 14/25] y2038: Use a common definition for msqid_ds Adhemerval Zanella
2021-06-04 19:38 ` Carlos O'Donell
2021-06-07 18:29 ` Adhemerval Zanella
2021-05-18 20:56 ` [PATCH v2 15/25] y2038: Use a common definition for semid_ds Adhemerval Zanella
2021-05-19 9:09 ` Lukasz Majewski
2021-06-04 19:38 ` Carlos O'Donell
2021-06-07 18:46 ` Adhemerval Zanella
2021-05-18 20:56 ` [PATCH v2 16/25] y2038: Use a common definition for shmid_ds Adhemerval Zanella
2021-05-19 9:09 ` Lukasz Majewski
2021-06-04 19:38 ` Carlos O'Donell
2021-05-18 20:56 ` [PATCH v2 17/25] y2038: Add __USE_TIME_BITS64 support for socket-constants.h Adhemerval Zanella
2021-05-19 9:13 ` Lukasz Majewski
2021-06-04 19:38 ` Carlos O'Donell
2021-05-18 20:56 ` [PATCH v2 18/25] time: Add 64 bit time support for getdate Adhemerval Zanella
2021-05-19 9:15 ` Lukasz Majewski
2021-06-04 19:38 ` Carlos O'Donell
2021-05-18 20:56 ` [PATCH v2 19/25] y2038: Add support for 64 bit time on legacy ABIs Adhemerval Zanella
2021-05-19 9:18 ` Lukasz Majewski
2021-05-20 6:58 ` Florian Weimer
2021-05-20 10:37 ` Adhemerval Zanella
2021-06-04 19:38 ` Carlos O'Donell
2021-05-18 20:56 ` [PATCH v2 20/25] posix: Add glob64 with 64 bit time_t support Adhemerval Zanella
2021-05-19 10:44 ` Lukasz Majewski
2021-06-04 19:39 ` Carlos O'Donell
2021-06-07 18:52 ` Adhemerval Zanella
2021-05-18 20:56 ` [PATCH v2 21/25] io: Add fts64 " Adhemerval Zanella
2021-05-19 10:50 ` Lukasz Majewski
2021-06-04 19:39 ` Carlos O'Donell
2021-05-18 20:56 ` [PATCH v2 22/25] io: Add ftw64 " Adhemerval Zanella
2021-05-19 10:57 ` Lukasz Majewski
2021-06-04 19:39 ` Carlos O'Donell
2021-05-18 20:56 ` [PATCH v2 23/25] libsupport: Add 64 bit time_t support for time functions Adhemerval Zanella
2021-05-19 11:00 ` Lukasz Majewski
2021-06-04 19:39 ` Carlos O'Donell
2021-05-18 20:56 ` [PATCH v2 24/25] libsupport: Add 64 bit time_t support for stat functions Adhemerval Zanella
2021-05-19 11:04 ` Lukasz Majewski
2021-06-04 19:39 ` Carlos O'Donell
2021-05-18 20:56 ` [PATCH v2 25/25] y2038: Add test coverage Adhemerval Zanella
2021-05-19 11:08 ` Lukasz Majewski
2021-06-04 19:39 ` Carlos O'Donell
2021-06-04 19:29 ` [PATCH v2 00/25] Add 64 bit time support on legacy ABIs Carlos O'Donell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=710517d3-821f-49a3-3fd9-cbf1cb20ce84@redhat.com \
--to=carlos@redhat.com \
--cc=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).