* [PATCH] x86: Add tst-get-cpu-features-static to $(tests) [BZ #23458]
@ 2018-07-27 20:38 H.J. Lu
2018-07-27 21:14 ` Florian Weimer
0 siblings, 1 reply; 5+ messages in thread
From: H.J. Lu @ 2018-07-27 20:38 UTC (permalink / raw)
To: libc-alpha
All tests should be added to $(tests) and all static tests should be
added to $(tests-static).
[BZ #23458]
* sysdeps/x86/Makefile (tests): Add tst-get-cpu-features-static.
---
sysdeps/x86/Makefile | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/sysdeps/x86/Makefile b/sysdeps/x86/Makefile
index 672bb19489..85086b1410 100644
--- a/sysdeps/x86/Makefile
+++ b/sysdeps/x86/Makefile
@@ -5,7 +5,9 @@ endif
ifeq ($(subdir),elf)
sysdep-dl-routines += dl-get-cpu-features
-tests += tst-get-cpu-features
+# NB: All tests should be added to $(tests) and all static tests should
+# be added to $(tests-static).
+tests += tst-get-cpu-features tst-get-cpu-features-static
tests-static += tst-get-cpu-features-static
endif
--
2.17.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] x86: Add tst-get-cpu-features-static to $(tests) [BZ #23458]
2018-07-27 20:38 [PATCH] x86: Add tst-get-cpu-features-static to $(tests) [BZ #23458] H.J. Lu
@ 2018-07-27 21:14 ` Florian Weimer
2018-07-27 21:41 ` H.J. Lu
0 siblings, 1 reply; 5+ messages in thread
From: Florian Weimer @ 2018-07-27 21:14 UTC (permalink / raw)
To: H.J. Lu, libc-alpha
On 07/27/2018 10:38 PM, H.J. Lu wrote:
> -tests += tst-get-cpu-features
> +# NB: All tests should be added to $(tests) and all static tests should
> +# be added to $(tests-static).
> +tests += tst-get-cpu-features tst-get-cpu-features-static
Why the comment? What makes this instance so special to warrant one?
Thanks,
Florian
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] x86: Add tst-get-cpu-features-static to $(tests) [BZ #23458]
2018-07-27 21:14 ` Florian Weimer
@ 2018-07-27 21:41 ` H.J. Lu
2018-07-29 14:20 ` V2 " H.J. Lu
0 siblings, 1 reply; 5+ messages in thread
From: H.J. Lu @ 2018-07-27 21:41 UTC (permalink / raw)
To: Florian Weimer; +Cc: GNU C Library
On Fri, Jul 27, 2018 at 2:14 PM, Florian Weimer <fweimer@redhat.com> wrote:
> On 07/27/2018 10:38 PM, H.J. Lu wrote:
>>
>> -tests += tst-get-cpu-features
>> +# NB: All tests should be added to $(tests) and all static tests should
>> +# be added to $(tests-static).
>> +tests += tst-get-cpu-features tst-get-cpu-features-static
>
>
> Why the comment? What makes this instance so special to warrant one?
>
I can take out the comment.
--
H.J.
^ permalink raw reply [flat|nested] 5+ messages in thread
* V2 [PATCH] x86: Add tst-get-cpu-features-static to $(tests) [BZ #23458]
2018-07-27 21:41 ` H.J. Lu
@ 2018-07-29 14:20 ` H.J. Lu
2018-07-30 20:34 ` Carlos O'Donell
0 siblings, 1 reply; 5+ messages in thread
From: H.J. Lu @ 2018-07-29 14:20 UTC (permalink / raw)
To: Florian Weimer, GNU C Library
On Fri, Jul 27, 2018 at 02:41:23PM -0700, H.J. Lu wrote:
> On Fri, Jul 27, 2018 at 2:14 PM, Florian Weimer <fweimer@redhat.com> wrote:
> > On 07/27/2018 10:38 PM, H.J. Lu wrote:
> >>
> >> -tests += tst-get-cpu-features
> >> +# NB: All tests should be added to $(tests) and all static tests should
> >> +# be added to $(tests-static).
> >> +tests += tst-get-cpu-features tst-get-cpu-features-static
> >
> >
> > Why the comment? What makes this instance so special to warrant one?
> >
>
> I can take out the comment.
>
Here is the updated patch. OK for master?
Thanks.
H.J.
---
All tests should be added to $(tests).
[BZ #23458]
* sysdeps/x86/Makefile (tests): Add tst-get-cpu-features-static.
---
sysdeps/x86/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sysdeps/x86/Makefile b/sysdeps/x86/Makefile
index 672bb19489..337b0b63dc 100644
--- a/sysdeps/x86/Makefile
+++ b/sysdeps/x86/Makefile
@@ -5,7 +5,7 @@ endif
ifeq ($(subdir),elf)
sysdep-dl-routines += dl-get-cpu-features
-tests += tst-get-cpu-features
+tests += tst-get-cpu-features tst-get-cpu-features-static
tests-static += tst-get-cpu-features-static
endif
--
2.17.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: V2 [PATCH] x86: Add tst-get-cpu-features-static to $(tests) [BZ #23458]
2018-07-29 14:20 ` V2 " H.J. Lu
@ 2018-07-30 20:34 ` Carlos O'Donell
0 siblings, 0 replies; 5+ messages in thread
From: Carlos O'Donell @ 2018-07-30 20:34 UTC (permalink / raw)
To: H.J. Lu, Florian Weimer, GNU C Library
On 07/29/2018 10:19 AM, H.J. Lu wrote:
> On Fri, Jul 27, 2018 at 02:41:23PM -0700, H.J. Lu wrote:
>> On Fri, Jul 27, 2018 at 2:14 PM, Florian Weimer <fweimer@redhat.com> wrote:
>>> On 07/27/2018 10:38 PM, H.J. Lu wrote:
>>>>
>>>> -tests += tst-get-cpu-features
>>>> +# NB: All tests should be added to $(tests) and all static tests should
>>>> +# be added to $(tests-static).
>>>> +tests += tst-get-cpu-features tst-get-cpu-features-static
>>>
>>>
>>> Why the comment? What makes this instance so special to warrant one?
>>>
>>
>> I can take out the comment.
>>
>
> Here is the updated patch. OK for master?
OK for master.
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
> Thanks.
>
> H.J.
> ---
> All tests should be added to $(tests).
>
> [BZ #23458]
> * sysdeps/x86/Makefile (tests): Add tst-get-cpu-features-static.
> ---
> sysdeps/x86/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sysdeps/x86/Makefile b/sysdeps/x86/Makefile
> index 672bb19489..337b0b63dc 100644
> --- a/sysdeps/x86/Makefile
> +++ b/sysdeps/x86/Makefile
> @@ -5,7 +5,7 @@ endif
> ifeq ($(subdir),elf)
> sysdep-dl-routines += dl-get-cpu-features
>
> -tests += tst-get-cpu-features
> +tests += tst-get-cpu-features tst-get-cpu-features-static
> tests-static += tst-get-cpu-features-static
> endif
>
>
--
Cheers,
Carlos.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-07-30 20:34 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-27 20:38 [PATCH] x86: Add tst-get-cpu-features-static to $(tests) [BZ #23458] H.J. Lu
2018-07-27 21:14 ` Florian Weimer
2018-07-27 21:41 ` H.J. Lu
2018-07-29 14:20 ` V2 " H.J. Lu
2018-07-30 20:34 ` Carlos O'Donell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).