From: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>
To: Florian Weimer <fweimer@redhat.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] posix: Make posix_spawn extensions available by default
Date: Fri, 4 Nov 2022 09:26:43 -0300 [thread overview]
Message-ID: <78b07982-0bee-074a-e491-ab3d844c68f8@linaro.org> (raw)
In-Reply-To: <8735ay2a4h.fsf@oldenburg.str.redhat.com>
On 04/11/22 09:10, Florian Weimer wrote:
> * Adhemerval Zanella Netto:
>
>> On 04/11/22 04:15, Florian Weimer via Libc-alpha wrote:
>>> Some sources merely include <spawn.h> without -D_GNU_SOURCE and expect
>>> declarations for posix_spawn_file_actions_addchdir_np to be available.
>>>
>>> Tested on x86_64-linux-gnu.
>>>
>>
>> LGTM, although you reference posix_spawn_file_actions_addchdir_np on commit
>> message, but you export posix_spawn_file_actions_addtcsetpgrp_np.
>
> Sorry, there are multiple functions that are now available by default.
> I encountered the problem just with posix_spawn_file_actions_addchdir_np,
> so I still think the commit message is correct.
I would advise cite all the function affected then, because with only
posix_spawn_file_actions_addchdir_np on commit message it might seems that
the patch is exporting more than intended.
Patch looks ok though.
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
next prev parent reply other threads:[~2022-11-04 12:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-04 7:15 Florian Weimer
2022-11-04 12:04 ` Adhemerval Zanella Netto
2022-11-04 12:10 ` Florian Weimer
2022-11-04 12:26 ` Adhemerval Zanella Netto [this message]
2022-11-06 21:26 ` Sam James
2022-11-07 16:10 ` Florian Weimer
2022-11-08 0:05 ` Sam James
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=78b07982-0bee-074a-e491-ab3d844c68f8@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).