Re: [PATCH] posix: Make posix_spawn extensions available by default

[Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>]

On 04/11/22 04:15, Florian Weimer via Libc-alpha wrote:
> Some sources merely include <spawn.h> without -D_GNU_SOURCE and expect
> declarations for posix_spawn_file_actions_addchdir_np to be available.
> 
> Tested on x86_64-linux-gnu.
> 

LGTM, although you reference posix_spawn_file_actions_addchdir_np on commit
message, but you export posix_spawn_file_actions_addtcsetpgrp_np.

> ---
>  posix/spawn.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/posix/spawn.h b/posix/spawn.h
> index c4a81227b0..f3bcbc56be 100644
> --- a/posix/spawn.h
> +++ b/posix/spawn.h
> @@ -198,7 +198,7 @@ extern int posix_spawn_file_actions_adddup2 (posix_spawn_file_actions_t *
>  					     int __fd, int __newfd)
>       __THROW __nonnull ((1));
>  
> -#ifdef __USE_GNU
> +#ifdef __USE_MISC
>  /* Add an action changing the directory to PATH during spawn.  This
>     affects the subsequent file actions.  */
>  extern int posix_spawn_file_actions_addchdir_np (posix_spawn_file_actions_t *
> @@ -227,7 +227,7 @@ posix_spawn_file_actions_addtcsetpgrp_np (posix_spawn_file_actions_t *,
>  					  int __tcfd)
>       __THROW __nonnull ((1));
>  
> -#endif
> +#endif /* __USE_MISC */
>  
>  __END_DECLS
>  
> 
> base-commit: faaf733f49211439475e50f06716b303ee2644bf
>