Re: [PATCH] posix: Make posix_spawn extensions available by default

[Florian Weimer <fweimer@redhat.com>]

* Sam James:

>> On 4 Nov 2022, at 12:26, Adhemerval Zanella Netto via Libc-alpha <libc-alpha@sourceware.org> wrote:
>> 
>> 
>> 
>> On 04/11/22 09:10, Florian Weimer wrote:
>>> * Adhemerval Zanella Netto:
>>> 
>>>> On 04/11/22 04:15, Florian Weimer via Libc-alpha wrote:
>>>>> Some sources merely include <spawn.h> without -D_GNU_SOURCE and expect
>>>>> declarations for posix_spawn_file_actions_addchdir_np to be available.
>>>>> 
>>>>> Tested on x86_64-linux-gnu.
>>>>> 
>>>> 
>>>> LGTM, although you reference posix_spawn_file_actions_addchdir_np on commit
>>>> message, but you export posix_spawn_file_actions_addtcsetpgrp_np.
>>> 
>>> Sorry, there are multiple functions that are now available by default.
>>> I encountered the problem just with posix_spawn_file_actions_addchdir_np,
>>> so I still think the commit message is correct.
>> 
>> I would advise cite all the function affected then, because with only
>> posix_spawn_file_actions_addchdir_np on commit message it might seems that
>> the patch is exporting more than intended.
>> 
>
> Agreed. I'm a little bit uneasy given this ends up masking some
> problems and then we're back to having to only fix them on musl
> systems, but if this is the only function not exposed and the logic
> already applies to the others, I guess it's fine.

I have submitted a fix to the application as well:

  Build process.c with _GNU_SOURCE
  <https://github.com/apple/swift-tools-support-core/pull/363>

But I think the glibc change makes sense independently of that.

Thanks,
Florian