From: Florian Weimer <fweimer@redhat.com>
To: Joan Bruguera via Libc-alpha <libc-alpha@sourceware.org>
Cc: Joan Bruguera <joanbrugueram@gmail.com>, adhemerval.zanella@linaro.org
Subject: Re: [PATCH] elf: Restore lconfig libc6 implicit soname logic [BZ #30125]
Date: Thu, 16 Feb 2023 07:01:59 +0100 [thread overview]
Message-ID: <871qmqrvvs.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <20230216022355.3954438-1-joanbrugueram@gmail.com> (Joan Bruguera via Libc-alpha's message of "Thu, 16 Feb 2023 02:23:55 +0000")
* Joan Bruguera via Libc-alpha:
>>>
>>>> Signed-off-by: Joan Bruguera <joanbrugueram@gmail.com>
>>>
>>> We do not signed-off-by on glibc, so no need for it.
>>>
>>
>> https://sourceware.org/glibc/wiki/Contribution%20checklist#Developer_Certificate_of_Origin says we do?
>
> Hmmm, indeed, after re-re-reviewing this document, I understand (hopefully
> correctly) that I indeed *must* include the Signed-off-by header, as I am not
> covered by a copyright assignment to the FSF.
Yes, that's true.
> I have submitted a v3 adding the Signed-off-by as well as a
> "Copyright The GNU Toolchain Authors." header to the new test,
> additionally to a "Copyright (C) 2000-2023 Free Software Foundation, Inc."
> (as the test structure is based on tst-ldconfig-X.sh.)
> Apologies if *not* adding the "Copyright The GNU Toolchain Authors." header in
> the previous mail made the reviewer think I was covered by a FSF assignment.
That's what I've been doing in similar cases. Thanks for the attention
to detail.
Florian
next prev parent reply other threads:[~2023-02-16 6:02 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-15 1:41 Joan Bruguera
2023-02-15 1:47 ` Joan Bruguera
2023-02-15 13:19 ` Adhemerval Zanella Netto
2023-02-16 1:29 ` Joan Bruguera
2023-02-16 1:40 ` Sam James
2023-02-16 2:23 ` [PATCH v3] elf: Restore ldconfig " Joan Bruguera
2023-02-16 6:08 ` Florian Weimer
2023-02-16 2:23 ` [PATCH] elf: Restore lconfig " Joan Bruguera
2023-02-16 6:01 ` Florian Weimer [this message]
2023-02-16 1:24 ` [PATCH v2] elf: Restore ldconfig " Joan Bruguera
2023-02-16 2:08 ` [PATCH v3] " Joan Bruguera
2023-02-18 21:52 ` [PATCH v4] " Joan Bruguera
2023-02-20 12:32 ` Adhemerval Zanella Netto
2023-02-20 13:21 ` Florian Weimer
2023-02-20 13:55 ` Adhemerval Zanella Netto
2023-02-20 14:04 ` Florian Weimer
2023-02-20 14:26 ` Adhemerval Zanella Netto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871qmqrvvs.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=adhemerval.zanella@linaro.org \
--cc=joanbrugueram@gmail.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).