Re: [PATCH v4] elf: Restore ldconfig libc6 implicit soname logic [BZ #30125]

[Florian Weimer <fweimer@redhat.com>]

* Adhemerval Zanella Netto via Libc-alpha:

> On 18/02/23 18:52, Joan Bruguera wrote:
>> While cleaning up old libc version support, the deprecated libc4 code was
>> accidentally kept in `implicit_soname`, instead of the libc6 code.
>> 
>> This causes additional symlinks to be created by `ldconfig` for libraries
>> without a soname, e.g. a library `libsomething.123.456.789` without a soname
>> will create a `libsomething.123` -> `libsomething.123.456.789` symlink.
>> 
>> As the libc6 version of the `implicit_soname` code is a trivial `xstrdup`,
>> just inline it and remove `implicit_soname` altogether.
>> 
>> Some further simplification looks possible (e.g. the call to `create_links`
>> looks like a no-op if `soname == NULL`, other than the verbose printfs), but
>> logic is kept as-is for now.
>> 
>> Fixes: BZ #30125
>> Fixes: 8ee878592c4a ("Assume only FLAG_ELF_LIBC6 suport")
>> Signed-off-by: Joan Bruguera <joanbrugueram@gmail.com>
>
> LGTM, thanks.
>
> Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>

Reviewed-by: Florian Weimer <fweimer@redhat.com>

Are you going to push & backport this to glibc 2.37?

Thanks,
Florian