From: Andreas Schwab <schwab@linux-m68k.org>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: Florian Weimer <fw@deneb.enyo.de>,
"H.J. Lu via Libc-alpha" <libc-alpha@sourceware.org>
Subject: Re: V2 [PATCH] Add a C wrapper for prctl [BZ #25896]
Date: Thu, 30 Apr 2020 16:04:54 +0200 [thread overview]
Message-ID: <878sidgjcp.fsf@igel.home> (raw)
In-Reply-To: <CAMe9rOrbAmipEAKtr-uZvbZxS8BQ1y0s=QjBE=Oc2iS8-w+1kA@mail.gmail.com> (H. J. Lu's message of "Thu, 30 Apr 2020 06:53:51 -0700")
On Apr 30 2020, H.J. Lu wrote:
> On Thu, Apr 30, 2020 at 6:51 AM Andreas Schwab <schwab@linux-m68k.org> wrote:
>>
>> On Apr 30 2020, Florian Weimer wrote:
>>
>> > * Andreas Schwab:
>> >
>> >> On Apr 30 2020, H.J. Lu via Libc-alpha wrote:
>> >>
>> >>> diff --git a/include/sys/prctl.h b/include/sys/prctl.h
>> >>> index 0920ed642b..1a74d83879 100644
>> >>> --- a/include/sys/prctl.h
>> >>> +++ b/include/sys/prctl.h
>> >>> @@ -4,6 +4,8 @@
>> >>> # ifndef _ISOMAC
>> >>>
>> >>> extern int __prctl (int __option, ...);
>> >>> +libc_hidden_proto (__prctl)
>> >>> +libc_hidden_proto (prctl)
>> >>
>> >> Why do you need the hidden alias for prctl? All references inside
>> >> libc.so should use __prctl.
>> >
>> > Right. I want to clean this up in a separate patch.
>>
>> ??? Why adding it in the first place?
>>
>> Andreas.
>>
>
> It was there before my patch:
That doesn't matter, the syscall template adds it blindly to all names.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
next prev parent reply other threads:[~2020-04-30 14:04 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-29 20:52 H.J. Lu
2020-04-30 7:26 ` Florian Weimer
2020-04-30 13:03 ` V2 " H.J. Lu
2020-04-30 13:41 ` Andreas Schwab
2020-04-30 13:43 ` Florian Weimer
2020-04-30 13:50 ` H.J. Lu
2020-04-30 13:51 ` Andreas Schwab
2020-04-30 13:53 ` H.J. Lu
2020-04-30 14:04 ` Andreas Schwab [this message]
2020-04-30 15:27 ` V3 " H.J. Lu
2020-04-30 16:53 ` Florian Weimer
2020-04-30 17:20 ` [PATCH] Add a " H.J. Lu
2020-04-30 20:01 ` V3 [PATCH] Add a C " Florian Weimer
2022-11-10 8:33 ` Florian Weimer
2022-11-10 11:49 ` Adhemerval Zanella Netto
2022-11-10 12:03 ` Florian Weimer
2022-11-10 12:25 ` Adhemerval Zanella Netto
2022-11-10 13:17 ` Florian Weimer
2020-04-30 13:54 ` V2 " Florian Weimer
2020-04-30 14:51 ` Adhemerval Zanella
2020-04-30 16:35 ` H.J. Lu
2020-04-30 16:51 ` Florian Weimer
2020-04-30 17:24 ` Adhemerval Zanella
2020-04-30 17:29 ` V4 " H.J. Lu
[not found] ` <c2a821bf-fd2a-0ed9-2ad9-c4bd1231b2a7@linux.ibm.com>
[not found] ` <CAMe9rOq60aAKujxFF=bSyN5yPZVWSa-KWKWXKHpB8uOKu5V-7w@mail.gmail.com>
2020-04-30 22:57 ` Bad LOADARGS_N on PPC H.J. Lu
2020-05-01 2:03 ` Tulio Magno Quites Machado Filho
2020-05-01 2:18 ` [PATCH] powerpc: Rename argN to _argN in LOADARGS_N [BZ #25902] H.J. Lu
2020-05-01 23:11 ` Please test: [2.31/2.30] " H.J. Lu
2020-05-04 16:00 ` Matheus Castanho
2020-05-04 19:11 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878sidgjcp.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=fw@deneb.enyo.de \
--cc=hjl.tools@gmail.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).