From: Florian Weimer <fw@deneb.enyo.de>
To: "H.J. Lu via Libc-alpha" <libc-alpha@sourceware.org>
Cc: Andreas Schwab <schwab@linux-m68k.org>, "H.J. Lu" <hjl.tools@gmail.com>
Subject: Re: V3 [PATCH] Add a C wrapper for prctl [BZ #25896]
Date: Thu, 30 Apr 2020 18:53:31 +0200 [thread overview]
Message-ID: <87wo5w7w50.fsf@mid.deneb.enyo.de> (raw)
In-Reply-To: <CAMe9rOok1_-PuzwExk+XZJ_KyE01keNstYAGS9GR9gn6GFHxvg@mail.gmail.com> (H. J. Lu via Libc-alpha's message of "Thu, 30 Apr 2020 08:27:59 -0700")
* H. J. Lu via Libc-alpha:
> From ee8672af3ef5f3db438c0abb39b2673944181292 Mon Sep 17 00:00:00 2001
> From: "H.J. Lu" <hjl.tools@gmail.com>
> Date: Wed, 29 Apr 2020 07:38:49 -0700
> Subject: [PATCH] Add a C wrapper for prctl [BZ #25896]
>
> Add a C wrapper to pass arguments in
The commit message is only correct if you drop the .S files.
> /* Control process execution. */
> extern int prctl (int __option, ...) __THROW;
>
> to prctl syscall:
>
> extern int prctl (int, unsigned long int, unsigned long int,
> unsigned long int, unsigned long int);
>
> On Linux/x86, since the prctl syscall interface:
>
> extern int prctl (int, unsigned long int, unsigned long int,
> unsigned long int, unsigned long int);
>
> and the glibc prctl interface:
>
> extern int prctl (int option, ...);
>
> pass the arguments identically, the assembly verion:
>
> PSEUDO (__prctl, prctl, 5)
> ret
> PSEUDO_END (__prctl)
>
> is used.
Doesn't x86 include x32?
Apart from these nits, the patch looks good. Please settle the matter
of the .S files with Adhemerval. 8-)
next prev parent reply other threads:[~2020-04-30 16:53 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-29 20:52 H.J. Lu
2020-04-30 7:26 ` Florian Weimer
2020-04-30 13:03 ` V2 " H.J. Lu
2020-04-30 13:41 ` Andreas Schwab
2020-04-30 13:43 ` Florian Weimer
2020-04-30 13:50 ` H.J. Lu
2020-04-30 13:51 ` Andreas Schwab
2020-04-30 13:53 ` H.J. Lu
2020-04-30 14:04 ` Andreas Schwab
2020-04-30 15:27 ` V3 " H.J. Lu
2020-04-30 16:53 ` Florian Weimer [this message]
2020-04-30 17:20 ` [PATCH] Add a " H.J. Lu
2020-04-30 20:01 ` V3 [PATCH] Add a C " Florian Weimer
2022-11-10 8:33 ` Florian Weimer
2022-11-10 11:49 ` Adhemerval Zanella Netto
2022-11-10 12:03 ` Florian Weimer
2022-11-10 12:25 ` Adhemerval Zanella Netto
2022-11-10 13:17 ` Florian Weimer
2020-04-30 13:54 ` V2 " Florian Weimer
2020-04-30 14:51 ` Adhemerval Zanella
2020-04-30 16:35 ` H.J. Lu
2020-04-30 16:51 ` Florian Weimer
2020-04-30 17:24 ` Adhemerval Zanella
2020-04-30 17:29 ` V4 " H.J. Lu
[not found] ` <c2a821bf-fd2a-0ed9-2ad9-c4bd1231b2a7@linux.ibm.com>
[not found] ` <CAMe9rOq60aAKujxFF=bSyN5yPZVWSa-KWKWXKHpB8uOKu5V-7w@mail.gmail.com>
2020-04-30 22:57 ` Bad LOADARGS_N on PPC H.J. Lu
2020-05-01 2:03 ` Tulio Magno Quites Machado Filho
2020-05-01 2:18 ` [PATCH] powerpc: Rename argN to _argN in LOADARGS_N [BZ #25902] H.J. Lu
2020-05-01 23:11 ` Please test: [2.31/2.30] " H.J. Lu
2020-05-04 16:00 ` Matheus Castanho
2020-05-04 19:11 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wo5w7w50.fsf@mid.deneb.enyo.de \
--to=fw@deneb.enyo.de \
--cc=hjl.tools@gmail.com \
--cc=libc-alpha@sourceware.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).