public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: "Arsen Arsenović" <arsen@gentoo.org>
Cc: libc-alpha@sourceware.org,  carlos@redhat.com,  toolchain@gentoo.org
Subject: Re: [PATCH v3 1/2] elf,nptl: Add -z lazy to some more tests
Date: Tue, 07 Mar 2023 12:42:11 +0100	[thread overview]
Message-ID: <87fsagpz3g.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <20230307102935.2882450-1-arsen@gentoo.org> ("Arsen =?utf-8?Q?Arsenovi=C4=87=22's?= message of "Tue, 7 Mar 2023 11:29:34 +0100")

* Arsen Arsenović:

> Some toolchains, such as that used on Gentoo Hardened, set -z now out of
> the box.  This trips up a couple of tests.
> ---
> Hi,
>
> This is re-roll of the following patch series:
> https://inbox.sourceware.org/libc-alpha/20230307003222.2810662-1-arsen@aarsen.me/
> https://inbox.sourceware.org/libc-alpha/20230302112519.914641-1-arsen@gentoo.org/
>
> Changes from v2:
> - Split off the +$(objpfx)resolvfail.out: $(objpfx)testobj1.so change
>   into its own commit.
>
> Changes from v1:
> - Dropped -z norelro.  This turned out to be unnecessary after
>   Adhemervals removal of --with-default-link and linker script
>   machinery:
>   https://patchwork.sourceware.org/project/glibc/list/?series=17843
>   See: https://inbox.sourceware.org/libc-alpha/86fsakz5mr.fsf@gentoo.org
>   for an explanation of what caused the need for norelro.  That fix was
>   misguided, due to a previous error on my part, too.
>   I applied this patch on top of that patchset and it would appear to
>   resolve all related failures.
>   The above is not applied to Git yet, but should be before this patch
>   is.
>
>  elf/Makefile | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
>  elf/Makefile | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)

The patches look okay to me, but would you please resend them with
Signed-off-by: (to mark this as a contribution under DCO)?  I had the
FSF records checked, and they don't have a glibc copyright assignment
from you, as far as we can tell.  Sorry for the hassle!

Thanks,
Florian


  parent reply	other threads:[~2023-03-07 11:42 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-07 10:29 Arsen Arsenović
2023-03-07 10:29 ` [PATCH v3 2/2] elf: Add missing dependency between resolvfail and testobj1.so Arsen Arsenović
2023-03-07 11:42 ` Florian Weimer [this message]
2023-03-07 11:53   ` [PATCH v3 1/2] elf,nptl: Add -z lazy to some more tests Arsen Arsenović
2023-03-07 12:08     ` Florian Weimer
2023-03-07 12:18       ` Arsen Arsenović
2023-03-07 12:28         ` Florian Weimer
2023-03-07 18:47           ` Arsen Arsenović
2023-03-10 16:54     ` Florian Weimer
2023-03-10 17:17       ` Arsen Arsenović

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fsagpz3g.fsf@oldenburg.str.redhat.com \
    --to=fweimer@redhat.com \
    --cc=arsen@gentoo.org \
    --cc=carlos@redhat.com \
    --cc=libc-alpha@sourceware.org \
    --cc=toolchain@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).