From: Florian Weimer <fweimer@redhat.com>
To: Letu Ren via Libc-alpha <libc-alpha@sourceware.org>
Cc: Letu Ren <fantasquex@gmail.com>
Subject: Re: [PATCH] stdlib/strfrom: Remove the -NAN testcase (bug 29501)
Date: Fri, 16 Sep 2022 11:53:14 +0200 [thread overview]
Message-ID: <87h717zlv9.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <20220915174421.4414-1-fantasquex@gmail.com> (Letu Ren via Libc-alpha's message of "Fri, 16 Sep 2022 01:44:21 +0800")
* Letu Ren via Libc-alpha:
> diff --git a/stdlib/tst-strfrom.c b/stdlib/tst-strfrom.c
> index 3a447eac12..1533fb9170 100644
> --- a/stdlib/tst-strfrom.c
> +++ b/stdlib/tst-strfrom.c
> @@ -37,7 +37,6 @@ static const struct test tests[] = {
> TEST ("5.900000e-16", "%e", 50, 12, 5.9e-16),
> TEST ("1.234500e+20", "%e", 50, 12, 12.345e19),
> TEST ("1.000000e+05", "%e", 50, 12, 1e5),
> - TEST ("-NAN", "%G", 50, 4, -NAN_),
> TEST ("-inf", "%g", 50, 4, -INF),
> TEST ("inf", "%g", 50, 3, INF)
> };
Shouldn't the test verify that the result is "NAN" or "-NAN"? That part
is still valid.
Thanks,
Florian
next prev parent reply other threads:[~2022-09-16 9:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-15 17:44 Letu Ren
2022-09-16 9:53 ` Florian Weimer [this message]
2022-09-16 11:06 ` Letu Ren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h717zlv9.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=fantasquex@gmail.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).