From: Letu Ren <fantasquex@gmail.com>
To: Florian Weimer <fweimer@redhat.com>
Cc: Letu Ren via Libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH] stdlib/strfrom: Remove the -NAN testcase (bug 29501)
Date: Fri, 16 Sep 2022 19:06:32 +0800 [thread overview]
Message-ID: <CAEUwDuDryjs+bAwa6R_nycX1=VKcW6XEymcxG6yDys-p1sk3Bg@mail.gmail.com> (raw)
In-Reply-To: <87h717zlv9.fsf@oldenburg.str.redhat.com>
> Shouldn't the test verify that the result is "NAN" or "-NAN"? That part
> is still valid.
Yes, I agree with you. Testing whether NAN is implemented correctly is
needed. The hard part is how to change the code. Currently, tests are
generated using macro. I'm not pretty sure how to adjust code that
generates tests. Two probable results or an array? Maybe another test
array instead of existing tests, stest, htest?
Now, I think a proper way might be changing this test to NAN, and
adding another class of test which accepts two possible results to
test -NAN. If you think that is OK, I would like to send another patch
v2.
Thanks for your review!
Letu Ren.
prev parent reply other threads:[~2022-09-16 11:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-15 17:44 Letu Ren
2022-09-16 9:53 ` Florian Weimer
2022-09-16 11:06 ` Letu Ren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEUwDuDryjs+bAwa6R_nycX1=VKcW6XEymcxG6yDys-p1sk3Bg@mail.gmail.com' \
--to=fantasquex@gmail.com \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).