From: Florian Weimer <fweimer@redhat.com>
To: "H.J. Lu via Libc-alpha" <libc-alpha@sourceware.org>
Subject: Re: [PATCH] elf: Make global.out depend on reldepmod4.so [BZ #28457]
Date: Mon, 25 Oct 2021 15:54:32 +0200 [thread overview]
Message-ID: <87ilxltdk7.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <20211015182924.1028229-1-hjl.tools@gmail.com> (H. J. Lu via Libc-alpha's message of "Fri, 15 Oct 2021 11:29:24 -0700")
* H. J. Lu via Libc-alpha:
> The global test is linked with globalmod1.so which dlopens reldepmod4.so.
> Make global.out depend on reldepmod4.so. This fixes BZ #28457.
> ---
> elf/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/elf/Makefile b/elf/Makefile
> index bf45d8ee24..b01ace2d5a 100644
> --- a/elf/Makefile
> +++ b/elf/Makefile
> @@ -976,7 +976,7 @@ $(objpfx)tst-rtld-preload.out: tst-rtld-preload.sh $(objpfx)ld.so \
> $(objpfx)initfirst.out: $(objpfx)firstobj.so
>
> $(objpfx)global: $(objpfx)globalmod1.so
> -$(objpfx)global.out: $(objpfx)reldepmod1.so
> +$(objpfx)global.out: $(objpfx)reldepmod1.so $(objpfx)reldepmod4.so
>
> $(objpfx)dblload.out: $(objpfx)dblloadmod1.so $(objpfx)dblloadmod2.so
Looks okay.
Reviewed-by: Florian Weimer <fweimer@redhat.com>
Thanks,
Florian
prev parent reply other threads:[~2021-10-25 13:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-15 18:29 H.J. Lu
2021-10-25 13:54 ` Florian Weimer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ilxltdk7.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).