public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] elf: Make global.out depend on reldepmod4.so [BZ #28457]
@ 2021-10-15 18:29 H.J. Lu
  2021-10-25 13:54 ` Florian Weimer
  0 siblings, 1 reply; 2+ messages in thread
From: H.J. Lu @ 2021-10-15 18:29 UTC (permalink / raw)
  To: libc-alpha

The global test is linked with globalmod1.so which dlopens reldepmod4.so.
Make global.out depend on reldepmod4.so.  This fixes BZ #28457.
---
 elf/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/elf/Makefile b/elf/Makefile
index bf45d8ee24..b01ace2d5a 100644
--- a/elf/Makefile
+++ b/elf/Makefile
@@ -976,7 +976,7 @@ $(objpfx)tst-rtld-preload.out: tst-rtld-preload.sh $(objpfx)ld.so \
 $(objpfx)initfirst.out: $(objpfx)firstobj.so
 
 $(objpfx)global: $(objpfx)globalmod1.so
-$(objpfx)global.out: $(objpfx)reldepmod1.so
+$(objpfx)global.out: $(objpfx)reldepmod1.so $(objpfx)reldepmod4.so
 
 $(objpfx)dblload.out: $(objpfx)dblloadmod1.so $(objpfx)dblloadmod2.so
 
-- 
2.31.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] elf: Make global.out depend on reldepmod4.so [BZ #28457]
  2021-10-15 18:29 [PATCH] elf: Make global.out depend on reldepmod4.so [BZ #28457] H.J. Lu
@ 2021-10-25 13:54 ` Florian Weimer
  0 siblings, 0 replies; 2+ messages in thread
From: Florian Weimer @ 2021-10-25 13:54 UTC (permalink / raw)
  To: H.J. Lu via Libc-alpha

* H. J. Lu via Libc-alpha:

> The global test is linked with globalmod1.so which dlopens reldepmod4.so.
> Make global.out depend on reldepmod4.so.  This fixes BZ #28457.
> ---
>  elf/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/elf/Makefile b/elf/Makefile
> index bf45d8ee24..b01ace2d5a 100644
> --- a/elf/Makefile
> +++ b/elf/Makefile
> @@ -976,7 +976,7 @@ $(objpfx)tst-rtld-preload.out: tst-rtld-preload.sh $(objpfx)ld.so \
>  $(objpfx)initfirst.out: $(objpfx)firstobj.so
>  
>  $(objpfx)global: $(objpfx)globalmod1.so
> -$(objpfx)global.out: $(objpfx)reldepmod1.so
> +$(objpfx)global.out: $(objpfx)reldepmod1.so $(objpfx)reldepmod4.so
>  
>  $(objpfx)dblload.out: $(objpfx)dblloadmod1.so $(objpfx)dblloadmod2.so

Looks okay.

Reviewed-by: Florian Weimer <fweimer@redhat.com>

Thanks,
Florian


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-10-25 13:54 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-15 18:29 [PATCH] elf: Make global.out depend on reldepmod4.so [BZ #28457] H.J. Lu
2021-10-25 13:54 ` Florian Weimer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).