From: Andreas Schwab <schwab@linux-m68k.org>
To: "H.J. Lu via Libc-alpha" <libc-alpha@sourceware.org>
Cc: Adhemerval Zanella <adhemerval.zanella@linaro.org>,
"H.J. Lu" <hjl.tools@gmail.com>,
Yu Chien Peter Lin <peterlin@andestech.com>,
Wilco Dijkstra <Wilco.Dijkstra@arm.com>
Subject: Re: [PATCH 1/2] stdlib: Fix __getrandom_nocancel type and arc4random usage (BZ #29638)
Date: Thu, 29 Sep 2022 22:01:15 +0200 [thread overview]
Message-ID: <87leq2osqc.fsf@igel.home> (raw)
In-Reply-To: <CAMe9rOp=1mpE2L11uxkNE1416pt=X12cOC2LAuw5iU1zPqxHnQ@mail.gmail.com> (H. J. Lu via Libc-alpha's message of "Thu, 29 Sep 2022 12:39:27 -0700")
On Sep 29 2022, H.J. Lu via Libc-alpha wrote:
>> diff --git a/sysdeps/unix/sysv/linux/not-cancel.h b/sysdeps/unix/sysv/linux/not-cancel.h
>> index a263d294b1..cf35c8bfc9 100644
>> --- a/sysdeps/unix/sysv/linux/not-cancel.h
>> +++ b/sysdeps/unix/sysv/linux/not-cancel.h
>> @@ -68,7 +68,7 @@ __writev_nocancel_nostatus (int fd, const struct iovec *iov, int iovcnt)
>> INTERNAL_SYSCALL_CALL (writev, fd, iov, iovcnt);
>> }
>>
>> -static inline int
>> +static inline ssize_t
>
> Shouldn't it be __syscall_slong_t?
getrandom can never return more than the size of the buffer.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
next prev parent reply other threads:[~2022-09-29 20:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-29 19:27 Adhemerval Zanella
2022-09-29 19:27 ` [PATCH v3 2/2] malloc: Do not clobber errno on __getrandom_nocancel (BZ #29624) Adhemerval Zanella
2022-09-30 15:09 ` Wilco Dijkstra
2022-09-30 16:29 ` Yann Droneaud
2022-09-30 16:37 ` Adhemerval Zanella Netto
2022-10-01 12:21 ` Yu-Chien Peter Lin
2022-09-29 19:39 ` [PATCH 1/2] stdlib: Fix __getrandom_nocancel type and arc4random usage (BZ #29638) H.J. Lu
2022-09-29 19:54 ` Adhemerval Zanella Netto
2022-09-29 20:01 ` Andreas Schwab [this message]
2022-09-30 15:05 ` Wilco Dijkstra
2022-10-01 12:16 ` Yu-Chien Peter Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87leq2osqc.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=Wilco.Dijkstra@arm.com \
--cc=adhemerval.zanella@linaro.org \
--cc=hjl.tools@gmail.com \
--cc=libc-alpha@sourceware.org \
--cc=peterlin@andestech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).