* [PATCH] Initialize wchar_t string with wmemset [BZ #27655]
@ 2021-03-27 16:24 H.J. Lu
2021-03-27 17:45 ` Florian Weimer
0 siblings, 1 reply; 6+ messages in thread
From: H.J. Lu @ 2021-03-27 16:24 UTC (permalink / raw)
To: libc-alpha
Use wmemset to initialize wchar_t string.
---
string/test-strnlen.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/string/test-strnlen.c b/string/test-strnlen.c
index a49d93afa2..6163079d12 100644
--- a/string/test-strnlen.c
+++ b/string/test-strnlen.c
@@ -27,6 +27,7 @@
#ifndef WIDE
# define STRNLEN strnlen
+# define MEMSET memset
# define CHAR char
# define BIG_CHAR CHAR_MAX
# define MIDDLE_CHAR 127
@@ -34,6 +35,7 @@
#else
# include <wchar.h>
# define STRNLEN wcsnlen
+# define MEMSET memset
# define CHAR wchar_t
# define BIG_CHAR WCHAR_MAX
# define MIDDLE_CHAR 1121
@@ -153,7 +155,7 @@ do_page_tests (void)
size_t last_offset = (page_size / sizeof (CHAR)) - 1;
CHAR *s = (CHAR *) buf2;
- memset (s, 65, (last_offset - 1));
+ MEMSET (s, 65, (last_offset - 1));
s[last_offset] = 0;
/* Place short strings ending at page boundary. */
--
2.30.2
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Initialize wchar_t string with wmemset [BZ #27655]
2021-03-27 16:24 [PATCH] Initialize wchar_t string with wmemset [BZ #27655] H.J. Lu
@ 2021-03-27 17:45 ` Florian Weimer
2021-03-27 17:49 ` [PATCH v2] " H.J. Lu
0 siblings, 1 reply; 6+ messages in thread
From: Florian Weimer @ 2021-03-27 17:45 UTC (permalink / raw)
To: H.J. Lu via Libc-alpha
* H. J. Lu via Libc-alpha:
> Use wmemset to initialize wchar_t string.
> ---
> string/test-strnlen.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/string/test-strnlen.c b/string/test-strnlen.c
> index a49d93afa2..6163079d12 100644
> --- a/string/test-strnlen.c
> +++ b/string/test-strnlen.c
> @@ -27,6 +27,7 @@
>
> #ifndef WIDE
> # define STRNLEN strnlen
> +# define MEMSET memset
> # define CHAR char
> # define BIG_CHAR CHAR_MAX
> # define MIDDLE_CHAR 127
> @@ -34,6 +35,7 @@
> #else
> # include <wchar.h>
> # define STRNLEN wcsnlen
> +# define MEMSET memset
> # define CHAR wchar_t
> # define BIG_CHAR WCHAR_MAX
> # define MIDDLE_CHAR 1121
Shouldn't the second one be wmemset?
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] Initialize wchar_t string with wmemset [BZ #27655]
2021-03-27 17:45 ` Florian Weimer
@ 2021-03-27 17:49 ` H.J. Lu
2021-03-27 17:52 ` Florian Weimer
0 siblings, 1 reply; 6+ messages in thread
From: H.J. Lu @ 2021-03-27 17:49 UTC (permalink / raw)
To: Florian Weimer; +Cc: H.J. Lu via Libc-alpha
[-- Attachment #1: Type: text/plain, Size: 906 bytes --]
On Sat, Mar 27, 2021 at 10:45 AM Florian Weimer <fw@deneb.enyo.de> wrote:
>
> * H. J. Lu via Libc-alpha:
>
> > Use wmemset to initialize wchar_t string.
> > ---
> > string/test-strnlen.c | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/string/test-strnlen.c b/string/test-strnlen.c
> > index a49d93afa2..6163079d12 100644
> > --- a/string/test-strnlen.c
> > +++ b/string/test-strnlen.c
> > @@ -27,6 +27,7 @@
> >
> > #ifndef WIDE
> > # define STRNLEN strnlen
> > +# define MEMSET memset
> > # define CHAR char
> > # define BIG_CHAR CHAR_MAX
> > # define MIDDLE_CHAR 127
> > @@ -34,6 +35,7 @@
> > #else
> > # include <wchar.h>
> > # define STRNLEN wcsnlen
> > +# define MEMSET memset
> > # define CHAR wchar_t
> > # define BIG_CHAR WCHAR_MAX
> > # define MIDDLE_CHAR 1121
>
> Shouldn't the second one be wmemset?
You are right. Here is the v2 patch.
--
H.J.
[-- Attachment #2: v2-0001-Initialize-wchar_t-string-with-wmemset-BZ-27655.patch --]
[-- Type: text/x-patch, Size: 1127 bytes --]
From c162fa01200f07277a1b4dd17f9522e8460aeaf8 Mon Sep 17 00:00:00 2001
From: "H.J. Lu" <hjl.tools@gmail.com>
Date: Sat, 27 Mar 2021 09:15:00 -0700
Subject: [PATCH v2] Initialize wchar_t string with wmemset [BZ #27655]
Use wmemset to initialize wchar_t string.
---
string/test-strnlen.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/string/test-strnlen.c b/string/test-strnlen.c
index a49d93afa2..b98dc10a56 100644
--- a/string/test-strnlen.c
+++ b/string/test-strnlen.c
@@ -27,6 +27,7 @@
#ifndef WIDE
# define STRNLEN strnlen
+# define MEMSET memset
# define CHAR char
# define BIG_CHAR CHAR_MAX
# define MIDDLE_CHAR 127
@@ -34,6 +35,7 @@
#else
# include <wchar.h>
# define STRNLEN wcsnlen
+# define MEMSET wmemset
# define CHAR wchar_t
# define BIG_CHAR WCHAR_MAX
# define MIDDLE_CHAR 1121
@@ -153,7 +155,7 @@ do_page_tests (void)
size_t last_offset = (page_size / sizeof (CHAR)) - 1;
CHAR *s = (CHAR *) buf2;
- memset (s, 65, (last_offset - 1));
+ MEMSET (s, 65, (last_offset - 1));
s[last_offset] = 0;
/* Place short strings ending at page boundary. */
--
2.30.2
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] Initialize wchar_t string with wmemset [BZ #27655]
2021-03-27 17:49 ` [PATCH v2] " H.J. Lu
@ 2021-03-27 17:52 ` Florian Weimer
2021-03-27 17:56 ` H.J. Lu
0 siblings, 1 reply; 6+ messages in thread
From: Florian Weimer @ 2021-03-27 17:52 UTC (permalink / raw)
To: H.J. Lu; +Cc: H.J. Lu via Libc-alpha
* H. J. Lu:
> Subject: [PATCH v2] Initialize wchar_t string with wmemset [BZ #27655]
>
> Use wmemset to initialize wchar_t string.
> ---
> string/test-strnlen.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/string/test-strnlen.c b/string/test-strnlen.c
> index a49d93afa2..b98dc10a56 100644
> --- a/string/test-strnlen.c
> +++ b/string/test-strnlen.c
> @@ -27,6 +27,7 @@
>
> #ifndef WIDE
> # define STRNLEN strnlen
> +# define MEMSET memset
> # define CHAR char
> # define BIG_CHAR CHAR_MAX
> # define MIDDLE_CHAR 127
> @@ -34,6 +35,7 @@
> #else
> # include <wchar.h>
> # define STRNLEN wcsnlen
> +# define MEMSET wmemset
> # define CHAR wchar_t
> # define BIG_CHAR WCHAR_MAX
> # define MIDDLE_CHAR 1121
> @@ -153,7 +155,7 @@ do_page_tests (void)
> size_t last_offset = (page_size / sizeof (CHAR)) - 1;
>
> CHAR *s = (CHAR *) buf2;
> - memset (s, 65, (last_offset - 1));
> + MEMSET (s, 65, (last_offset - 1));
> s[last_offset] = 0;
>
> /* Place short strings ending at page boundary. */
Patch looks good. Please change the commit message to mention that
this changes just a test.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] Initialize wchar_t string with wmemset [BZ #27655]
2021-03-27 17:52 ` Florian Weimer
@ 2021-03-27 17:56 ` H.J. Lu
2022-01-27 17:06 ` H.J. Lu
0 siblings, 1 reply; 6+ messages in thread
From: H.J. Lu @ 2021-03-27 17:56 UTC (permalink / raw)
To: Florian Weimer; +Cc: H.J. Lu via Libc-alpha
On Sat, Mar 27, 2021 at 10:52 AM Florian Weimer <fw@deneb.enyo.de> wrote:
>
> * H. J. Lu:
>
> > Subject: [PATCH v2] Initialize wchar_t string with wmemset [BZ #27655]
> >
> > Use wmemset to initialize wchar_t string.
> > ---
> > string/test-strnlen.c | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/string/test-strnlen.c b/string/test-strnlen.c
> > index a49d93afa2..b98dc10a56 100644
> > --- a/string/test-strnlen.c
> > +++ b/string/test-strnlen.c
> > @@ -27,6 +27,7 @@
> >
> > #ifndef WIDE
> > # define STRNLEN strnlen
> > +# define MEMSET memset
> > # define CHAR char
> > # define BIG_CHAR CHAR_MAX
> > # define MIDDLE_CHAR 127
> > @@ -34,6 +35,7 @@
> > #else
> > # include <wchar.h>
> > # define STRNLEN wcsnlen
> > +# define MEMSET wmemset
> > # define CHAR wchar_t
> > # define BIG_CHAR WCHAR_MAX
> > # define MIDDLE_CHAR 1121
> > @@ -153,7 +155,7 @@ do_page_tests (void)
> > size_t last_offset = (page_size / sizeof (CHAR)) - 1;
> >
> > CHAR *s = (CHAR *) buf2;
> > - memset (s, 65, (last_offset - 1));
> > + MEMSET (s, 65, (last_offset - 1));
> > s[last_offset] = 0;
> >
> > /* Place short strings ending at page boundary. */
>
> Patch looks good. Please change the commit message to mention that
> this changes just a test.
I changed the commit subject to
test-strnlen.c: Initialize wchar_t string with wmemset [BZ #27655]
--
H.J.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] Initialize wchar_t string with wmemset [BZ #27655]
2021-03-27 17:56 ` H.J. Lu
@ 2022-01-27 17:06 ` H.J. Lu
0 siblings, 0 replies; 6+ messages in thread
From: H.J. Lu @ 2022-01-27 17:06 UTC (permalink / raw)
To: Florian Weimer, Libc-stable Mailing List; +Cc: H.J. Lu via Libc-alpha
On Sat, Mar 27, 2021 at 10:56 AM H.J. Lu <hjl.tools@gmail.com> wrote:
>
> On Sat, Mar 27, 2021 at 10:52 AM Florian Weimer <fw@deneb.enyo.de> wrote:
> >
> > * H. J. Lu:
> >
> > > Subject: [PATCH v2] Initialize wchar_t string with wmemset [BZ #27655]
> > >
> > > Use wmemset to initialize wchar_t string.
> > > ---
> > > string/test-strnlen.c | 4 +++-
> > > 1 file changed, 3 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/string/test-strnlen.c b/string/test-strnlen.c
> > > index a49d93afa2..b98dc10a56 100644
> > > --- a/string/test-strnlen.c
> > > +++ b/string/test-strnlen.c
> > > @@ -27,6 +27,7 @@
> > >
> > > #ifndef WIDE
> > > # define STRNLEN strnlen
> > > +# define MEMSET memset
> > > # define CHAR char
> > > # define BIG_CHAR CHAR_MAX
> > > # define MIDDLE_CHAR 127
> > > @@ -34,6 +35,7 @@
> > > #else
> > > # include <wchar.h>
> > > # define STRNLEN wcsnlen
> > > +# define MEMSET wmemset
> > > # define CHAR wchar_t
> > > # define BIG_CHAR WCHAR_MAX
> > > # define MIDDLE_CHAR 1121
> > > @@ -153,7 +155,7 @@ do_page_tests (void)
> > > size_t last_offset = (page_size / sizeof (CHAR)) - 1;
> > >
> > > CHAR *s = (CHAR *) buf2;
> > > - memset (s, 65, (last_offset - 1));
> > > + MEMSET (s, 65, (last_offset - 1));
> > > s[last_offset] = 0;
> > >
> > > /* Place short strings ending at page boundary. */
> >
> > Patch looks good. Please change the commit message to mention that
> > this changes just a test.
>
> I changed the commit subject to
>
> test-strnlen.c: Initialize wchar_t string with wmemset [BZ #27655]
>
> --
> H.J.
I am backporting this to release branches.
--
H.J.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-01-27 17:06 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-27 16:24 [PATCH] Initialize wchar_t string with wmemset [BZ #27655] H.J. Lu
2021-03-27 17:45 ` Florian Weimer
2021-03-27 17:49 ` [PATCH v2] " H.J. Lu
2021-03-27 17:52 ` Florian Weimer
2021-03-27 17:56 ` H.J. Lu
2022-01-27 17:06 ` H.J. Lu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).