public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: libc-alpha@sourceware.org
Subject: Re: [PATCH v2] riscv: Update nofpu libm test ulps
Date: Mon, 11 Mar 2024 14:19:03 +0100	[thread overview]
Message-ID: <87v85soqig.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <ZeixBas1PNcz2Fbo@localhost.localdomain> (Darius Rad's message of "Wed, 6 Mar 2024 13:08:05 -0500")

* Darius Rad:

> Fix two test failures.
> ---
> Changes since v1:
>   - Rebase to master
>   - Fix corrupted diff line in patch
>
>  sysdeps/riscv/nofpu/libm-test-ulps | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/sysdeps/riscv/nofpu/libm-test-ulps b/sysdeps/riscv/nofpu/libm-test-ulps
> index 16106f10b0..bc7e615177 100644
> --- a/sysdeps/riscv/nofpu/libm-test-ulps
> +++ b/sysdeps/riscv/nofpu/libm-test-ulps
> @@ -1043,6 +1043,7 @@ ldouble: 8
>  
>  Function: "hypot":
>  double: 1
> +float: 1
>  ldouble: 1
>  
>  Function: "hypot_downward":

Looks okay.

Reviewed-by: Florian Weimer <fweimer@redhat.com>

Do you have sourceware commit access?  If not, I can push the change for
you.

(ULP updates like this can also be pushed without review as obvious, I
think.)

Thanks,
Florian


  reply	other threads:[~2024-03-11 13:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-06 18:08 Darius Rad
2024-03-11 13:19 ` Florian Weimer [this message]
2024-03-11 18:56   ` Darius Rad
2024-03-18 10:29     ` Florian Weimer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v85soqig.fsf@oldenburg.str.redhat.com \
    --to=fweimer@redhat.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).