From: Florian Weimer <fweimer@redhat.com>
To: Andreas Schwab <schwab@suse.de>
Cc: Florian Weimer via Libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH] elf: Introduce to _dl_call_fini
Date: Thu, 13 Oct 2022 14:11:22 +0200 [thread overview]
Message-ID: <87v8onylcl.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <mvmzge0aq1x.fsf@suse.de> (Andreas Schwab's message of "Thu, 13 Oct 2022 14:03:38 +0200")
* Andreas Schwab:
> On Okt 13 2022, Florian Weimer via Libc-alpha wrote:
>
>> This consolidates the destructor invocations from _dl_fini and
>> dlclose. Remove the micro-optimization that avoids
>> calling _dl_call_fini if they are no destructors (as dlclose is quite
>> expensive anyway).
>
> This also changes whether to print the debug message.
I've added, “The debug log message is now printed unconditionally.”
The change is practically invisible because crtbegin*.o from GCC has a
destructor.
>> @@ -53,6 +53,7 @@ routines = \
>> # profiled libraries.
>> dl-routines = \
>> dl-call-libc-early-init \
>> + dl-call_fini \
>
> Convention is to use dashes in file names.
I think we tend to use the underscore if it matches the symbol name
verbatim (perhaps without the _dl_ prefix).
Thanks,
Florian
next prev parent reply other threads:[~2022-10-13 12:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-13 11:35 Florian Weimer
2022-10-13 12:03 ` Andreas Schwab
2022-10-13 12:11 ` Florian Weimer [this message]
2022-10-21 17:51 ` Adhemerval Zanella Netto
2022-10-21 18:24 ` Florian Weimer
2022-10-21 18:40 ` Adhemerval Zanella Netto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v8onylcl.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).