From: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>
To: Florian Weimer <fweimer@redhat.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] elf: Introduce to _dl_call_fini
Date: Fri, 21 Oct 2022 15:40:16 -0300 [thread overview]
Message-ID: <b5bd45ac-2af2-8a34-8da7-41f2024c15a9@linaro.org> (raw)
In-Reply-To: <878rl9827n.fsf@oldenburg.str.redhat.com>
On 21/10/22 15:24, Florian Weimer wrote:
> * Adhemerval Zanella Netto:
>
>> On 13/10/22 08:35, Florian Weimer via Libc-alpha wrote:
>>> This consolidates the destructor invocations from _dl_fini and
>>> dlclose. Remove the micro-optimization that avoids
>>> calling _dl_call_fini if they are no destructors (as dlclose is quite
>>> expensive anyway).
>>>
>>
>> LGTM, I think the debug message change should be ok. Some comment on
>> the old code you refactored.
>
> Should I fix this and repost? Reviewed-by: plus suggestions is kind of
> confusing. 8-)
Right it was indeed confusing from my part. I think if you are ok with the
suggestions I don't think it is required to repost.
prev parent reply other threads:[~2022-10-21 18:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-13 11:35 Florian Weimer
2022-10-13 12:03 ` Andreas Schwab
2022-10-13 12:11 ` Florian Weimer
2022-10-21 17:51 ` Adhemerval Zanella Netto
2022-10-21 18:24 ` Florian Weimer
2022-10-21 18:40 ` Adhemerval Zanella Netto [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5bd45ac-2af2-8a34-8da7-41f2024c15a9@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).