public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Andreas Schwab <schwab@linux-m68k.org>
To: Florian Weimer via Libc-alpha <libc-alpha@sourceware.org>
Cc: Florian Weimer <fweimer@redhat.com>
Subject: Re: [PATCH] socket: Do not use AF_NETLINK in __opensock
Date: Wed, 17 Nov 2021 16:40:08 +0100	[thread overview]
Message-ID: <87y25mzt7r.fsf@igel.home> (raw)
In-Reply-To: <87ilwq6bu1.fsf@oldenburg.str.redhat.com> (Florian Weimer via Libc-alpha's message of "Wed, 17 Nov 2021 16:28:22 +0100")

On Nov 17 2021, Florian Weimer via Libc-alpha wrote:

> diff --git a/socket/opensock.c b/socket/opensock.c
> index ff94d27a61..cf4731abf1 100644
> --- a/socket/opensock.c
> +++ b/socket/opensock.c
> @@ -29,12 +29,6 @@ __opensock (void)
>    int type = SOCK_DGRAM | SOCK_CLOEXEC;
>    int fd;
>  
> -#ifdef AF_NETLINK
> -  fd = __socket (AF_NETLINK, type, 0);
> -  if (fd >= 0)
> -    return fd;
> -#endif

The comment is now outdated.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."

      reply	other threads:[~2021-11-17 15:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-17 15:28 Florian Weimer
2021-11-17 15:40 ` Andreas Schwab [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y25mzt7r.fsf@igel.home \
    --to=schwab@linux-m68k.org \
    --cc=fweimer@redhat.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).