* [PATCH] socket: Do not use AF_NETLINK in __opensock
@ 2021-11-17 15:28 Florian Weimer
2021-11-17 15:40 ` Andreas Schwab
0 siblings, 1 reply; 2+ messages in thread
From: Florian Weimer @ 2021-11-17 15:28 UTC (permalink / raw)
To: libc-alpha
It is not possible to use interface ioctls with netlink sockets
in all Linux kernels.
---
socket/opensock.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/socket/opensock.c b/socket/opensock.c
index ff94d27a61..cf4731abf1 100644
--- a/socket/opensock.c
+++ b/socket/opensock.c
@@ -29,12 +29,6 @@ __opensock (void)
int type = SOCK_DGRAM | SOCK_CLOEXEC;
int fd;
-#ifdef AF_NETLINK
- fd = __socket (AF_NETLINK, type, 0);
- if (fd >= 0)
- return fd;
-#endif
-
fd = __socket (AF_UNIX, type, 0);
if (fd >= 0)
return fd;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] socket: Do not use AF_NETLINK in __opensock
2021-11-17 15:28 [PATCH] socket: Do not use AF_NETLINK in __opensock Florian Weimer
@ 2021-11-17 15:40 ` Andreas Schwab
0 siblings, 0 replies; 2+ messages in thread
From: Andreas Schwab @ 2021-11-17 15:40 UTC (permalink / raw)
To: Florian Weimer via Libc-alpha; +Cc: Florian Weimer
On Nov 17 2021, Florian Weimer via Libc-alpha wrote:
> diff --git a/socket/opensock.c b/socket/opensock.c
> index ff94d27a61..cf4731abf1 100644
> --- a/socket/opensock.c
> +++ b/socket/opensock.c
> @@ -29,12 +29,6 @@ __opensock (void)
> int type = SOCK_DGRAM | SOCK_CLOEXEC;
> int fd;
>
> -#ifdef AF_NETLINK
> - fd = __socket (AF_NETLINK, type, 0);
> - if (fd >= 0)
> - return fd;
> -#endif
The comment is now outdated.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-11-17 15:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-17 15:28 [PATCH] socket: Do not use AF_NETLINK in __opensock Florian Weimer
2021-11-17 15:40 ` Andreas Schwab
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).