public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: "Dmitry V. Levin" <ldv@altlinux.org>
Cc: libc-alpha@sourceware.org
Subject: Re: One test per line, one source per line, etc. etc. etc.
Date: Mon, 28 Jun 2021 12:05:10 +0200	[thread overview]
Message-ID: <87y2auuwx5.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <20210628092246.GA3836@altlinux.org> (Dmitry V. Levin's message of "Mon, 28 Jun 2021 12:22:47 +0300")

* Dmitry V. Levin:

> On Sun, Jun 27, 2021 at 10:14:09PM +0200, Florian Weimer via Libc-alpha wrote:
>> * Carlos O'Donell via Libc-alpha:
>> 
>> > Do we have consensus for someone to just cleanup all the makefiles
>> > to have one source per line, one test per line etc.?
>> 
>> I think there was some opposition to trailing \ in lists in Makefiles.
>> This:
>> 
>> routines += \
>>   read \
>>   write \
>> 
>> vs:
>> 
>> routines += \
>>   read \
>>   write
>
> I'd suggest this instead:
>
> routines += \
>   read \
>   write \
>   #

Or even:

routines += \
  read \
  write \
  # routines

It seems to work:

“
routines += \
  read \
  write \
  # routines
stop = 1

all: print-routines print-stop

print-%:
	@echo "$* = $($*)"
”

This prints:

“
routines = read write 
stop = 1
”

Thanks,
Florian


  reply	other threads:[~2021-06-28 10:06 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-27 19:58 Carlos O'Donell
2021-06-27 20:14 ` Florian Weimer
2021-06-27 21:52   ` Carlos O'Donell
2021-06-28  7:24     ` Andreas Schwab
2021-06-28 11:42       ` Carlos O'Donell
2021-06-28  9:22   ` Dmitry V. Levin
2021-06-28 10:05     ` Florian Weimer [this message]
2021-06-28 11:45       ` Carlos O'Donell
2021-06-28 18:52 ` DJ Delorie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y2auuwx5.fsf@oldenburg.str.redhat.com \
    --to=fweimer@redhat.com \
    --cc=ldv@altlinux.org \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).